grahamc/hydra2 - Change 5N367XMTKTDQ6CT77LRJFJOKWEBTYBPQQIEOA4I24DJTPVKZG7GAC

jobset view: jump back to the proper tab when displaying all failed jobsets

When I press "n builds omitted" I get back to the first tab of a jobset. This is extremely counter-intuitive, instead this notice should link to the currently opened tab.

Created by Maximilian Bosch on July 15, 2018

5N367XMTKTDQ6CT77LRJFJOKWEBTYBPQQIEOA4I24DJTPVKZG7GAC

Dependencies

In channels

main

Change contents

Replacement in src/root/jobset-eval.tt at line 99 [4.4844]

B:BD[3.1563] → [3.1563:1756]

  <tr><td class="centered" colspan="6"><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id], params) %]"><em>([% size - max %] more builds omitted)</em></a></td></tr>

[3.1563]

[3.1756]

  <tr><td class="centered" colspan="6"><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id], params) %][% tabname %]"><em>([% size - max %] more builds omitted)</em></a></td></tr>

Replacement in src/root/jobset-eval.tt at line 107 [4.4844]

B:BD[2.651] → [2.651:695]

    [% INCLUDE renderSome builds=aborted %]

[2.651]

[2.695]

    [% INCLUDE renderSome builds=aborted tabname="#tabs-aborted" %]

Replacement in src/root/jobset-eval.tt at line 111 [4.4844]

B:BD[3.1862] → [3.1862:1906]

    [% INCLUDE renderSome builds=nowFail %]

[3.1862]

[3.1906]

    [% INCLUDE renderSome builds=nowFail tabname="#tabs-now-fail" %]

Replacement in src/root/jobset-eval.tt at line 115 [4.4844]

B:BD[3.1963] → [3.1963:2010]

    [% INCLUDE renderSome builds=nowSucceed %]

[3.1963]

[3.2010]

    [% INCLUDE renderSome builds=nowSucceed tabname="#tabs-now-succeed" %]

Replacement in src/root/jobset-eval.tt at line 119 [4.4844]

B:BD[3.2059] → [3.2059:2099]

    [% INCLUDE renderSome builds=new %]

[3.2059]

[3.2099]

    [% INCLUDE renderSome builds=new tabname="#tabs-new" %]

Replacement in src/root/jobset-eval.tt at line 136 [4.4844]

B:BD[3.2706] → [3.2706:2905]

          <tr><td class="centered" colspan="2"><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id], params) %]"><em>([% size - max %] more jobs omitted)</em></a></td></tr>

[3.2706]

[3.2905]

          <tr><td class="centered" colspan="2"><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id], params) %]#tabs-removed"><em>([% size - max %] more jobs omitted)</em></a></td></tr>

Replacement in src/root/jobset-eval.tt at line 143 [4.4844]

B:BD[3.3007] → [3.3007:3053]

    [% INCLUDE renderSome builds=stillFail %]

[3.3007]

[3.3053]

    [% INCLUDE renderSome builds=stillFail tabname="#tabs-still-fail" %]

Replacement in src/root/jobset-eval.tt at line 147 [4.4844]

B:BD[3.3112] → [3.3112:3161]

    [% INCLUDE renderSome builds=stillSucceed %]

[3.3112]

[3.3161]

    [% INCLUDE renderSome builds=stillSucceed tabname="#tabs-still-succeed" %]

Replacement in src/root/jobset-eval.tt at line 151 [4.4844]

B:BD[3.3217] → [3.3217:3264]

    [% INCLUDE renderSome builds=unfinished %]

[3.3217]

[5.4422]

    [% INCLUDE renderSome builds=unfinished tabname="#tabs-unfinished" %]