grahamc/hydra2 - Change 5WNGKHLZF5UGSQMFFGGDKN4NHNN4KAGXT7BTT2OR3ELGUUKM5CPQC

Plugins: Add isEnabled method

Plugins are now disabled at startup time unless there is some relevant configuration in hydra.conf. This avoids hydra-notify having to do a lot of redundant work (a lot of plugins did a lot of database queries before deciding they were disabled).

Note: BitBucketStatus users will need to add 'enable_bitbucket_status = 1' to hydra.conf.

Created by Eelco Dolstra on August 13, 2019

5WNGKHLZF5UGSQMFFGGDKN4NHNN4KAGXT7BTT2OR3ELGUUKM5CPQC

Dependencies

In channels

main

Change contents

Insertion in src/lib/Hydra/Plugin/BitBucketStatus.pm at line 10 [6.1]

[6.167]

sub isEnabled {
    my ($self) = @_;
    return $self->{config}->{enable_bitbucket_status} == 1;
}

Insertion in src/lib/Hydra/Plugin/CircleCINotification.pm at line 10 [5.1]

[5.172]

sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{circleci};
}

Insertion in src/lib/Hydra/Plugin/CoverityScan.pm at line 9 [3.1]

[3.177]

sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{coverityscan};
}

Insertion in src/lib/Hydra/Plugin/EmailNotification.pm at line 12 [13.21]

[12.38]

sub isEnabled {
    my ($self) = @_;
    return $self->{config}->{email_notification} == 1;
}

Deletion in src/lib/Hydra/Plugin/EmailNotification.pm at line 51 [13.21]
B:BD[7.156] → [7.156:218]
∅:D[14.71] → [13.749:750]
∅:D[7.218] → [13.749:750]
B:BD[13.749] → [13.749:750]
```
    return unless $self->{config}->{email_notification} // 0;
```

Insertion in src/lib/Hydra/Plugin/GithubStatus.pm at line 11 [4.58]

[4.221]

sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{githubstatus};
}

Insertion in src/lib/Hydra/Plugin/GitlabStatus.pm at line 19 [10.1]

[10.637]

sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{gitlab_authorization};
}

Insertion in src/lib/Hydra/Plugin/HipChatNotification.pm at line 8 [15.47]

[15.188]

sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{hipchat};
}

Insertion in src/lib/Hydra/Plugin/InfluxDBNotification.pm at line 10 [11.2620]
[11.2795]
[11.2795]
```
sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{influxdb};
}
```

Insertion in src/lib/Hydra/Plugin/RunCommand.pm at line 8 [8.1]

[8.120]

sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{runcommand};
}

Insertion in src/lib/Hydra/Plugin/S3Backup.pm at line 17 [16.1707]

[16.2000]

[2.0]

sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{s3backup};
}

Insertion in src/lib/Hydra/Plugin/SlackNotification.pm at line 10 [17.69]

[17.237]

[9.0]

sub isEnabled {
    my ($self) = @_;
    return defined $self->{config}->{slack};
}

Insertion in src/lib/Hydra/Plugin.pm at line 13 [13.5909]
[14.458]
[18.3455]
```
}
sub isEnabled {
    return 1;
```

Replacement in src/lib/Hydra/Plugin.pm at line 23 [13.5909]

B:BD[18.3558] → [18.3558:3602]

    push @$plugins, $class->plugins(%args);

[18.3558]

[18.3602]

    push @$plugins, grep { $_->isEnabled } $class->plugins(%args);