grahamc/hydra2 - Change 6HWIUOSURE7QRA7AUY2Y6CSNWYV36CAXCZ6I6QU24U7GBZ3ODD5AC

Avoid fetching Projects/Jobsets just to get the name column

In particular, doing a 'select * from Jobsets where …' must be avoided, because the 'errormsg' column can be very big.

Created by Eelco Dolstra on August 13, 2019

6HWIUOSURE7QRA7AUY2Y6CSNWYV36CAXCZ6I6QU24U7GBZ3ODD5AC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Controller/API.pm at line 79 [8.24]

B:BD[8.2633] → [9.213:256]

        project => $jobset->project->name,

[8.2633]

[9.256]

        project => $jobset->get_column('project'),

Replacement in src/lib/Hydra/Controller/API.pm at line 209 [8.24]

∅:D[4.42] → [10.0:91]

B:BD[11.297] → [10.0:91]

    print STDERR "triggering jobset ", $jobset->project->name . ":" . $jobset->name, "\n";

[4.42]

[11.297]

    print STDERR "triggering jobset ", $jobset->get_column('project') . ":" . $jobset->name, "\n";

Replacement in src/lib/Hydra/Controller/API.pm at line 214 [8.24]

B:BD[11.397] → [11.397:496]

    push @{$c->{stash}->{json}->{jobsetsTriggered}}, $jobset->project->name . ":" . $jobset->name;

[11.397]

[11.496]

    push @{$c->{stash}->{json}->{jobsetsTriggered}}, $jobset->get_column('project') . ":" . $jobset->name;

Replacement in src/lib/Hydra/Controller/JobsetEval.pm at line 145 [12.1302]

B:BD[2.114] → [2.114:197]

    $releaseName = $eval->project->name."-".$eval->id unless defined $releaseName;

[2.114]

[13.391]

    $releaseName = $eval->get_column('project') . "-" . $eval->id unless defined $releaseName;

Replacement in src/lib/Hydra/Helper/CatalystUtils.pm at line 63 [15.3469]

B:BD[14.366] → [14.366:479]

      , project => $build->project->name
      , jobset => $build->jobset->name
      , job => $build->job->name

[14.366]

[16.2472]

      , project => $build->get_column('project')
      , jobset => $build->get_column('jobset')
      , job => $build->get_column('job')

Replacement in src/lib/Hydra/Helper/CatalystUtils.pm at line 80 [15.3469]

B:BD[17.855] → [17.855:968]

      , project => $build->project->name
      , jobset => $build->jobset->name
      , job => $build->job->name

[17.855]

[17.968]

      , project => $build->get_column('project')
      , jobset => $build->get_column('jobset')
      , job => $build->get_column('job')

Replacement in src/lib/Hydra/Helper/CatalystUtils.pm at line 292 [15.3469]

B:BD[18.367] → [18.367:456]

    return $build->project->name . ":" . $build->jobset->name . ":" . $build->job->name;

[18.367]

[18.456]

    return $build->get_column('project') . ":" . $build->get_column('jobset') . ":" . $build->get_column('job');

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 103 [21.21]

B:BD[19.1502] → [20.308:383]

            , showSystem => index($build->job->name, $build->system) == -1

[19.1502]

[22.455]

            , showSystem => index($build->get_column('job'), $build->system) == -1

Replacement in src/lib/Hydra/Plugin/EmailNotification.pm at line 122 [21.21]

B:BD[23.2190] → [23.2190:2362]

            [ 'X-Hydra-Project'  => $build->project->name,
            , 'X-Hydra-Jobset'   => $build->jobset->name,
            , 'X-Hydra-Job'      => $build->job->name,

[23.2190]

[23.2362]

            [ 'X-Hydra-Project'  => $build->get_column('project'),
            , 'X-Hydra-Jobset'   => $build->get_column('jobset'),
            , 'X-Hydra-Job'      => $build->get_column('job'),

Replacement in src/lib/Hydra/Plugin/GitlabStatus.pm at line 58 [6.1]

B:BD[6.1801] → [6.1801:1851]

                name => "Hydra " . $b->job->name,

[6.1801]

[6.1851]

                name => "Hydra " . $b->get_column('job'),

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 62 [24.47]

B:BD[24.1887] → [24.1887:2034]

        $msg .= "Job <a href='$baseurl/job/${\$build->project->name}/${\$build->jobset->name}/${\$build->job->name}'>${\showJobName($build)}</a>";

[24.1887]

[24.2034]

        $msg .= "Job <a href='$baseurl/job/${\$build->get_column('project')}/${\$build->get_column('jobset')}/${\$build->get_column('job')}'>${\showJobName($build)}</a>";

Replacement in src/lib/Hydra/Plugin/InfluxDBNotification.pm at line 107 [7.2620]

B:BD[7.5326] → [7.5326:5530]

            project => $b->project->name,
            jobset  => $b->jobset->name,
            repo    => ($b->jobset->name =~ /^(.*)\.pr-/) ? $1 : $b->jobset->name,
            job     => $b->job->name,

[7.5326]

[7.5530]

            project => $b->get_column('project'),
            jobset  => $b->get_column('jobset'),
            repo    => ($b->get_column('jobset') =~ /^(.*)\.pr-/) ? $1 : $b->get_column('jobset'),
            job     => $b->get_column('job'),

Replacement in src/lib/Hydra/Plugin/SlackNotification.pm at line 84 [3.69]

B:BD[3.2283] → [3.2283:2419]

        $text .= "Job <$baseurl/job/${\$build->project->name}/${\$build->jobset->name}/${\$build->job->name}|${\showJobName($build)}>";

[3.2283]

[3.2419]

        $text .= "Job <$baseurl/job/${\$build->get_column('project')}/${\$build->get_column('jobset')}/${\$build->get_column('job')}|${\showJobName($build)}>";

Replacement in src/script/hydra-eval-jobset at line 441 [25.1319]

B:BD[5.14661] → [5.14661:14756]

                { project => $jobset->project->name, jobset => $jobset->name, job => $jobName,

[5.14661]

[5.14756]

                { project => $jobset->get_column('project'), jobset => $jobset->name, job => $jobName,

Replacement in src/script/hydra-eval-jobset at line 492 [25.1319]

B:BD[5.16793] → [5.16793:16902]

        print STDERR "added build ${\$build->id} (${\$jobset->project->name}:${\$jobset->name}:$jobName)\n";

[5.16793]

[5.16902]

        print STDERR "added build ${\$build->id} (${\$jobset->get_column('project')}:${\$jobset->name}:$jobName)\n";

Replacement in src/script/hydra-eval-jobset at line 534 [25.1319]
∅:D[26.1039] → [27.671:717]
B:BD[28.1180] → [27.671:717]
```
    my $projectName = $jobset->project->name;
```
[28.1180]
[27.717]
```
    my $projectName = $jobset->get_column('project');
```