grahamc/hydra2 - Change 6KJXJB7NZ5XJ3WGUWKFNT6LMBNYJN3IPHZ7B7H654D5B6LPOL5QAC

qualify ordery_by clauses when necessary, remove unnecessary order_by's, reported by Ludo, resulted in errors in sqlite

Created by Rob Vermaas on April 1, 2011

6KJXJB7NZ5XJ3WGUWKFNT6LMBNYJN3IPHZ7B7H654D5B6LPOL5QAC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Controller/Admin.pm at line 20 [11.1]
∅:D[6.43] → [10.83:85]
B:BD[10.83] → [10.83:85]
```
	
```
[6.43]
[10.85]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 41 [11.1]
B:BD[10.849] → [10.849:879]
```
    close (NIXMACHINES);     
```
[10.849]
[10.879]
```
    close (NIXMACHINES);
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 53 [11.1]
B:BD[10.981] → [10.981:994]
```
        {}, 
```
[10.981]
[7.0]
```
        {},
```

Replacement in src/lib/Hydra/Controller/Admin.pm at line 60 [11.1]

B:BD[10.1376] → [10.1376:1472]

        { join => [ 'schedulingInfo', 'build' ] 
        , order_by => [ 'machine', 'outpath' ]

[10.1376]

[10.1472]

        { join => [ 'schedulingInfo', 'build' ]
        , order_by => [ 'machine' ]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 65 [11.1]
B:BD[10.1491] → [12.233:235]
```
 
```
[10.1491]
[12.235]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 73 [11.1]

B:BD[12.538] → [12.538:601]

    my $roles         = $c->request->params->{"roles"} ;

[12.538]

[12.674]

    my $roles         = $c->request->params->{"roles"} ;

Replacement in src/lib/Hydra/Controller/Admin.pm at line 84 [11.1]
B:BD[12.1005] → [12.1005:1022]
```
        }       
```
[12.1005]
[12.1022]
```
        }
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 87 [11.1]
∅:D[9.72] → [12.1089:1098]
B:BD[12.1089] → [12.1089:1098]
```
    }   
```
[9.72]
[12.1098]
```
    }
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 126 [11.1]
B:BD[12.2007] → [12.2007:2047]
```
   my ($to, $subject, $body) = @_; 
   
```
[12.2007]
[12.2047]
```
   my ($to, $subject, $body) = @_;
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 130 [11.1]
B:BD[12.2132] → [12.2132:2136]
```
   
```
[12.2132]
[12.2136]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 148 [11.1]
B:BD[12.2536] → [12.2536:2541]
```
    
```
[12.2536]
[12.2541]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 157 [11.1]
B:BD[12.2692] → [12.2692:2725]
```
        $c->user->emailaddress, 
```
[12.2692]
[12.2725]
```
        $c->user->emailaddress,
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 216 [11.1]
∅:D[4.63] → [10.3210:3272]
B:BD[10.3210] → [10.3210:3272]
```
    my $systems       = $c->request->params->{"systems"} ; 
	
```
[4.63]
[10.3272]
```
    my $systems       = $c->request->params->{"systems"} ;
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 222 [11.1]
B:BD[10.3631] → [10.3631:3637]
```
    	
```
[10.3631]
[10.3637]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 234 [11.1]
B:BD[10.3998] → [10.3998:4012]
```
	    }       
```
[10.3998]
[10.4012]
```
	    }
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 237 [11.1]
B:BD[10.4100] → [10.4100:4109]
```
    }   
```
[10.4100]
[10.4109]
```
    }
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 244 [11.1]
B:BD[10.4235] → [10.4235:4240]
```
    
```
[10.4235]
[10.4240]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 256 [11.1]
B:BD[10.4578] → [10.4578:4583]
```
    
```
[10.4578]
[5.0]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 259 [11.1]
B:BD[10.4711] → [10.4711:4716]
```
    
```
[10.4711]
[10.4716]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 275 [11.1]
B:BD[10.5157] → [10.5157:5169]
```
    });    
```
[10.5157]
[10.5169]
```
    });
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 307 [11.1]
B:BD[11.921] → [11.921:926]
```
    
```
[11.921]
[11.926]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 325 [11.1]
B:BD[11.1346] → [11.1346:1389]
```
    $c->stash->{template} = 'news.tt';    
```
[11.1346]
[11.1389]
```
    $c->stash->{template} = 'news.tt';
```
Replacement in src/lib/Hydra/Controller/Admin.pm at line 332 [11.1]
B:BD[11.1516] → [11.1516:1521]
```
    
```
[11.1516]
[11.1521]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 335 [11.1]
B:BD[11.1607] → [11.1607:1612]
```
    
```
[11.1607]
[11.1612]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 353 [11.1]
B:BD[11.2123] → [11.2123:2132]
```
        
```
[11.2123]
[11.2132]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 359 [11.1]
B:BD[13.143] → [13.143:148]
```
    
```
[13.143]
[13.148]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 367 [11.1]
B:BD[13.508] → [13.508:513]
```
    
```
[13.508]
[13.513]
Replacement in src/lib/Hydra/Controller/Admin.pm at line 369 [11.1]
B:BD[13.629] → [13.629:642]
```
            
```
[13.629]
[13.642]

Replacement in src/lib/Hydra/Controller/Root.pm at line 18 [16.804]

B:BD[14.464] → [15.33:101]

    $c->stash->{nixVersion} = $ENV{"NIX_RELEASE"} || "<devel>";

[14.464]

[15.101]

    $c->stash->{nixVersion} = $ENV{"NIX_RELEASE"} || "<devel>";

Replacement in src/lib/Hydra/Controller/Root.pm at line 40 [16.804]
B:BD[17.476] → [17.476:481]
```
    
```
[17.476]
[17.481]
Replacement in src/lib/Hydra/Controller/Root.pm at line 61 [16.804]
B:BD[17.1022] → [17.1022:1027]
```
    
```
[17.1022]
[17.1027]
Replacement in src/lib/Hydra/Controller/Root.pm at line 85 [16.804]
B:BD[3.22] → [3.22:52]
```
    $c->stash->{pit} = $pit; 
```
[3.22]
[3.52]
```
    $c->stash->{pit} = $pit;
```

Replacement in src/lib/Hydra/Controller/Root.pm at line 93 [16.804]

B:BD[18.375] → [18.375:542]

        , '+select' => [ 'resultInfo.starttime', 'resultInfo.stoptime', 'resultInfo.buildstatus' ]   
        , '+as' => [ 'starttime', 'stoptime', 'buildstatus' ]

[18.375]

[18.542]

        , '+select' => [ 'resultInfo.starttime', 'resultInfo.stoptime', 'resultInfo.buildstatus' ]
        , '+as' => [ 'starttime', 'stoptime', 'buildstatus' ]

Replacement in src/lib/Hydra/Controller/Root.pm at line 103 [16.804]

B:BD[15.544] → [10.5705:5754]

∅:D[10.5754] → [15.584:631]

B:BD[15.584] → [15.584:631]

        { join => [ 'schedulingInfo', 'build' ] 
        , order_by => [ 'machine', 'outpath' ]

[15.544]

[15.631]

        { join => [ 'schedulingInfo', 'build' ]
        , order_by => [ 'machine' ]

Replacement in src/lib/Hydra/Controller/Root.pm at line 161 [16.804]
B:BD[19.603] → [19.603:608]
```
    
```
[19.603]
[2.455]
Replacement in src/lib/Hydra/Controller/Root.pm at line 166 [16.804]
B:BD[20.9653] → [20.9653:9658]
```
    
```
[20.9653]
[16.1511]
Replacement in src/lib/Hydra/Controller/Root.pm at line 204 [16.804]
B:BD[12.3125] → [12.3125:3130]
```
    
```
[12.3125]
[12.3130]

Replacement in src/lib/Hydra/Controller/Root.pm at line 206 [16.804]

B:BD[12.3172] → [12.3172:3230]

    
    $c->stash->{template} = 'change-password.tt';

[12.3172]

[12.3230]


    $c->stash->{template} = 'change-password.tt';

Replacement in src/lib/Hydra/Controller/Root.pm at line 212 [16.804]
B:BD[12.3330] → [12.3330:3335]
```
    
```
[12.3330]
[12.3335]

Replacement in src/lib/Hydra/Controller/Root.pm at line 214 [16.804]

B:BD[12.3377] → [12.3377:3437]

    
    my $password = $c->request->params->{"password"};

[12.3377]

[12.3437]


    my $password = $c->request->params->{"password"};

Replacement in src/lib/Hydra/Controller/Root.pm at line 220 [16.804]
B:BD[12.3673] → [12.3673:3678]
```
    
```
[12.3673]
[12.3678]
Replacement in src/lib/Hydra/Controller/Root.pm at line 223 [16.804]
B:BD[12.3763] → [12.3763:3800]
```
    
    $c->res->redirect("/");    
```
[12.3763]
[12.3800]
```
    $c->res->redirect("/");
```
Replacement in src/script/hydra_update_gc_roots.pl.in at line 49 [21.472]
B:BD[8.334] → [8.334:343]
```
        
```
[8.334]
[8.343]
Replacement in src/script/hydra_update_gc_roots.pl.in at line 54 [21.472]
∅:D[8.503] → [22.1761:1770]
B:BD[22.1761] → [22.1761:1770]
```
        
```
[8.503]
[22.1770]

Replacement in src/script/hydra_update_gc_roots.pl.in at line 72 [21.472]

B:BD[22.2617] → [22.2617:2661]

                    , order_by => 'id DESC'

[22.2617]

[22.2661]

                    , order_by => 'me.id DESC'

qualify ordery_by clauses when necessary, remove unnecessary order_by's, reported by Ludo, resulted in errors in sqlite

Dependencies

In channels

Change contents

Replacement in src/lib/Hydra/Controller/Admin.pm at line 20 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 41 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 53 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 60 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 65 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 73 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 84 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 87 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 126 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 130 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 148 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 157 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 216 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 222 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 234 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 237 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 244 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 256 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 259 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 275 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 307 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 325 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 332 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 335 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 353 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 359 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 367 [11.1]

Replacement in src/lib/Hydra/Controller/Admin.pm at line 369 [11.1]

Replacement in src/lib/Hydra/Controller/Root.pm at line 18 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 40 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 61 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 85 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 93 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 103 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 161 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 166 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 204 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 206 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 212 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 214 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 220 [16.804]

Replacement in src/lib/Hydra/Controller/Root.pm at line 223 [16.804]

Replacement in src/script/hydra_update_gc_roots.pl.in at line 49 [21.472]

Replacement in src/script/hydra_update_gc_roots.pl.in at line 54 [21.472]

Replacement in src/script/hydra_update_gc_roots.pl.in at line 72 [21.472]