grahamc/hydra2 - Change BEFHUCGNM3FRVAEDTOSSBRKOUNRC2IIYKEIVIVREUBGAEORVRQJAC

Factor a getResponsibleAuthors helper out of the HipChatNotification

Signed-off-by: Shea Levy <shea@shealevy.com>

Created by Shea Levy on October 7, 2013

BEFHUCGNM3FRVAEDTOSSBRKOUNRC2IIYKEIVIVREUBGAEORVRQJAC

Dependencies

In channels

main

Change contents

Insertion in src/lib/Hydra/Helper/CatalystUtils.pm at line 30 [7.3469]
[2.144]
[6.180]
```
    getResponsibleAuthors
```

Insertion in src/lib/Hydra/Helper/CatalystUtils.pm at line 252 [7.3469]

[8.1816]

[6.367]


# Determine who broke/fixed the build.
sub getResponsibleAuthors {
    my ($build, $plugins) = @_;

Insertion in src/lib/Hydra/Helper/CatalystUtils.pm at line 258 [7.3469]
[6.368]
[6.368]
```
    my $prevBuild = getPreviousBuild($build);
```

Insertion in src/lib/Hydra/Helper/CatalystUtils.pm at line 260 [7.3469]

[6.369]

[7.3787]

    my $nrCommits = 0;
    my %authors;
    if ($prevBuild) {
        foreach my $curInput ($build->buildinputs_builds) {
            next unless ($curInput->type eq "git" || $curInput->type eq "hg");
            my $prevInput = $prevBuild->buildinputs_builds->find({ name => $curInput->name });
            next unless defined $prevInput;
            next if $curInput->type ne $prevInput->type;
            next if $curInput->uri ne $prevInput->uri;
            next if $curInput->revision eq $prevInput->revision;
            my @commits;
            foreach my $plugin (@{$plugins}) {
                push @commits, @{$plugin->getCommits($curInput->type, $curInput->uri, $prevInput->revision, $curInput->revision)};
            }
            foreach my $commit (@commits) {
                #print STDERR "$commit->{revision} by $commit->{author}\n";
                $authors{$commit->{author}} = $commit->{email};
                $nrCommits++;
            }
        }
    }
    return (\%authors, $nrCommits);
}

Deletion in src/lib/Hydra/Plugin/HipChatNotification.pm at line 42 [10.47]

B:BD[9.2076] → [9.2076:2200]

B:BD[9.2200] → [4.0:79]

∅:D[4.79] → [9.2250:2502]

B:BD[9.2250] → [9.2250:2502]

B:BD[9.2502] → [5.0:65]

∅:D[5.65] → [10.1278:1279]

∅:D[9.2502] → [10.1278:1279]

B:BD[10.1278] → [10.1278:1279]

B:BD[10.1279] → [9.2503:2728]


    my $nrCommits = 0;
    my %authors;
    if ($prevBuild) {
        foreach my $curInput ($build->buildinputs_builds) {
            next unless ($curInput->type eq "git" || $curInput->type eq "hg");
            my $prevInput = $prevBuild->buildinputs_builds->find({ name => $curInput->name });
            next unless defined $prevInput;
            next if $curInput->type ne $prevInput->type;
            next if $curInput->uri ne $prevInput->uri;
            next if $curInput->revision eq $prevInput->revision;
            my @commits;
            foreach my $plugin (@{$self->{plugins}}) {
                push @commits, @{$plugin->getCommits($curInput->type, $curInput->uri, $prevInput->revision, $curInput->revision)};
            }

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 43 [10.47]

B:BD[9.2729] → [9.2729:2773]

B:BD[9.2773] → [3.0:76]

∅:D[3.76] → [9.2848:2972]

B:BD[9.2848] → [9.2848:2972]

            foreach my $commit (@commits) {
                #print STDERR "$commit->{revision} by $commit->{author}\n";
                $authors{$commit->{author}} = $commit->{email};
                $nrCommits++;
            }
        }
    }

[9.2729]

[9.2972]

    my ($authors, $nrCommits) = getResponsibleAuthors($build, $self->{plugins});

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 63 [10.47]
B:BD[10.2197] → [9.2974:3014]
```
        if (scalar keys %authors > 0) {
```
[10.2197]
[9.3014]
```
        if (scalar keys %{$authors} > 0) {
```

Replacement in src/lib/Hydra/Plugin/HipChatNotification.pm at line 65 [10.47]

B:BD[9.3049] → [9.3049:3138]

            my @x = map { "<a href='mailto:$authors{$_}'>$_</a>" } (sort keys %authors);

[9.3049]

[9.3138]

            my @x = map { "<a href='mailto:$authors->{$_}'>$_</a>" } (sort keys %{$authors});