grahamc/hydra2 - Change DDMYFZ5XWW6O3TGCVNW4GPVR2ZPRFWIPQU54DCVUYARFXIMKENUQC

Fix the jobset unchanged check

When checking whether the jobset is unchanged, we need to compare with the previous JobsetEval regardless of whether it had new builds. Otherwise we'll keep adding new JobsetEval rows.

Created by Eelco Dolstra on March 12, 2012

DDMYFZ5XWW6O3TGCVNW4GPVR2ZPRFWIPQU54DCVUYARFXIMKENUQC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Helper/AddBuilds.pm at line 791 [3.2663]

B:BD[2.94] → [2.94:216]

# Return the most recent evaluation of the given jobset that had new
# builds, or undefined if no such evaluation exists.

[2.94]

[2.216]

# Return the most recent evaluation of the given jobset (that
# optionally had new builds), or undefined if no such evaluation
# exists.

Replacement in src/lib/Hydra/Helper/AddBuilds.pm at line 795 [3.2663]

B:BD[2.240] → [2.240:372]

    my ($db, $jobset) = @_;
    my ($prevEval) = $jobset->jobsetevals({ hasnewbuilds => 1 }, { order_by => "id DESC", rows => 1 });

[2.240]

[2.372]

    my ($db, $jobset, $hasNewBuilds) = @_;
    my ($prevEval) = $jobset->jobsetevals(
        ($hasNewBuilds ? { hasnewbuilds => 1 } : { }), 
        { order_by => "id DESC", rows => 1 });

Replacement in src/script/hydra-evaluator at line 113 [5.1319]

B:BD[4.2334] → [2.1869:1961]

    my $prevEval = getPrevJobsetEval($db, $jobset);
    if ($prevEval->hash eq $argsHash) {

[4.2334]

[2.1961]

    if (getPrevJobsetEval($db, $jobset, 0)->hash eq $argsHash) {

Insertion in src/script/hydra-evaluator at line 128 [5.1319]
[6.5278]
[2.2020]
```
        my $prevEval = getPrevJobsetEval($db, $jobset, 1);
```

Insertion in src/script/hydra-evaluator at line 170 [5.1319]

[7.6534]

            print STDERR "  created new eval ", $ev->id, "\n";
        } else {
            print STDERR "  created cached eval ", $ev->id, "\n";