grahamc/hydra2 - Change EFWDY2V7ILJBFQ6NADBESYZTPHQBXKNO5N4DPNABL7X4XMNNTNYAC

Support testing build determinism

Builds can now specify the attribute "isDeterministic = true" to tell Hydra to build with build-repeat > 0. If there is a mismatch between rounds, the step / build fails with a suitable status.

Maybe this should be a meta attribute, but that makes it invisible to hydra-queue-runner, and it seems reasonable to make a claim of mandatory determinism part of the derivation (since e.g. enabling this flag should trigger a rebuild).

Created by Eelco Dolstra on December 6, 2016

EFWDY2V7ILJBFQ6NADBESYZTPHQBXKNO5N4DPNABL7X4XMNNTNYAC

Dependencies

In channels

main

Change contents

Replacement in src/hydra-queue-runner/build-remote.cc at line 172 [4.85]
B:BD[2.415] → [2.415:457]
```
            to << SERVE_MAGIC_1 << 0x202;
```
[2.415]
[2.457]
```
            to << SERVE_MAGIC_1 << 0x203;
```

Insertion in src/hydra-queue-runner/build-remote.cc at line 183 [4.85]

[2.1013]

[5.91]

            if (GET_PROTOCOL_MINOR(remoteVersion) < 3 && step->isDeterministic)
                throw Error("machine ‘%1%’ does not support deterministic builds; please upgrade it to Nix 1.12", machine->sshName);

Insertion in src/hydra-queue-runner/build-remote.cc at line 266 [4.85]

[2.3765]

        if (GET_PROTOCOL_MINOR(remoteVersion) >= 3)
            // FIXME: make the number of repeats configurable.
            to << (step->isDeterministic ? 1 : 0);

Insertion in src/hydra-queue-runner/build-remote.cc at line 332 [4.85]

[2.6391]

                    break;
                case BuildResult::NotDeterministic:
                    result.stepStatus = bsNotDeterministic;
                    result.canRetry = false;
                    result.canCache = true;

Insertion in src/hydra-queue-runner/queue-monitor.cc at line 421 [8.20067]
[6.1009]
[7.197]
```
    step->isDeterministic = get(step->drv.env, "isDetermistic", "0") == "1";
```
Insertion in src/hydra-queue-runner/state.hh at line 38 [11.1128]
[9.3973]
[10.996]
```
    bsNotDeterministic = 12,
```
Insertion in src/hydra-queue-runner/state.hh at line 143 [11.1128]
[11.2488]
[12.514]
```
    bool isDeterministic;
```

Insertion in src/root/build.tt at line 72 [14.7350]

[9.4463]

[13.20001]

              [% ELSIF step.status == 12 %]
                <span class="error">Non-deterministic build</span>

Insertion in src/root/common.tt at line 212 [16.2803]

[3.1704]

[15.4181]

    [% ELSIF buildstatus == 12 %]
      <img src="[% c.uri_for("/static/images/emojione-red-x-274c.svg") %]" height="[% size %]" width="[% size %]" title="Non-deterministic build" alt="Non-deterministic build" class="build-status" />

Insertion in src/root/common.tt at line 245 [16.2803]

[9.4716]

[17.2353]

    [% ELSIF buildstatus == 12 %]
      <span class="error">Non-deterministic build</span>

Insertion in src/sql/hydra.sql at line 214 [19.1]
[9.4754]
[18.4847]
```
    --  12 = build or step was not deterministic
```

Support testing build determinism

Dependencies

In channels

Change contents

Replacement in src/hydra-queue-runner/build-remote.cc at line 172 [4.85]

Insertion in src/hydra-queue-runner/build-remote.cc at line 183 [4.85]

Insertion in src/hydra-queue-runner/build-remote.cc at line 266 [4.85]

Insertion in src/hydra-queue-runner/build-remote.cc at line 332 [4.85]

Insertion in src/hydra-queue-runner/queue-monitor.cc at line 421 [8.20067]

Insertion in src/hydra-queue-runner/state.hh at line 38 [11.1128]

Insertion in src/hydra-queue-runner/state.hh at line 143 [11.1128]

Insertion in src/root/build.tt at line 72 [14.7350]

Insertion in src/root/common.tt at line 212 [16.2803]

Insertion in src/root/common.tt at line 245 [16.2803]

Insertion in src/sql/hydra.sql at line 214 [19.1]