grahamc/hydra2 - Change J7EE2XZAB5EZICAZGZ6DKM4JDMH73A5AJIW6INYMWJHENIGVANQAC

Fix a huge performance regression in the jobstatus page

The renderBuildStatusIcon function was looking at the resultInfo and schedulingInfo of each build, causing a SQL query for every build in the result.

Created by Eelco Dolstra on November 29, 2011

J7EE2XZAB5EZICAZGZ6DKM4JDMH73A5AJIW6INYMWJHENIGVANQAC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 19 [8.1]

∅:D[3.149] → [7.615:741]

B:BD[7.615] → [7.615:741]

        { '+select' => ["me.statusChangeId", "me.statusChangeTime"]
        , '+as' => ["statusChangeId", "statusChangeTime"]

[3.149]

[2.0]

        { '+select' => ["me.statusChangeId", "me.statusChangeTime", "resultInfo.buildStatus"]
        , '+as' => ["statusChangeId", "statusChangeTime", "buildStatus"]

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 67 [8.1]

B:BD[8.823] → [9.64:147]

    $c->stash->{builds} = [joinWithResultInfo($c, $c->stash->{allBuilds})->search(

[8.823]

[10.114]

    $c->stash->{builds} = [ joinWithResultInfo($c, $c->stash->{allBuilds})->search(

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 69 [8.1]

B:BD[10.141] → [9.148:187]

        { order_by => "timestamp DESC"

[10.141]

[10.337]

        { '+select' => ["resultInfo.buildStatus"]
        , '+as' => ["buildStatus"]
        , order_by => "timestamp DESC"

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 73 [8.1]
B:BD[10.371] → [10.371:400]
```
        , page => $page })];
```
[10.371]
[8.981]
```
        , page => $page }) ];
```

Replacement in src/lib/Hydra/Controller/Job.pm at line 28 [13.46]

B:BD[11.1145] → [12.0:329]

    $c->stash->{currentBuilds} = [$c->stash->{job}->builds->search({iscurrent => 1}, { join => 'resultInfo', '+select' => ["resultInfo.releasename", "resultInfo.buildstatus"]
                                                                                     , '+as' => ["releasename", "buildstatus"], order_by => 'system' })];

[11.1145]

[14.0]

    $c->stash->{currentBuilds} = [$c->stash->{job}->builds->search({iscurrent => 1}, { join => 'resultInfo', '+select' => ["resultInfo.releasename", "resultInfo.buildStatus"]
                                                                                     , '+as' => ["releasename", "buildStatus"], order_by => 'system' })];

Replacement in src/lib/Hydra/Controller/Job.pm at line 31 [13.46]

B:BD[14.1] → [15.0:173]

B:BD[15.173] → [4.0:179]

    $c->stash->{lastBuilds} = [$c->stash->{job}->builds->search({ finished => 1 }, { join => 'resultInfo', '+select' => ["resultInfo.releasename", "resultInfo.buildstatus"]
                                                                                          , '+as' => ["releasename", "buildstatus"], order_by => 'timestamp DESC', rows => 10 })];

[14.1]

[14.328]

    $c->stash->{lastBuilds} = 
	[ $c->stash->{job}->builds->search({ finished => 1 }, 
	    { join => 'resultInfo', 
	    , '+select' => ["resultInfo.releasename", "resultInfo.buildStatus"]
	    , '+as' => ["releasename", "buildStatus"]
	    , order_by => 'timestamp DESC', rows => 10 
	    }) ];

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 85 [16.104]

B:BD[5.376] → [5.376:483]

	[ joinWithResultInfo($c, $tmp)->search({ finished => 1 }, { order_by => "timestamp DESC", rows => 5 }) ];

[5.376]

[16.819]

	[ joinWithResultInfo($c, $tmp)->search({ finished => 1 }, 
            { order_by => "timestamp DESC", rows => 5
            , '+select' => ["resultInfo.buildStatus"]
            , '+as' => ["buildStatus"]
            }) ];

Replacement in src/root/common.tt at line 103 [19.2803]

B:BD[17.1290] → [18.0:58]

              [% INCLUDE renderBuildStatusIcon size=16 %]

[17.1290]

[6.0]

              [% INCLUDE renderBuildStatusIcon size=16 busy=(showSchedulingInfo ? 1 : 0) buildstatus=build.get_column('buildStatus') %]

Replacement in src/root/common.tt at line 206 [19.2803]

B:BD[20.14644] → [20.14644:14680]

B:BD[20.14680] → [6.19:138]

[% BLOCK renderBuildStatusIcon; %] 
  [% finished = build != undef ? build.finished : 1  %]
  [% busy = build != undef ? build.schedulingInfo.busy : 0  %]

[20.14644]

[6.138]

[% BLOCK renderBuildStatusIcon %] 
  [% finished = build != undef ? build.finished : 1 %]
  [% busy = busy != undef ? busy : build.schedulingInfo.busy %]

Replacement in src/root/common.tt at line 233 [19.2803]
B:BD[20.15729] → [20.15729:15756]
```
[% BLOCK renderStatus; %] 
```
[20.15729]
[6.1171]
```
[% BLOCK renderStatus %] 
```
Insertion in src/root/common.tt at line 235 [19.2803]
[6.1197]
[6.1197]
```
    [% INCLUDE renderBuildStatusIcon size=16 %]
```
Deletion in src/root/common.tt at line 237 [19.2803]
B:BD[6.1244] → [6.1244:1294]
```
      [% INCLUDE renderBuildStatusIcon size=16 %]
```
Deletion in src/root/common.tt at line 239 [19.2803]
B:BD[6.1375] → [6.1375:1425]
```
      [% INCLUDE renderBuildStatusIcon size=16 %]
```
Deletion in src/root/common.tt at line 241 [19.2803]
B:BD[6.1544] → [6.1544:1594]
```
      [% INCLUDE renderBuildStatusIcon size=16 %]
```
Deletion in src/root/common.tt at line 243 [19.2803]
B:BD[6.1710] → [6.1710:1760]
```
      [% INCLUDE renderBuildStatusIcon size=16 %]
```
Deletion in src/root/common.tt at line 245 [19.2803]
B:BD[6.1861] → [6.1861:1911]
```
      [% INCLUDE renderBuildStatusIcon size=16 %]
```
Deletion in src/root/common.tt at line 249 [19.2803]
B:BD[6.2243] → [6.2243:2293]
```
      [% INCLUDE renderBuildStatusIcon size=16 %]
```
Deletion in src/root/common.tt at line 251 [19.2803]
B:BD[6.2368] → [6.2368:2418]
```
      [% INCLUDE renderBuildStatusIcon size=16 %]
```

Fix a huge performance regression in the jobstatus page

Dependencies

In channels

Change contents

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 19 [8.1]

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 67 [8.1]

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 69 [8.1]

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 73 [8.1]

Replacement in src/lib/Hydra/Controller/Job.pm at line 28 [13.46]

Replacement in src/lib/Hydra/Controller/Job.pm at line 31 [13.46]

Replacement in src/lib/Hydra/Controller/Jobset.pm at line 85 [16.104]

Replacement in src/root/common.tt at line 103 [19.2803]

Replacement in src/root/common.tt at line 206 [19.2803]

Replacement in src/root/common.tt at line 233 [19.2803]

Insertion in src/root/common.tt at line 235 [19.2803]

Deletion in src/root/common.tt at line 237 [19.2803]

Deletion in src/root/common.tt at line 239 [19.2803]

Deletion in src/root/common.tt at line 241 [19.2803]

Deletion in src/root/common.tt at line 243 [19.2803]

Deletion in src/root/common.tt at line 245 [19.2803]

Deletion in src/root/common.tt at line 249 [19.2803]

Deletion in src/root/common.tt at line 251 [19.2803]