grahamc/hydra2 - Change JGLE5BRNJTMCZFZ33G2SGOQ4F3CIZAPMU3IXCNMR5NNSG5EJLX6QC

Add separate build step status codes for cached failures and timeouts

Created by Eelco Dolstra on May 9, 2013

JGLE5BRNJTMCZFZ33G2SGOQ4F3CIZAPMU3IXCNMR5NNSG5EJLX6QC

Dependencies

In channels

main

Change contents

Insertion in src/root/build.tt at line 53 [4.7350]

[3.1245]

              [% ELSIF step.status == 7 %]
                <span class="error">Timed out</span>
              [% ELSIF step.status == 8 %]
                <span class="error">Cached failure</span>

Replacement in src/script/hydra-build at line 40 [6.2912]

B:BD[5.266] → [2.0:48]

    my ($drvPath, $errorMsg, $dependents) = @_;

[5.266]

[5.301]

    my ($drvPath, $status, $errorMsg, $dependents) = @_;

Replacement in src/script/hydra-build at line 70 [6.2912]
B:BD[5.1353] → [5.1353:1383]
```
                , status => 1
```
[5.1353]
[5.1383]
```
                , status => $status
```

Replacement in src/script/hydra-build at line 185 [6.2912]

B:BD[7.3884] → [8.154:271]

                my $errorMsg = $4;
                $errorMsg = "build failed previously (cached)" if $3 eq "cached";

[7.3884]

[9.1010]

                my $errorMsg;
                my $status = 1;
                if ($3 eq "cached") {
                    $status = 8;
                } elsif ($3 eq "timeout") {
                    $status = 7;
                } else {
                    $errorMsg = $4;
                }

Replacement in src/script/hydra-build at line 197 [6.2912]

B:BD[10.507] → [8.272:378]

                        $step->update({busy => 0, status => 1, errormsg => $errorMsg, stoptime => time});

[10.507]

[11.0]

                        $step->update({busy => 0, status => $status, errormsg => $errorMsg, stoptime => time});

Replacement in src/script/hydra-build at line 208 [6.2912]

B:BD[12.3319] → [12.3319:3361]

                            , status => 1

[12.3319]

[12.3361]

                            , status => $status

Replacement in src/script/hydra-build at line 218 [6.2912]

B:BD[5.1708] → [2.171:241]

                failDependents($drvPathStep, $errorMsg, $dependents);

[5.1708]

[13.649]

                failDependents($drvPathStep, $status, $errorMsg, $dependents);

Replacement in src/script/hydra-build at line 264 [6.2912]
∅:D[14.71] → [7.4107:4166]
∅:D[15.100] → [7.4107:4166]
B:BD[7.4107] → [7.4107:4166]
```
            elsif ($someBuildFailed) { $buildStatus = 2; }
```
[15.100]
[7.4166]
```
            elsif (!$thisBuildFailed && $someBuildFailed) { $buildStatus = 2; }
```

Replacement in src/sql/hydra.sql at line 211 [18.1]

B:BD[16.7403] → [17.2509:2563]

    status        integer, -- 0 = success, 1 = failed

[16.7403]

[16.7430]

    -- Status codes:
    --   0 = succeeded
    --   1 = failed normally
    --   4 = aborted
    --   7 = timed out
    --   8 = cached failure
    status        integer,