grahamc/hydra2 - Change JIJDYWPYMZZNFBCWYSYR72RNEW5MSI26MJ5UXXIU7DDX25IBR3CQC

Remove the Build menu from the top bar

It's now a dropdown menu in the tabs thingy, which subsumes the "Reproduce locally" button. This makes the actions in the menu a bit more visible, IMHO.

Created by Eelco Dolstra on October 2, 2013

JIJDYWPYMZZNFBCWYSYR72RNEW5MSI26MJ5UXXIU7DDX25IBR3CQC

Dependencies

In channels

main

Change contents

Deletion in src/lib/Hydra/Controller/Build.pm at line 446 [7.1]
∅:D[5.622] → [6.0:35]
B:BD[8.5] → [6.0:35]
```
    my $drvpath = $build->drvpath;
```

Replacement in src/lib/Hydra/Controller/Build.pm at line 447 [7.1]

B:BD[8.90] → [6.36:84]

        unless $build->finished && -f $drvpath;

[8.90]

[9.521]

        unless $build->finished && -f $build->drvpath;

Insertion in src/root/build.tt at line 71 [11.7350]

[10.1530]

  <li class="dropdown">
    <a class="dropdown-toggle" data-toggle="dropdown" href="#">
      Actions
      <b class="caret"></b>
    </a>
    <ul class="dropdown-menu">
      [% IF build.nixexprinput %]
        <li><a href="#reproduce" data-toggle="modal">Reproduce locally</a></li>
      [% END %]
      [% IF c.user_exists %]
        <li><a href="[% c.uri_for('/build' build.id 'clone') %]">Clone</a></li>
        [% IF available %]
          [% IF build.keep %]
            <li><a href="[% c.uri_for('/build' build.id 'keep' 0) %]">Unkeep</a></li>
          [% ELSE %]
            <li><a href="[% c.uri_for('/build' build.id 'keep' 1) %]">Keep</a></li>
          [% END %]
        [% END %]
        [% IF build.finished %]
          <li><a href="[% c.uri_for('/build' build.id 'restart') %]">Restart</a></li>
        [% ELSE %]
          <li><a href="[% c.uri_for('/build' build.id 'cancel') %]">Cancel</a></li>
        [% END %]
        [% IF available && project.releases %]
          [% INCLUDE menuItem
            uri = "#add-to-release"
            title = "Add to release"
            modal = 1 %]
        [% END %]
      [% END %]
    </ul>
  </li>

Deletion in src/root/build.tt at line 117 [11.7350]

∅:D[10.2266] → [12.6451:6452]

B:BD[12.6451] → [12.6451:6452]

B:BD[12.6452] → [13.318:350]

B:BD[13.350] → [3.0:105]

∅:D[3.105] → [14.58:530]

B:BD[14.58] → [14.58:530]


    [% IF build.nixexprinput %]
      [% WRAPPER makePopover title="Reproduce locally" classes="btn-info pull-right" placement="left" %]
        [% url = c.uri_for('/build' build.id 'reproduce') %]
        <p>You can reproduce this build on your own machine by
        downloading <a [% HTML.attributes(href => url) %]>a script</a>
        that checks out all inputs of the build and then invokes Nix
        to perform the build.  This script requires that you have Nix
        on your system.</p>
        <p>To download and execute the script from the command line,
        run the following command:</p>

Deletion in src/root/build.tt at line 118 [11.7350]
B:BD[14.531] → [14.531:537]
B:BD[14.537] → [3.106:220]
∅:D[3.220] → [14.615:639]
B:BD[14.615] → [14.615:639]
∅:D[14.639] → [13.510:525]
B:BD[13.510] → [13.510:525]
```
<pre>
<span class="shell-prompt">$ </span>bash <(curl <a [% HTML.attributes(href => url) %]>[% HTML.escape(url) %]</a>)
</pre>
      [% END %]
    [% END %]
```

Insertion in src/root/build.tt at line 585 [11.7350]

[4.862]

[11.8444]

<div id="reproduce" class="modal hide fade" tabindex="-1" role="dialog" aria-hidden="true">
  [% url = c.uri_for('/build' build.id 'reproduce') %]
  <div class="modal-header">
    <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button>
    <h3>Reproduce this build</h3>
  </div>
  <div class="modal-body">
    <p>You can reproduce this build on your own machine by downloading
    <a [% HTML.attributes(href => url) %]>a script</a> that checks out
    all inputs of the build and then invokes Nix to perform the build.
    This script requires that you have Nix on your system.</p>
    <p>To download and execute the script from the command line, run the
    following command:</p>
<pre>
<span class="shell-prompt">$ </span>bash <(curl <a [% HTML.attributes(href => url) %]>[% HTML.escape(url) %]</a>)
</pre>
  </div>
  <div class="modal-footer">
    <a href="#" class="btn btn-primary clode" data-dismiss="modal">Close</a>
  </div>
</div>

Insertion in src/root/common.tt at line 465 [15.2803]
[14.1164]
[14.1164]

Insertion in src/root/common.tt at line 467 [15.2803]

[14.1165]

BLOCK menuItem %]
  <li class="[% IF "${root}${curUri}" == uri %]active[% END %]" [% IF confirmmsg %]onclick="javascript:return confirm('[% confirmmsg %]')"[% END %]>
    <a href="[% uri %]" [% IF modal %]data-toggle="modal"[% END %]>[% title %]</a>
  </li>
[% END;

Deletion in src/root/topbar.tt at line 1 [17.6671]

B:BD[16.10450] → [16.10450:10471]

B:BD[16.10471] → [18.299:448]

B:BD[18.448] → [4.863:946]

∅:D[4.946] → [17.6811:6819]

B:BD[17.6811] → [17.6811:6819]

∅:D[19.6608] → [17.6894:6905]

B:BD[17.6894] → [17.6894:6905]

[% BLOCK menuItem %]
  <li class="[% IF "${root}${curUri}" == uri %]active[% END %]" [% IF confirmmsg %]onclick="javascript:return confirm('[% confirmmsg %]')"[% END %]>
    <a href="[% uri %]" [% IF modal %]data-toggle="modal"[% END %]>[% title %]</a>
  </li>
[% END %]

Deletion in src/root/topbar.tt at line 112 [17.6671]

B:BD[16.14441] → [20.1889:1906]

B:BD[20.1906] → [2.426:552]

∅:D[2.552] → [21.368:394]

B:BD[22.1751] → [21.368:394]

∅:D[21.394] → [23.5415:5488]

B:BD[22.1777] → [23.5415:5488]

∅:D[23.5488] → [24.0:29]

B:BD[22.1831] → [24.0:29]

B:BD[24.29] → [20.1907:1941]

B:BD[20.1941] → [21.395:423]

∅:D[21.423] → [20.1969:2114]

B:BD[20.1969] → [20.1969:2114]

B:BD[20.2114] → [21.424:456]

∅:D[21.456] → [20.2146:2246]

B:BD[20.2146] → [20.2146:2246]

∅:D[20.2246] → [24.359:380]

B:BD[24.359] → [24.359:380]

B:BD[24.380] → [21.457:489]

∅:D[21.489] → [20.2279:2377]

B:BD[20.2279] → [20.2279:2377]

∅:D[20.2377] → [24.516:536]

B:BD[24.516] → [24.516:536]

B:BD[24.536] → [20.2378:2428]

B:BD[20.2428] → [21.490:520]

∅:D[21.520] → [24.537:633]

B:BD[25.226] → [24.537:633]

B:BD[24.633] → [20.2429:2480]

B:BD[20.2480] → [21.521:551]

∅:D[21.551] → [26.30:124]

B:BD[26.30] → [26.30:124]

B:BD[26.124] → [4.947:1140]

∅:D[4.1140] → [20.2481:2499]

B:BD[26.124] → [20.2481:2499]

∅:D[26.124] → [25.318:334]

∅:D[24.633] → [25.318:334]

∅:D[20.2499] → [25.318:334]

B:BD[25.318] → [25.318:334]

∅:D[27.221] → [22.1831:1845]

B:BD[22.1831] → [22.1831:1845]

B:BD[22.1845] → [20.2500:2512]

∅:D[20.2512] → [22.1858:1859]

B:BD[22.1858] → [22.1858:1859]

  [% IF build %]
    [% WRAPPER makeSubMenu title="Build" %]
      <li class="nav-header">#[% build.id %]</li>
      <li class="divider"></li>
      [% INCLUDE menuItem
        uri = c.uri_for('/build' build.id)
        title = "Overview" %]
      [% IF c.user_exists %]
        <li class="divider"></li>
        [% INCLUDE menuItem
          uri = c.uri_for('/build' build.id 'clone')
          title = "Clone build" %]
        [% IF available %]
          [% IF build.keep %]
            [% INCLUDE menuItem
               uri = c.uri_for('/build' build.id 'keep' 0)
               title = "Unkeep build" %]
          [% ELSE %]
            [% INCLUDE menuItem
               uri = c.uri_for('/build' build.id 'keep' 1)
               title = "Keep build" %]
          [% END %]
        [% END %]
        [% IF build.finished %]
          [% INCLUDE menuItem
            uri = c.uri_for('/build' build.id 'restart')
            title = "Restart build" %]
        [% END %]
        [% IF !build.finished %]
          [% INCLUDE menuItem
            uri = c.uri_for('/build' build.id 'cancel')
            title = "Cancel build" %]
        [% END %]
        [% IF available && project.releases %]
          [% INCLUDE menuItem
            uri = "#add-to-release"
            title = "Add to release"
            modal = 1 %]
        [% END %]
      [% END %]
    [% END %]
  [% END %]