grahamc/hydra2 - Change KMC2LLBUMVS7J6IIJEEYKFQENJIGLMTT33V2SBL3GTK4QUWC3P3AC

common.tt: Properly generate URL for /api/scmdiff.

If Hydra isn't hosted on https://example.com/ but something like https://example.com/hydra/, the URL for /api/scmdiff would have ended up on /api/scmdiff rather than /hydra/api/scmdiff.

This is because we didn't use the URI resolver from the controller, hence we're using it now to build up the whole URL including the query string.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>

Created by aszlig on July 22, 2015

KMC2LLBUMVS7J6IIJEEYKFQENJIGLMTT33V2SBL3GTK4QUWC3P3AC

Dependencies

In channels

main

Change contents

Replacement in src/root/common.tt at line 274 [4.2803]

B:BD[3.6091] → [2.542:704]

      <a target="_blank" href="[% HTML.escape("/api/scmdiff?uri=$url&rev1=$bi1.revision&rev2=$bi2.revision&type=$bi1.type&branch=$branch") %]">[% contents %]</a>

[3.6091]

[3.6255]

      <a target="_blank" href="[% HTML.escape(c.uri_for('/api/scmdiff', {
        uri = url,
        rev1 = bi1.revision,
        rev2 = bi2.revision,
        type = bi1.type,
        branch = branch
      })) %]">[% contents %]</a>