grahamc/hydra2 - Change L6PVAEWJ4OHOMO3UBEM5XYR74DWGERFVXQTHKFD4BMACQAYWSQ6AC

perlcritic: don't open files as bare words

Created by Graham Christensen on September 6, 2021

L6PVAEWJ4OHOMO3UBEM5XYR74DWGERFVXQTHKFD4BMACQAYWSQ6AC

Dependencies

In channels

main

Change contents

Replacement in src/lib/Hydra/Helper/Nix.pm at line 144 [6.436]

∅:D[3.24] → [5.0:91]

B:BD[7.968] → [5.0:91]

    open ROOT, ">$link" or die "cannot create GC root `$link' to `$path'";
    close ROOT;

[3.24]

[8.751]

    open my $root, ">$link" or die "cannot create GC root `$link' to `$path'";
    close $root;

Replacement in src/lib/Hydra/Helper/Nix.pm at line 344 [6.436]

B:BD[4.2084] → [4.2084:2128]

∅:D[4.2128] → [9.644:669]

B:BD[9.644] → [9.644:669]

        open CONF, "<$machinesFile" or die;
        while (<CONF>) {

[4.2084]

[9.669]

        open my $conf, "<$machinesFile" or die;
        while (<$conf>) {

Replacement in src/lib/Hydra/Helper/Nix.pm at line 361 [6.436]
B:BD[9.1350] → [9.1350:1370]
```
        close CONF;
```
[9.1350]
[9.1370]
```
        close $conf;
```

Replacement in src/lib/Hydra/Plugin/CoverityScan.pm at line 55 [2.1]

B:BD[2.1517] → [2.1517:1588]

    opendir TARBALLS, $tarballs or die;
    while (readdir TARBALLS) {

[2.1517]

[2.1588]

    opendir my $tarballs_handle, $tarballs or die;
    while (readdir $tarballshandle) {

Replacement in src/lib/Hydra/Plugin/CoverityScan.pm at line 60 [2.1]
B:BD[2.1707] → [2.1707:1730]
```
    closedir TARBALLS;
```
[2.1707]
[2.1730]
```
    closedir $tarballs_handle;
```

Replacement in src/script/hydra-s3-backup-collect-garbage at line 29 [10.7579]

B:BD[10.8345] → [10.8345:8417]

opendir DIR, $gcRootsDir or die;
my @roots = readdir DIR;
closedir DIR;

[10.8345]

[10.8417]

opendir my $dir, $gcRootsDir or die;
my @roots = readdir $dir;
closedir $dir;

Replacement in src/script/hydra-update-gc-roots at line 66 [12.472]

B:BD[11.228] → [11.228:300]

opendir DIR, $gcRootsDir or die;
my @roots = readdir DIR;
closedir DIR;

[11.228]

[11.300]

opendir my $dir, $gcRootsDir or die;
my @roots = readdir $dir;
closedir $dir;

Replacement in t/s3-backup-test.pl at line 42 [10.9772]

B:BD[10.11440] → [10.11440:11494]

opendir DIR, $gcRootsDir or die;
while(readdir DIR) {

[10.11440]

[10.11494]

opendir my $dir, $gcRootsDir or die;
while(readdir $dir) {

Replacement in t/s3-backup-test.pl at line 47 [10.9772]
B:BD[10.11562] → [10.11562:11576]
```
closedir DIR;
```
[10.11562]
[10.11576]
```
closedir $dir;
```