grahamc/hydra2 - Change Q4VDOA762MDHLJKNJMPLHFYRRACCT3DQXF66ZTVMETZCR52B72OQC

Replace last 5 builds on jobset page with last 5 evaluations. Moved hide/unhide and evaluate options to jobset topmenu.

Created by Rob Vermaas on April 13, 2012

Q4VDOA762MDHLJKNJMPLHFYRRACCT3DQXF66ZTVMETZCR52B72OQC

Dependencies

In channels

main

Change contents

Deletion in src/lib/Hydra/Controller/Jobset.pm at line 28 [7.104]
B:BD[5.271] → [6.2:3]
∅:D[6.3] → [8.58:118]
B:BD[5.276] → [8.58:118]
```
    #getBuildStats($c, scalar $c->stash->{jobset}->builds);
```

Insertion in src/lib/Hydra/Controller/Jobset.pm at line 51 [7.104]

[9.838]

[6.4]


    $c->stash->{evals} = [ $c->stash->{jobset}->jobsetevals->search(
        { hasnewbuilds => 1 }, 
        { order_by => "id DESC"
        , '+select' => # !!! Slow - should precompute this.
	    [ "(select count(*) from JobsetEvalMembers where eval = me.id)"
	    , "(select count(*) from JobsetEvalMembers where eval = me.id and exists(select 1 from Builds b where b.id = build and b.finished = 0))" 
	    , "(select count(*) from JobsetEvalMembers where eval = me.id and exists(select 1 from Builds b where b.id = build and b.finished = 1))"
	    , "(select count(*) from JobsetEvalMembers where eval = me.id and exists(select 1 from Builds b where b.id = build and b.finished = 1 and b.buildStatus = 0))" 
	    ]
        , '+as' => [ "nrBuilds", "nrScheduled", "nrFinished", "nrSucceeded" ]
        , rows => 5
        }
    ) ];

Deletion in src/lib/Hydra/Controller/Jobset.pm at line 95 [7.104]

B:BD[6.11] → [10.314:344]

B:BD[11.1387] → [10.345:376]

B:BD[10.376] → [12.4074:4133]

B:BD[12.4133] → [2.269:361]

    # Last builds for jobset.
    $c->stash->{lastBuilds} = 
	[ $c->stash->{jobset}->builds->search({ finished => 1 }, 
            { order_by => "timestamp DESC", rows => 5, columns => [@buildListColumns] }) ];

Deletion in src/root/common.tt at line 402 [14.2803]
B:BD[13.3461] → [13.3461:3466]
∅:D[13.3466] → [15.4504:4508]
B:BD[15.4504] → [15.4504:4508]
B:BD[15.4508] → [13.3467:3470]
∅:D[13.3470] → [15.4554:4630]
B:BD[15.4554] → [15.4554:4630]
```
<!--
<p>
[]
[% IF page > 1 %]
  [<a href="[% "$baseUri?page="; (page - 1) %]">Prev</a>]
```

Replacement in src/root/common.tt at line 403 [14.2803]

B:BD[15.4640] → [15.4640:4832]

B:BD[15.4832] → [13.3471:3475]

∅:D[13.3475] → [15.4832:4842]

B:BD[15.4832] → [15.4832:4842]

[% IF page * resultsPerPage < total %]
  [<a href="[% "$baseUri?page="; (page + 1) %]">Next</a>]
[% END %]
[<a href="[% "$baseUri?page="; (total - 1) div resultsPerPage + 1 %]">Last</a>]
</p>
-->
[% END %]

[15.4640]

[16.2630]


[% BLOCK renderEvals %]
<table class="tablesorter table table-condensed table-striped">
  <thead>
    <tr>
      <th>#</th>
      <th>Date</th>
      <th colspan='2'>Success</th>
    </tr>
  </thead>
  <tbody>
    [% last = nrShown - 1; FOREACH n IN [0..last]; eval = evals.$n; m = n + 1; next = evals.$m; %]
     <tr>
       <td><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id]) %]">[% eval.id %]</a>&nbsp;</td>
       <td>[% INCLUDE renderDateTime timestamp = eval.timestamp %]&nbsp;</td>
       <td align='right'>
         <span class="label label-success">[% eval.get_column('nrSucceeded') %]</span>
         <span class="label label-important">[% eval.get_column('nrBuilds') - eval.get_column('nrSucceeded') - eval.get_column('nrScheduled') %]</span>
	 [% IF eval.get_column('nrScheduled') > 0 %]
	 <span class="label">[% eval.get_column('nrScheduled') %]</span>
	 [% END %]
       </td>
       <td align='right'>
	 [% diff = eval.get_column('nrSucceeded') - next.get_column('nrSucceeded');
	    IF diff > 0 %]
	    <span class='label label-success'><strong>+[% diff %]</strong></span>
	 [% ELSIF diff < 0 && eval.get_column('nrScheduled') == 0 %]
	    <span class='label label-important'><strong>[% diff %]</strong></span>
	 [% END %]
       </td>
     </tr>
    [% END %]
  </tbody>
</table>

Insertion in src/root/common.tt at line 441 [14.2803]
[16.2632]
```
[% END %]
```

Replacement in src/root/jobset-eval.tt at line 4 [15.4844]

B:BD[15.4906] → [17.430:517]

<h1>Jobset <tt>[% project.name %]:[% jobset.name %]</tt> evaluation [% eval.id %]</h1>

[15.4906]

[15.4993]

<h2>Jobset <tt>[% project.name %]:[% jobset.name %]</tt> evaluation [% eval.id %]</h2>

Replacement in src/root/jobset-evals.tt at line 4 [15.6334]
B:BD[15.6444] → [15.6444:6496]
```
<h1>Evaluations of Jobset <tt>[% INCLUDE renderLink
```
[15.6444]
[15.6496]
```
<h2>Evaluations of Jobset <tt>[% INCLUDE renderLink
```

Replacement in src/root/jobset-evals.tt at line 6 [15.6334]

B:BD[15.6574] → [15.6574:6628]

  title = project.name %]:[% jobset.name %]</tt></h1>

[15.6574]

[3.1993]

  title = project.name %]:[% jobset.name %]</tt></h2>

Replacement in src/root/jobset-evals.tt at line 15 [15.6334]

B:BD[15.6793] → [13.4208:4272]

∅:D[13.4272] → [15.6821:6943]

B:BD[15.6821] → [15.6821:6943]

B:BD[15.6943] → [3.2135:2234]

∅:D[3.2234] → [15.7045:7283]

B:BD[15.7045] → [15.7045:7283]

B:BD[15.7283] → [13.4273:4512]

∅:D[13.4512] → [15.7365:7411]

B:BD[15.7365] → [15.7365:7411]

B:BD[15.7411] → [13.4513:4579]

∅:D[13.4579] → [15.7466:7614]

B:BD[15.7466] → [15.7466:7614]

B:BD[15.7614] → [13.4580:4655]

∅:D[13.4655] → [15.7675:7737]

B:BD[15.7675] → [15.7675:7737]

B:BD[15.7737] → [13.4656:4732]

∅:D[13.4732] → [15.7795:7865]

B:BD[15.7795] → [15.7795:7865]

<table class="tablesorter table table-condensed table-striped">
  <thead>
    <tr>
      <th>#</th>
      <th>Date</th>
      <th colspan='2'>Success</th>
    </tr>
  </thead>
  <tbody>
    [% last = nrShown - 1; FOREACH n IN [0..last]; eval = evals.$n; m = n + 1; next = evals.$m; %]
     <tr>
       <td><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id]) %]">[% eval.id %]</a>&nbsp;</td>
       <td>[% INCLUDE renderDateTime timestamp = eval.timestamp %]&nbsp;</td>
       <td align='right'>
         <span class="label label-success">[% eval.get_column('nrSucceeded') %]</span>
         <span class="label label-important">[% eval.get_column('nrBuilds') - eval.get_column('nrSucceeded') - eval.get_column('nrScheduled') %]</span>
	 [% IF eval.get_column('nrScheduled') > 0 %]
	 <span class="label">[% eval.get_column('nrScheduled') %]</span>
	 [% END %]
       </td>
       <td align='right'>
	 [% diff = eval.get_column('nrSucceeded') - next.get_column('nrSucceeded');
	    IF diff > 0 %]
	    <span class='label label-success'><strong>+[% diff %]</strong></span>
	 [% ELSIF diff < 0 && eval.get_column('nrScheduled') == 0 %]
	    <span class='label label-important'><strong>[% diff %]</strong></span>
	 [% END %]
       </td>
     </tr>
    [% END %]
  </tbody>
</table>

[15.6793]

[15.7892]

[% INCLUDE renderEvals %]

Replacement in src/root/jobset.tt at line 94 [5.8409]

∅:D[18.904] → [11.20547:20606]

B:BD[11.20547] → [11.20547:20606]

B:BD[11.20606] → [19.691:780]

∅:D[19.780] → [11.20660:20675]

B:BD[11.20660] → [11.20660:20675]

	    [% IF lastBuilds %]
	    	<h2>Most recent builds</h2>
	    	[% INCLUDE renderBuildList builds=lastBuilds hideProjectName=1 hideJobsetName=1 %]
	    [% END %]

[18.904]

[11.20675]

	    	<h2>Most recent evaluations</h2>
	    	[% INCLUDE renderEvals nrShown=5 %]
   
                <a href="c.uri_for(c.controller('Jobset').action_for('evals'), [project.name, jobset.name])" class="btn">All evaluations</a>
                <br />
                <br />

Deletion in src/root/project.tt at line 31 [22.1667]

B:BD[20.249] → [21.775:854]

                  [% IF c.check_user_roles('admin') %]<th>Options</th>[% END%]

Deletion in src/root/project.tt at line 78 [22.1667]

B:BD[20.1343] → [21.855:910]

B:BD[21.910] → [13.9448:9886]

∅:D[13.9886] → [23.3674:3712]

B:BD[23.3674] → [23.3674:3712]

B:BD[23.3712] → [13.9887:10014]

∅:D[13.10014] → [23.3837:3873]

B:BD[23.3837] → [23.3837:3873]

B:BD[23.3896] → [23.3896:3922]

∅:D[23.3922] → [21.1180:1207]

B:BD[21.1180] → [21.1180:1207]

                  [% IF c.check_user_roles('admin') %]
                    <td>[% INCLUDE maybeButton uri = c.uri_for(c.controller('Admin').action_for('force_eval'), project.name, j.name) content = "Evaluate" confirmmsg = ("Are you sure you want to force evaluation of jobset " _ project.name _ ":" _ j.name _ "?") %]
                          [% IF j.hidden %]
                              [% INCLUDE maybeButton uri = c.uri_for('/jobset' project.name j.name 'unhide') content = "Unhide" %]
                          [% ELSE %] 
                              [% INCLUDE maybeButton uri = c.uri_for('/jobset' project.name j.name 'hide') content = "Hide" %]
                          [% END %]
                    </td>
                  [% END%]

Deletion in src/root/topbar.tt at line 47 [24.6671]

B:BD[13.11384] → [13.11384:11512]

      [% INCLUDE menuItem uri = c.uri_for(c.controller('Project').action_for('releases'), [project.name]) title = "Releases" %]

Insertion in src/root/topbar.tt at line 50 [24.6671]

[13.11892]

[4.0]

      <li class="divider"></li>
      [% INCLUDE menuItem uri = c.uri_for(c.controller('Project').action_for('releases'), [project.name]) title = "Releases" %]

Insertion in src/root/topbar.tt at line 79 [24.6671]
[13.13133]
[4.117]
```
      <li class="divider"></li>
```

Insertion in src/root/topbar.tt at line 83 [24.6671]

[13.13212]

          [% INCLUDE menuItem uri = c.uri_for('/jobset' project.name jobset.name 'clone') title="Clone jobset" %]

Replacement in src/root/topbar.tt at line 85 [24.6671]

B:BD[13.13324] → [13.13324:13438]

          [% INCLUDE menuItem uri = c.uri_for('/jobset' project.name jobset.name 'clone') title="Clone jobset" %]

[13.13324]

[13.13438]

          [% INCLUDE maybeLink uri = c.uri_for(c.controller('Admin').action_for('force_eval'), project.name, j.name) content = "Evaluate" confirmmsg = ("Are you sure you want to force evaluation of jobset " _ project.name _ ":" _ j.name _ "?") %]
          [% IF j.hidden %]
              [% INCLUDE menuItem uri = c.uri_for('/jobset' project.name j.name 'unhide') title = "Unhide" %]
          [% ELSE %] 
              [% INCLUDE menuItem uri = c.uri_for('/jobset' project.name j.name 'hide') title = "Hide" %]
          [% END %]

Insertion in src/root/topbar.tt at line 92 [24.6671]
[13.13454]
[13.13454]