grahamc/hydra2 - Change TTBLPQAJKPRC6W23QIFTPI2MM4VYR3D3CR6F7U53WU5GJDAYJW4AC

Keep track of wait time per system type

I.e., how much time the currently runnable steps per system type have been waiting. This is useful for deciding whether to provision more machines.

Created by Eelco Dolstra on August 17, 2015

TTBLPQAJKPRC6W23QIFTPI2MM4VYR3D3CR6F7U53WU5GJDAYJW4AC

Dependencies

In channels

main

Change contents

Insertion in src/hydra-queue-runner/dispatcher.cc at line 19 [3.14628]
[3.14988]
[3.14988]
```
        step_->runnableSince = std::chrono::system_clock::now();
```

Replacement in src/hydra-queue-runner/dispatcher.cc at line 147 [3.14628]

B:BD[4.292] → [5.317:388]

        std::unordered_map<std::string, unsigned int> runnablePerType;

[4.292]

        struct RunnablePerType
        {
            unsigned int count{0};
            std::chrono::seconds waitTime{0};
        };
        std::unordered_map<std::string, RunnablePerType> runnablePerType;

Replacement in src/hydra-queue-runner/dispatcher.cc at line 167 [3.14628]

B:BD[5.390] → [2.0:53]

                runnablePerType[step->systemType]++;

[5.390]

[3.18020]

                auto & r = runnablePerType[step->systemType];
                r.count++;

Insertion in src/hydra-queue-runner/dispatcher.cc at line 174 [3.14628]

[6.3929]

                    r.waitTime += std::chrono::duration_cast<std::chrono::seconds>(now - step_->runnableSince);

Replacement in src/hydra-queue-runner/dispatcher.cc at line 230 [3.14628]

B:BD[4.1899] → [2.54:174]

                    assert(runnablePerType[step->systemType]);
                    runnablePerType[step->systemType]--;

[4.1899]

[6.4106]

                    auto & r = runnablePerType[step->systemType];
                    assert(r.count);
                    r.count--;

Replacement in src/hydra-queue-runner/dispatcher.cc at line 255 [3.14628]

B:BD[5.939] → [5.939:1047]

            for (auto & i : runnablePerType)
                (*machineTypes_)[i.first].runnable = i.second;

[5.939]

[6.4615]

            for (auto & i : runnablePerType) {
                auto & j = (*machineTypes_)[i.first];
                j.runnable = i.second.count;
                j.waitTime = i.second.waitTime;
            }

Insertion in src/hydra-queue-runner/dispatcher.cc at line 262 [3.14628]
[3.19309]
[6.4626]
```
        lastDispatcherCheck = std::chrono::system_clock::to_time_t(now);
```

Replacement in src/hydra-queue-runner/dispatcher.cc at line 326 [3.14628]

B:BD[5.1786] → [5.1786:1832]

            machineType.lastActive = time(0);

[5.1786]

[7.1721]

            machineType.lastActive = std::chrono::system_clock::now();

Insertion in src/hydra-queue-runner/hydra-queue-runner.cc at line 487 [8.4840]

[5.2319]

                if (i.second.runnable > 0)
                    nested2.attr("waitTime", i.second.waitTime.count() +
                        i.second.runnable * (time(0) - lastDispatcherCheck));

Replacement in src/hydra-queue-runner/hydra-queue-runner.cc at line 491 [8.4840]

B:BD[5.2362] → [5.2362:2431]

                    nested2.attr("lastActive", i.second.lastActive);

[5.2362]

[5.2431]

                    nested2.attr("lastActive", std::chrono::system_clock::to_time_t(i.second.lastActive));

Insertion in src/hydra-queue-runner/state.hh at line 178 [9.1128]

[4.2893]

[9.3082]


        /* The time at which this step became runnable. */
        system_time runnableSince;

Replacement in src/hydra-queue-runner/state.hh at line 330 [9.1128]

B:BD[5.2640] → [5.2640:2670]

        time_t lastActive{0};

[5.2640]

[5.2670]

        system_time lastActive;
        std::chrono::seconds waitTime; // time runnable steps have been waiting

Insertion in src/hydra-queue-runner/state.hh at line 345 [9.1128]
[5.3027]
[9.6777]
```
    std::atomic<time_t> lastDispatcherCheck{0};
```