grahamc/hydra - Change XG3QG5ICOI5HGJY4T3M7PDIXTJ5HCV6FTRI5XBY5ZD5SPAZ2CCFQC

Make latest/latest-for more efficient

Getting all matching rows from the database is expensive.

Created by Eelco Dolstra on May 23, 2013

XG3QG5ICOI5HGJY4T3M7PDIXTJ5HCV6FTRI5XBY5ZD5SPAZ2CCFQC

Dependencies

In channels

upstream

main

Change contents

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 99 [5.1]

B:BD[3.129] → [4.352:403]

B:BD[4.403] → [2.39:110]

    my ($latest) = $c->stash->{allBuilds}->search(
        {finished => 1, buildstatus => 0}, {order_by => ["id DESC"]});

[3.129]

[3.282]

    my $latest = $c->stash->{allBuilds}->find(
        { finished => 1, buildstatus => 0 }, { order_by => ["id DESC"], rows => 1 });

Replacement in src/lib/Hydra/Base/Controller/ListBuilds.pm at line 114 [5.1]

∅:D[6.847] → [4.493:544]

B:BD[3.746] → [4.493:544]

B:BD[4.544] → [2.111:201]

    my ($latest) = $c->stash->{allBuilds}->search(
        {finished => 1, buildstatus => 0, system => $system}, {order_by => ["id DESC"]});

[6.847]

[3.918]

    my $latest = $c->stash->{allBuilds}->find(
        { finished => 1, buildstatus => 0, system => $system }, { order_by => ["id DESC"], rows => 1 });