grahamc/hydra2 - Change YRXR3WDPUCCRY26ABDYTNNYTOQYYAPLW7MB4TSM3EYPXGQT7MQPQC

hydra-eval-jobs: Warn and resets maxHeapSize on bad values

This is because setting only the initial heap size to more than the default value (or the configured value) will cause all initial evals until maxHeapSize expands to the given value to abort.

The 1.1 multiplier comes from the the configured defaults on NixOS' hydra, and from the previous multiplier used before 7876cf677ce086c22faf8909bcec7ac8811f1d39.

Created by Samuel Dionne-Riel on December 21, 2018

YRXR3WDPUCCRY26ABDYTNNYTOQYYAPLW7MB4TSM3EYPXGQT7MQPQC

Dependencies

In channels

main

Change contents

Insertion in src/hydra-eval-jobs/hydra-eval-jobs.cc at line 236 [4.303]

[2.18]

[3.27]


        /* Read the current heap size, which is the initial heap size. */
        GC_prof_stats_s gc;
        GC_get_prof_stats(&gc, sizeof(gc));
        auto initialHeapSizeInt = gc.heapsize_full;
        /* Then make sure the maximum heap size will be bigger than the initial heap size. */
        if (initialHeapSizeInt > maxHeapSize) {
            printInfo("warning: evaluator_initial_heap_size (%d) bigger than evaluator_max_heap_size (%d).", initialHeapSizeInt, maxHeapSize);
            maxHeapSize = initialHeapSizeInt * 1.1;
            printInfo("         evaluator_max_heap_size now set to %d.", maxHeapSize);
        }