grahamc/hydra2 - Change ZI6MCLEG6WHXHX3XHSOAHRZYOFEUKJMVFEZWORMEXOFQTTT46R7AC

Fix division-by-zero crash

Not clear why step_->jobsets was empty…

Created by Eelco Dolstra on October 30, 2015

ZI6MCLEG6WHXHX3XHSOAHRZYOFEUKJMVFEZWORMEXOFQTTT46R7AC

Dependencies

[2] IK2UBDAU6QKUXHJG3SXJKYGIIXRDKI6UVRTFC6ZVDXDCGNCMEWVAC
[3] MHVIT4JYWUYD4UCGB2AHLXWLX6B5SYE22BREERNGANT7RGGDUFOAC

In channels

main

Change contents

Replacement in src/hydra-queue-runner/builder.cc at line 139 [3.133]

B:BD[2.161] → [2.161:384]

        // FIXME: loss of precision.
        time_t charge = (result.stopTime - result.startTime) / step_->jobsets.size();
        for (auto & jobset : step_->jobsets)
            jobset->addStep(result.startTime, charge);

[2.161]

[2.384]

        if (!step_->jobsets.empty()) {
            // FIXME: loss of precision.
            time_t charge = (result.stopTime - result.startTime) / step_->jobsets.size();
            for (auto & jobset : step_->jobsets)
                jobset->addStep(result.startTime, charge);
        }