a few more clippy lints addressed

[?]
Nov 30, 2020, 3:55 PM
H23LO7U7MNB5GTLOUIFYAJ6DP57DM3VFBR4IBOAVPMHS356AYFPQC

Dependencies

  • [2] NLGQAH4H Credit and reset relative to current directory instead of the root
  • [3] ISQJRA3O Fixing the parsing of zombie resurrection in the change text format
  • [4] 3YDPHBAN address non-controversial clippy lints
  • [5] SXEYMYF7 Fixing the bad changes in history (unfortunately, by rebooting).
  • [6] I52XSRUH Massive cleanup, and simplification
  • [7] KVBLRDOU Concatenating edits with order conflict resolutions (if relevant), and parsing the text format of the result
  • [8] IMCZFTIJ Update selection instructions to also mention pushing
  • [9] OAXTXEAF commands/pushpull: display dependencies of change
  • [10] GLMOA3PF More edges in "credit"

Change contents

  • replacement in pijul/src/commands/pushpull.rs at line 476
    [4.121713][4.121713:121751]()
    writeln!(v, "").unwrap();
    [4.121713]
    [4.121751]
    writeln!(v).unwrap();
  • replacement in pijul/src/commands/credit.rs at line 109
    [4.181672][4.181672:181711]()
    write!(self.w, "\n")?;
    [4.181672]
    [4.181711]
    writeln!(self.w)?;
  • replacement in pijul/src/commands/credit.rs at line 111
    [4.181725][2.428:463]()
    write!(self.w, "\n")?;
    [4.181725]
    [4.181725]
    writeln!(self.w)?;
  • replacement in libpijul/src/working_copy/memory.rs at line 134
    [4.203215][4.203215:203279](),[4.203279][4.203279:203319]()
    let mut it = file.split('/').filter(|c| !c.is_empty());
    while let Some(c) = it.next() {
    [4.203215]
    [4.203319]
    let it = file.split('/').filter(|c| !c.is_empty());
    for c in it {
  • edit in libpijul/src/working_copy/memory.rs at line 232
    [4.206667][4.206667:206848]()
    }
    None => {
    return Err((crate::Error::FileNotFound {
    path: file.to_string(),
    })
    .into())
  • edit in libpijul/src/working_copy/memory.rs at line 233
    [4.206862]
    [4.206862]
    None => Err((crate::Error::FileNotFound {
    path: file.to_string(),
    })
    .into()),
  • replacement in libpijul/src/tests/conflict.rs at line 1610
    [4.409207][4.409207:409267]()
    for (n, p) in (&p_alice[1..]).into_iter().enumerate() {
    [4.409207]
    [4.409267]
    for (n, p) in (&p_alice[1..]).iter().enumerate() {
  • replacement in libpijul/src/pristine/sanakirja.rs at line 554
    [4.550246][4.550246:550312]()
    self.open_channels.borrow().get(&name).map(|x| x.clone())
    [4.550246]
    [4.550312]
    self.open_channels.borrow().get(&name).cloned()
  • replacement in libpijul/src/pristine/sanakirja.rs at line 581
    [4.551240][4.551240:551305]()
    self.open_remotes.borrow().get(&name).map(|x| x.clone())
    [4.551240]
    [4.551305]
    self.open_remotes.borrow().get(&name).cloned()
  • replacement in libpijul/src/pristine/sanakirja.rs at line 726
    [4.556166][4.556166:556231]()
    self.open_remotes.borrow().get(&name).map(|x| x.clone())
    [4.556166]
    [4.556231]
    self.open_remotes.borrow().get(&name).cloned()
  • replacement in libpijul/src/pristine/sanakirja.rs at line 736
    [4.556533][4.556533:556591]()
    .filter(|(k, _)| *k >= n)
    .next()
    [4.556533]
    [4.556591]
    .find(|(k, _)| *k >= n)
  • replacement in libpijul/src/pristine/channel_dump.rs at line 397
    [4.665411][4.665411:665456]()
    e.flag = e.flag ^ EdgeFlags::PARENT;
    [4.665411]
    [4.665456]
    e.flag ^= EdgeFlags::PARENT;
  • replacement in libpijul/src/change.rs at line 1753
    [4.891869][4.891869:891903]()
    writeln!(w, "")?;
    [4.891869]
    [4.891903]
    writeln!(w)?;
  • replacement in libpijul/src/change.rs at line 1764
    [4.892327][4.892327:892361]()
    writeln!(w, "")?;
    [4.892327]
    [4.892361]
    writeln!(w)?;
  • replacement in libpijul/src/change.rs at line 1793
    [4.893723][4.893723:893757]()
    writeln!(w, "")?;
    [4.893723]
    [4.893757]
    writeln!(w)?;
  • replacement in libpijul/src/change.rs at line 1804
    [4.894129][4.894129:894163]()
    writeln!(w, "")?;
    [4.894129]
    [4.894163]
    writeln!(w)?;
  • replacement in libpijul/src/change.rs at line 1815
    [4.894429][3.94:128]()
    writeln!(w, "")?;
    [4.894429]
    [4.894486]
    writeln!(w)?;