Comments and debugging

pmeunier

Nov 27, 2021, 2:05 PM

SDCIBGQ5OJGCA24ZSZFTXIPGNNUAQPLYBEM56OKKIMPZ45U6CYFQC

Dependencies

• [2] QAXLX3UA Backwards-compatibility: moving old paths to the new "roots" feature
• [3] YN63NUZO Sanakirja 1.0
• [4] CCLLB7OI Upgrading to Sanakirja 0.15 + version bump
• [5] SXEYMYF7 Fixing the bad changes in history (unfortunately, by rebooting).
• [6] I24UEJQL Various post-fire fixes
• [7] FXEDPLRI Resurrecting tests, and type cleanup (no need for Arc<RwLock<…>> anymore)
• [8] RMDMAYRX Adding a root inode (aka supporting submodules)
• [9] 6DOXSHWG Cleanup, and version bump
• [*] I52XSRUH Massive cleanup, and simplification

Change contents

• edit in libpijul/src/record.rs at line 377
  [3.1924]

  [3.1924]
  + // This is the "new" format, with multiple

  + // roots, and `grandchild` is one of the

  + // roots.
• edit in libpijul/src/record.rs at line 395
  [3.2593]

  [3.2593]
  + // Single-root repository, we need to follow

  + // the root's children.
• edit in libpijul/src/record.rs at line 400
  [3.2682]

  [3.2682]
  + debug!("has_nonempty_root: {:?}", has_nonempty_root);

  + debug!("root_vertices: {:?}", root_vertices);
• edit in libpijul/src/record.rs at line 484
  [2.869]

  [3.3710]
  + item.v_papa = vertex.to_option();
• edit in libpijul/src/record.rs at line 645
  [3.54217]

  [3.54217]
  + debug!("fileid = {:?}", fileid);
• edit in libpijul/src/pristine/sanakirja.rs at line 2142
  [3.68555]→[3.572976:573453](∅→∅),[3.100247]→[3.572976:573453](∅→∅),[3.572976]→[3.572976:573453](∅→∅)
  − // Since we are replacing the value, we don't want to

  − // decrement its reference counter (which del would do), hence

  − // the transmute.

  − //

  − // This would normally be wrong. The only reason it works is

  − // because we know that dbs_channels has never been forked

  − // from another database, hence all the reference counts to

  − // its elements are 1 (and therefore represented as "not

  − // referenced" in Sanakirja).
• edit in libpijul/src/output/output.rs at line 66
  [3.73881]

  [3.673269]
  + debug!("output_repository_no_pending: {:?}", prefix);
• edit in libpijul/src/output/mod.rs at line 102
  [3.21580]

  [11.56008]
  + debug!("prefix_basename = {:?}", prefix_basename);
• replacement in libpijul/src/output/mod.rs at line 145
  [3.86796]→[3.22397:22436](∅→∅)
  − debug!("e = {:?}", e);
  [3.86796]

  [3.22436]
  + debug!("e' = {:?}", e);
• edit in libpijul/src/output/mod.rs at line 175
  [3.23205]

  [3.23205]
  + // First, get the basename of the path we're outputting.
• edit in libpijul/src/output/mod.rs at line 192
  [3.23674]

  [3.23674]
  + debug!("next = {:?} basename = {:?}", next, basename);