Review comments

hardy7cc

Aug 7, 2025, 8:19 PM

V7RA5U2OKG4TGJQ7WYTJPIHJS57OXUGSTHJRIIRZ2SHWE5CYFOXAC

Dependencies

• [2] SXEYMYF7 Fixing the bad changes in history (unfortunately, by rebooting).
• [3] YW6NICQV Migrate codebase to refactored `pijul_config` crate
• [4] HGJETVAN Create `pijul_config::global_config_directory()`
• [5] FIMDS32Z Use subcommand-specific repository config paths

Change contents

• edit in pijul-config/src/lib.rs at line 230
  [4.1625]

  [4.1625]
  + // REVIEW: This changed from a global config file to a

  + // config directory

  + // While I'm in favour of this change and generally like it.

  + // i.e. it also fixes the question where the "identities" directory

  + // is based on the "~/.pijulconfig" file

  + // However in theory this is breaking.
• edit in pijul/src/main.rs at line 221
  [2.88414]

  [5.915]
  + // REVIEW: Is there not a better way to get the repository root path

  + // i.e. how about following steps:

  + // 1. run something like Repository::find_repository_root project independent

  + // I guess for this to work properly the "repository" option should be moved

  + // from the common_opts to the Opts struct with "global = true" set

  + // 2. load configuration
• edit in pijul/src/commands/pushpull.rs at line 278
  [3.11530]

  [2.112646]
  + //REVIEW: I guess we could inform the user here if there went

  + // something wrong during the command "pijul remote default"
• edit in pijul/src/commands/diff.rs at line 360
  [3.15305]

  [3.15305]
  + //REVIEW: I don't get what the pager has to do with the coloring

  + // Probably the pager stuff should also be refactored