irevoire/pijul - Change 7KNPYIDUXCBZ65NA74NL2DIFS6STJWN4XXHXLTIV5QXZSVLARJMAC

Splitting the WorkingCopy trait into a read-only record and a read/write output

Created by pmeunier on September 9, 2021

7KNPYIDUXCBZ65NA74NL2DIFS6STJWN4XXHXLTIV5QXZSVLARJMAC

Dependencies

In channels

main

Change contents

Replacement in ""libpijul/src/working_copy/mod.rs"" at line 14 [4.198172]
B:BD[4.198425] → [4.198425:198449]
```
pub trait WorkingCopy {
```
[5.1193]
[6.24589]
```
pub trait WorkingCopyRead {
```
Deletion in ""libpijul/src/working_copy/mod.rs"" at line 16 [4.198172]
B:BD[6.24631] → [6.24631:24700]
```
    fn create_dir_all(&self, path: &str) -> Result<(), Self::Error>;
```

Deletion in ""libpijul/src/working_copy/mod.rs"" at line 19 [4.198172]

B:BD[5.1728] → [7.0:77]

∅:D[7.77] → [6.24767:25038]

B:BD[6.24767] → [6.24767:25038]

    fn remove_path(&self, name: &str, rec: bool) -> Result<(), Self::Error>;
    fn rename(&self, former: &str, new: &str) -> Result<(), Self::Error>;
    fn set_permissions(&self, name: &str, permissions: u16) -> Result<(), Self::Error>;
    type Writer: std::io::Write;
    fn write_file(&self, file: &str) -> Result<Self::Writer, Self::Error>;

Insertion in ""libpijul/src/working_copy/mod.rs"" at line 39 [4.198172]

[9.946]


pub trait WorkingCopy: WorkingCopyRead {
    fn create_dir_all(&self, path: &str) -> Result<(), Self::Error>;
    fn remove_path(&self, name: &str, rec: bool) -> Result<(), Self::Error>;
    fn rename(&self, former: &str, new: &str) -> Result<(), Self::Error>;
    fn set_permissions(&self, name: &str, permissions: u16) -> Result<(), Self::Error>;
    type Writer: std::io::Write;
    fn write_file(&self, file: &str) -> Result<Self::Writer, Self::Error>;
}

Replacement in ""libpijul/src/working_copy/memory.rs"" at line 216 [4.199222]
B:BD[4.205404] → [4.205404:205434]
```
impl WorkingCopy for Memory {
```
[4.205404]
[5.2216]
```
impl WorkingCopyRead for Memory {
```

Deletion in ""libpijul/src/working_copy/memory.rs"" at line 218 [4.199222]

B:BD[5.2240] → [6.25842:25912]

B:BD[6.25912] → [10.107:142]

B:BD[10.142] → [11.238:273]

∅:D[11.273] → [10.186:268]

B:BD[10.186] → [10.186:268]

∅:D[10.268] → [4.205553:205680]

∅:D[6.25992] → [4.205553:205680]

B:BD[4.205553] → [4.205553:205680]

B:BD[4.205680] → [12.177:236]

∅:D[12.236] → [4.205739:205780]

B:BD[4.205739] → [4.205739:205780]

B:BD[4.205780] → [6.25993:26047]

∅:D[6.26047] → [4.205830:205959]

B:BD[4.205830] → [4.205830:205959]

    fn create_dir_all(&self, file: &str) -> Result<(), Self::Error> {
        let not_already_exists = {
            let m = self.0.lock();
            m.get_file(file).is_none()
        };
        if not_already_exists {
            let last = SystemTime::now();
            self.add_inode(
                file,
                Inode::Directory {
                    meta: InodeMetadata::new(0o100, true),
                    children: FileTree {
                        children: HashMap::default(),
                    },
                    last_modified: last,
                },
            );
        }
        Ok(())
    }

Insertion in ""libpijul/src/working_copy/memory.rs"" at line 245 [4.199222]
[4.207006]
[4.207006]
```
}
```

Insertion in ""libpijul/src/working_copy/memory.rs"" at line 247 [4.199222]

[4.207007]

[7.78]

impl WorkingCopy for Memory {
    fn create_dir_all(&self, file: &str) -> Result<(), Self::Error> {
        let not_already_exists = {
            let m = self.0.lock();
            m.get_file(file).is_none()
        };
        if not_already_exists {
            let last = SystemTime::now();
            self.add_inode(
                file,
                Inode::Directory {
                    meta: InodeMetadata::new(0o100, true),
                    children: FileTree {
                        children: HashMap::default(),
                    },
                    last_modified: last,
                },
            );
        }
        Ok(())
    }

Replacement in ""libpijul/src/working_copy/filesystem.rs"" at line 311 [4.208900]
B:BD[4.213919] → [4.213919:213953]
```
impl WorkingCopy for FileSystem {
```
[4.213919]
[5.3918]
```
impl WorkingCopyRead for FileSystem {
```
Deletion in ""libpijul/src/working_copy/filesystem.rs"" at line 313 [4.208900]
B:BD[5.3951] → [6.28617:28732]
∅:D[5.4025] → [13.159:214]
∅:D[6.28732] → [13.159:214]
B:BD[4.214029] → [13.159:214]
∅:D[13.214] → [4.214089:214095]
B:BD[4.214089] → [4.214089:214095]
```
    fn create_dir_all(&self, file: &str) -> Result<(), Self::Error> {
        debug!("create_dir_all {:?}", file);
        Ok(std::fs::create_dir_all(&self.path(file))?)
    }
```
Insertion in ""libpijul/src/working_copy/filesystem.rs"" at line 344 [4.208900]
[3.429]
[3.429]
```
}
```

Insertion in ""libpijul/src/working_copy/filesystem.rs"" at line 346 [4.208900]

[3.430]

[7.158]

impl WorkingCopy for FileSystem {
    fn create_dir_all(&self, file: &str) -> Result<(), Self::Error> {
        debug!("create_dir_all {:?}", file);
        Ok(std::fs::create_dir_all(&self.path(file))?)
    }

Replacement in ""libpijul/src/record.rs"" at line 8 [4.488880]
B:BD[4.489161] → [4.489161:489199]
```
use crate::working_copy::WorkingCopy;
```
[4.489161]
[14.1477]
```
use crate::working_copy::WorkingCopyRead;
```

Replacement in ""libpijul/src/record.rs"" at line 276 [4.488880]

B:BD[6.44558] → [11.96492:96548]

        W: WorkingCopy + Clone + Send + Sync + 'static,

[6.44558]

[6.44606]

        W: WorkingCopyRead + Clone + Send + Sync + 'static,

Replacement in ""libpijul/src/record.rs"" at line 295 [4.488880]
∅:D[15.28265] → [16.32756:32800]
∅:D[6.44969] → [16.32756:32800]
B:BD[16.32756] → [16.32756:32800]
```
        <W as WorkingCopy>::Error: 'static,
```
[6.44969]
[16.32800]
```
        <W as WorkingCopyRead>::Error: 'static,
```
Replacement in ""libpijul/src/record.rs"" at line 472 [4.488880]
B:BD[6.50608] → [6.50608:50632]
```
        W: WorkingCopy,
```
[6.50608]
[6.50632]
```
        W: WorkingCopyRead,
```
Replacement in ""libpijul/src/record.rs"" at line 484 [4.488880]
B:BD[6.50908] → [6.50908:50952]
```
        <W as WorkingCopy>::Error: 'static,
```
[6.50908]
[6.50952]
```
        <W as WorkingCopyRead>::Error: 'static,
```
Replacement in ""libpijul/src/record.rs"" at line 544 [4.488880]
B:BD[6.53464] → [6.53464:53488]
```
        W: WorkingCopy,
```
[6.53464]
[6.53488]
```
        W: WorkingCopyRead,
```

Replacement in ""libpijul/src/record.rs"" at line 559 [4.488880]

B:BD[6.53882] → [6.53882:53947]

        <W as crate::working_copy::WorkingCopy>::Error: 'static,

[6.53882]

[6.53947]

        <W as crate::working_copy::WorkingCopyRead>::Error: 'static,

Replacement in ""libpijul/src/record.rs"" at line 623 [4.488880]

B:BD[6.56117] → [6.56117:56180]

fn modified_since_last_commit<T: ChannelTxnT, W: WorkingCopy>(

[6.56117]

[6.56180]

fn modified_since_last_commit<T: ChannelTxnT, W: WorkingCopyRead>(

Replacement in ""libpijul/src/record.rs"" at line 647 [4.488880]
∅:D[17.1] → [4.495618:495651]
∅:D[6.56806] → [4.495618:495651]
B:BD[4.495618] → [4.495618:495651]
```
    fn add_file<W: WorkingCopy>(
```
[6.56806]
[4.495651]
```
    fn add_file<W: WorkingCopyRead>(
```
Replacement in ""libpijul/src/record.rs"" at line 743 [4.488880]
B:BD[6.57987] → [11.98010:98042]
```
        W: WorkingCopy + Clone,
```
[6.57987]
[16.33078]
```
        W: WorkingCopyRead + Clone,
```

Replacement in ""libpijul/src/record.rs"" at line 757 [4.488880]

B:BD[16.33188] → [16.33188:33253]

        <W as crate::working_copy::WorkingCopy>::Error: 'static,

[16.33188]

[16.33253]

        <W as crate::working_copy::WorkingCopyRead>::Error: 'static,

Replacement in ""libpijul/src/record.rs"" at line 901 [4.488880]

B:BD[4.503333] → [18.571:645]

    fn record_moved_file<T: ChannelTxnT, C: ChangeStore, W: WorkingCopy>(

[4.503333]

[4.507676]

    fn record_moved_file<T: ChannelTxnT, C: ChangeStore, W: WorkingCopyRead>(

Replacement in ""libpijul/src/record.rs"" at line 912 [4.488880]

B:BD[16.35958] → [16.35958:36023]

        <W as crate::working_copy::WorkingCopy>::Error: 'static,

[16.35958]

[16.36023]

        <W as crate::working_copy::WorkingCopyRead>::Error: 'static,

Replacement in ""libpijul/src/record.rs"" at line 995 [4.488880]

B:BD[4.510763] → [16.36087:36157]

fn collect_moved_edges<T: GraphTxnT, C: ChangeStore, W: WorkingCopy>(

[4.510763]

[4.510812]

fn collect_moved_edges<T: GraphTxnT, C: ChangeStore, W: WorkingCopyRead>(

Replacement in ""libpijul/src/record.rs"" at line 1005 [4.488880]

B:BD[16.36261] → [16.36261:36322]

    <W as crate::working_copy::WorkingCopy>::Error: 'static,

[16.36261]

[16.36322]

    <W as crate::working_copy::WorkingCopyRead>::Error: 'static,

Replacement in ""libpijul/src/record.rs"" at line 1212 [4.488880]
B:BD[16.37258] → [16.37258:37282]
```
        W: WorkingCopy,
```
[16.37258]
[19.2864]
```
        W: WorkingCopyRead,
```
Replacement in ""libpijul/src/record.rs"" at line 1224 [4.488880]
B:BD[19.2988] → [19.2988:3032]
```
        <W as WorkingCopy>::Error: 'static,
```
[19.2988]
[19.3032]
```
        <W as WorkingCopyRead>::Error: 'static,
```

Replacement in ""libpijul/src/record.rs"" at line 1301 [4.488880]

B:BD[4.521266] → [2.293:367]

    fn delete_inode_vertex<T: GraphTxnT, C: ChangeStore, W: WorkingCopy>(

[4.521266]

[4.521303]

    fn delete_inode_vertex<T: GraphTxnT, C: ChangeStore, W: WorkingCopyRead>(

Replacement in ""libpijul/src/record.rs"" at line 1311 [4.488880]

B:BD[2.470] → [2.470:514]

        <W as WorkingCopy>::Error: 'static,

[2.470]

[2.514]

        <W as WorkingCopyRead>::Error: 'static,

Splitting the WorkingCopy trait into a read-only record and a read/write output

Dependencies

In channels

Change contents

Replacement in ""libpijul/src/working_copy/mod.rs"" at line 14 [4.198172]

Deletion in ""libpijul/src/working_copy/mod.rs"" at line 16 [4.198172]

Deletion in ""libpijul/src/working_copy/mod.rs"" at line 19 [4.198172]

Insertion in ""libpijul/src/working_copy/mod.rs"" at line 39 [4.198172]

Replacement in ""libpijul/src/working_copy/memory.rs"" at line 216 [4.199222]

Deletion in ""libpijul/src/working_copy/memory.rs"" at line 218 [4.199222]

Insertion in ""libpijul/src/working_copy/memory.rs"" at line 245 [4.199222]

Insertion in ""libpijul/src/working_copy/memory.rs"" at line 247 [4.199222]

Replacement in ""libpijul/src/working_copy/filesystem.rs"" at line 311 [4.208900]

Deletion in ""libpijul/src/working_copy/filesystem.rs"" at line 313 [4.208900]

Insertion in ""libpijul/src/working_copy/filesystem.rs"" at line 344 [4.208900]

Insertion in ""libpijul/src/working_copy/filesystem.rs"" at line 346 [4.208900]

Replacement in ""libpijul/src/record.rs"" at line 8 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 276 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 295 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 472 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 484 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 544 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 559 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 623 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 647 [4.488880]

Replacement in ""libpijul/src/record.rs"" at line 743 [4.488880]