itai.sharim/TagFight - Change C7P2WYNCCLPXHFMLHMWCB3DDQWOUDPBSXNJQ2UCGUED4JBUJHCNQC

Fix for update time sequence nodes not deleting enough nodes on move removal

Created by itai.sharim on September 10, 2022

C7P2WYNCCLPXHFMLHMWCB3DDQWOUDPBSXNJQ2UCGUED4JBUJHCNQC

Dependencies

In channels

main

Change contents

Replacement in Assets/Scripts/UI/WeaveBuilder/WeaveNavigator.cs at line 39 [4.294]

B:BD[3.40922] → [3.40922:40990]

B:BD[3.40990] → [2.11672:11950]

            if (_martialSequenceTime > _timeSequenceNodes.Count) {
                while (_martialSequenceTime > _timeSequenceNodes.Count) {
                    GameObject timeNode = Instantiate(TimeCounterNodeTemplate, TimeCounterTransform);
                    TextMeshProUGUI secLabel = timeNode.GetComponentInChildren<TextMeshProUGUI>();

[3.40922]

[4.1824]

            while (_martialSequenceTime + 1 <= _timeSequenceNodes.Count) {
                GameObject timeNodeToRemove = _timeSequenceNodes[^1];
                _timeSequenceNodes.RemoveAt(_timeSequenceNodes.Count - 1);
                Destroy(timeNodeToRemove.gameObject);
            }

Replacement in Assets/Scripts/UI/WeaveBuilder/WeaveNavigator.cs at line 45 [4.294]

B:BD[4.1826] → [2.11951:12152]

                    secLabel.text = (_timeSequenceNodes.Count + 1).ToString();
                    _timeSequenceNodes.Add(timeNode);
                    timeNode.SetActive(true);
                }

[4.1826]

[3.41356]

            while (_martialSequenceTime > _timeSequenceNodes.Count) {
                GameObject timeNode = Instantiate(TimeCounterNodeTemplate, TimeCounterTransform);
                TextMeshProUGUI secLabel = timeNode.GetComponentInChildren<TextMeshProUGUI>();
                secLabel.text = (_timeSequenceNodes.Count + 1).ToString();
                _timeSequenceNodes.Add(timeNode);
                timeNode.SetActive(true);

Deletion in Assets/Scripts/UI/WeaveBuilder/WeaveNavigator.cs at line 53 [4.294]

B:BD[3.41371] → [3.41371:41448]

B:BD[3.41448] → [2.12153:12465]

∅:D[2.12465] → [3.41650:41665]

B:BD[3.41650] → [3.41650:41665]

            else if (_martialSequenceTime + 1 < _timeSequenceNodes.Count) {
                while (_martialSequenceTime + 1 < _timeSequenceNodes.Count) {
                    GameObject timeNodeToRemove = _timeSequenceNodes[^1];
                    _timeSequenceNodes.RemoveAt(_timeSequenceNodes.Count - 1);
                    Destroy(timeNodeToRemove.gameObject);
                }
            }