itai.sharim/TagFight - Change JMMGK6VQWZOLY6C6YWUPAIHLQXUZ2ZZTVJQAL7ODPZAWUSZQIJJAC

Move end trigger to cancel on end of frame

Created by itai.sharim on April 4, 2023

JMMGK6VQWZOLY6C6YWUPAIHLQXUZ2ZZTVJQAL7ODPZAWUSZQIJJAC

Dependencies

In channels

main

Change contents

Replacement in Assets/Scripts/Controllers/UnitController.cs at line 94 [5.26412]

B:BD[4.47260] → [3.6058:6148]

            RuneWeavingContainer weaving = new( e.Weave.WeaveName, e.Weave.RuneWeaving);

[4.47260]

[6.94737]

            RuneWeavingContainer weaving = new(e.Weave.WeaveName, e.Weave.RuneWeaving);

Replacement in Assets/Scripts/Combat/Weaving/Sequences/MartialSequence.cs at line 66 [8.2175]

B:BD[7.2610] → [7.2610:2692]

        Debug.Log($"positionalReleaseMultiplier {positionalReleaseMultiplier}");

[7.2610]

[7.2692]

        // Debug.Log($"positionalReleaseMultiplier {positionalReleaseMultiplier}");

Deletion in Assets/Scripts/Combat/Runes/Effects/PawnConditions/TransientPawnCondition.cs at line 13 [9.549]

B:BD[9.896] → [6.96209:96341]

        protected override void EndTrigger_OnTriggerConditionMetSpecific() {
            _cancellationSource.Cancel();
        }

Deletion in Assets/Scripts/Combat/Runes/Effects/PawnConditions/PawnCondition.cs at line 39 [9.1405]
B:BD[9.2606] → [6.96344:96401]
```
            EndTrigger_OnTriggerConditionMetSpecific();
```
Insertion in Assets/Scripts/Combat/Runes/Effects/PawnConditions/PawnCondition.cs at line 60 [9.1405]
[4.54486]
[9.3325]
Deletion in Assets/Scripts/Combat/Runes/Effects/PawnConditions/PawnCondition.cs at line 64 [9.1405]
B:BD[9.3372] → [6.96402:96481]
```
        protected virtual void EndTrigger_OnTriggerConditionMetSpecific() { }
```

Replacement in Assets/Scenes/SampleScene.unity at line 41 [10.780110080]

B:BD[10.780111327] → [3.10880:10958]

  m_IndirectSpecularColor: {r: 0.18028352, g: 0.22571376, b: 0.3069224, a: 1}

[10.780111327]

[10.780111406]

  m_IndirectSpecularColor: {r: 0.18028378, g: 0.22571412, b: 0.30692285, a: 1}

Deletion in Assets/Scenes/SampleScene.unity at line 5537 [10.780110080]
B:BD[2.317826] → [2.317826:317855]
B:BD[11.12686] → [3.10959:11005]
```
    rid: 2911539951715745805
  _effectSystem:
    rid: 7918740512397328385
```
Solving an order conflict in Assets/Scenes/SampleScene.unity at line 5537 [10.780110080]
[2.317826]
Insertion in Assets/Scenes/SampleScene.unity at line 5537 [10.780110080]
[0.919]
[11.12730]
```
    rid: 7415760682202169345
```
Replacement in Assets/Scenes/SampleScene.unity at line 5541 [10.780110080]
B:BD[11.12771] → [2.317856:317887]
B:BD[11.12771] → [3.11006:11037]
```
    - rid: 2911539951715745805
    - rid: 7918740512397328385
```
[11.12771]
[11.12801]
```
    - rid: 7415760682202169345
```

Replacement in Assets/Scenes/SampleScene.unity at line 5761 [10.780110080]

B:BD[10.780121071] → [2.317888:317966]

B:BD[10.780121071] → [3.11038:11117]

  m_LocalRotation: {x: 0.22914575, y: -0.0707091, z: 0.01669215, w: 0.970677}
  m_LocalRotation: {x: 0.22914572, y: -0.07070914, z: 0.01669216, w: 0.970677}

[10.780121071]

[12.33888019]

  m_LocalRotation: {x: 0.22914574, y: -0.070709124, z: 0.016692158, w: 0.970677}

Replacement in Assets/Scenes/SampleScene.unity at line 7818 [10.780110080]
B:BD[10.780161886] → [2.317967:318005]
B:BD[10.780161886] → [3.11118:11156]
```
    m_SensorSize: {x: 2.241214, y: 1}
    m_SensorSize: {x: 1.910909, y: 1}
```
[10.780161886]
[10.780161925]
```
    m_SensorSize: {x: 2.2683706, y: 1}
```

Replacement in Assets/Scenes/SampleScene.unity at line 7834 [10.780110080]

B:BD[10.780162310] → [2.318006:318084]

B:BD[10.780162310] → [3.11157:11236]

  m_LocalRotation: {x: 0.22914575, y: -0.0707091, z: 0.01669215, w: 0.970677}
  m_LocalRotation: {x: 0.22914572, y: -0.07070914, z: 0.01669216, w: 0.970677}

[10.780162310]

[12.33918016]

  m_LocalRotation: {x: 0.22914574, y: -0.070709124, z: 0.016692158, w: 0.970677}

Move end trigger to cancel on end of frame

Dependencies

In channels

Change contents

Replacement in Assets/Scripts/Controllers/UnitController.cs at line 94 [5.26412]

Replacement in Assets/Scripts/Combat/Weaving/Sequences/MartialSequence.cs at line 66 [8.2175]

Deletion in Assets/Scripts/Combat/Runes/Effects/PawnConditions/TransientPawnCondition.cs at line 13 [9.549]

Deletion in Assets/Scripts/Combat/Runes/Effects/PawnConditions/PawnCondition.cs at line 39 [9.1405]

Insertion in Assets/Scripts/Combat/Runes/Effects/PawnConditions/PawnCondition.cs at line 60 [9.1405]

Deletion in Assets/Scripts/Combat/Runes/Effects/PawnConditions/PawnCondition.cs at line 64 [9.1405]

Replacement in Assets/Scenes/SampleScene.unity at line 41 [10.780110080]

Deletion in Assets/Scenes/SampleScene.unity at line 5537 [10.780110080]

Solving an order conflict in Assets/Scenes/SampleScene.unity at line 5537 [10.780110080]

Insertion in Assets/Scenes/SampleScene.unity at line 5537 [10.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 5541 [10.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 5761 [10.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 7818 [10.780110080]

Replacement in Assets/Scenes/SampleScene.unity at line 7834 [10.780110080]