itai.sharim/TagFight - Change XTNHXKSQ4PQS6CN3ATENRI7JUXU7DYZMRW4PBSEABN4S4VQHFUMAC

Apply comments from usability test - colors, text, context menu

Created by itai.sharim on September 23, 2023

XTNHXKSQ4PQS6CN3ATENRI7JUXU7DYZMRW4PBSEABN4S4VQHFUMAC

Dependencies

In channels

main

Change contents

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ZipStep.cs at line 8 [3.5653]
B:BD[3.5783] → [3.5783:5830]
```
    public class ZipStep : SequenceGetterStep
```
[3.5783]
[3.5830]
```
    public class ZipStep : SequenceGetterStep, IOperatorStep
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ZipStep.cs at line 29 [3.5653]

B:BD[3.6466] → [3.6466:6518]

        public override string ShortName => "Zip";

[3.6335]

[3.6518]

        public override string ShortName {
            get {
                var operatorName = Operator == null ? "*" : Operator.GetType().Name;
                return new($"Zip.{operatorName}");
            }
        }

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/RepeatStep.cs at line 7 [3.11055]
B:BD[3.11156] → [3.11156:11206]
```
    public class RepeatStep : SequenceGetterStep
```
[3.11156]
[3.11206]
```
    public class RepeatStep : SequenceGetterStep, IOperatorStep
```
Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnSetterStep.cs at line 11 [3.12002]
B:BD[3.12189] → [2.3307:3353]
```
    public class PawnSetterStep : SetterNode
```
[3.12189]
[3.12243]
```
    public class PawnSetterStep : SetterNode, ISetterStep
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnSetterStep.cs at line 25 [3.12002]

B:BD[3.12618] → [3.12618:12675]

        public override string ShortName => "Pawn Set";

[3.12618]

[3.12675]

        public override string ShortName {
            get {
                var resourceName = Resource.Type == null ? "*" : Resource.Type.Name;
                var statName = "Current";
                return new($"Pawn.Set.{resourceName}.{statName}");
            }
        }

Deletion in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnGetterStep.cs at line 7 [3.14327]
B:BD[3.14456] → [3.14456:14485]
```
    // using System.Linq;
```
Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnGetterStep.cs at line 8 [3.14327]
B:BD[3.14487] → [3.14487:14541]
```
    public class PawnGetterStep : SequenceGetterStep
```
[3.14487]
[3.14541]
```
    public class PawnGetterStep : SequenceGetterStep, IGetterStep
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnGetterStep.cs at line 34 [3.14327]

B:BD[3.15801] → [3.15801:15858]

        public override string ShortName => "Pawn Get";

[3.15801]

[3.15858]

        public override string ShortName {
            get {
                var resourceName = Resource.Type == null ? "*" : Resource.Type.Name;
                var statName = "Current";
                return new($"Pawn.Get.{resourceName}.{statName}");
            }
        }

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/OperatorStep.cs at line 7 [2.292]
B:BD[2.393] → [2.393:443]
```
    public class OperatorStep : SingleGetterStep
```
[2.393]
[2.443]
```
    public class OperatorStep : SingleGetterStep, IOperatorStep
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/OperatorStep.cs at line 21 [2.292]

B:BD[2.820] → [2.820:877]

        public override string ShortName => "Operator";

[2.820]

[2.877]

        public override string ShortName {
            get {
                var operatorName = Operator == null ? "*" : Operator.GetType().Name;

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/OperatorStep.cs at line 25 [2.292]

[2.879]

                return new($"{operatorName}");
            }
        }

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/FoldStep.cs at line 7 [3.16729]
B:BD[3.16833] → [3.16833:16879]
```
    public class FoldStep : SingleGetterStep
```
[3.16833]
[3.16879]
```
    public class FoldStep : SingleGetterStep, IOperatorStep
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/FoldStep.cs at line 25 [3.16729]

B:BD[3.17390] → [3.17390:17443]

        public override string ShortName => "Fold";

[3.17390]

[3.17443]

        public override string ShortName {
            get {
                var operatorName = Operator == null ? "*" : Operator.GetType().Name;
                return new($"Fold.{operatorName}");
            }
        }

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 4 [3.17784]
[3.17820]
[2.3728]
```
    using System;
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 13 [3.17784]

B:BD[3.17990] → [3.17990:17992]

[3.17990]

[3.17992]

    public class EffectStepValidatedEventArgs : EventArgs
    {
        public string DisplayName;
        public EffectStepValidatedEventArgs(string displayName) {
            DisplayName = displayName;
        }
    }

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 25 [3.17784]
B:BD[3.18309] → [3.18309:18319]
```
    /// 
```
[3.18309]
[3.18319]
```
    /// <see cref="OperatorStep"/>          Input: Multi  Double            Output: Double
```

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 30 [3.17784]

[3.18555]

    /// 
    /// <see cref="ContextSetterStep"/>     Input: Single Double
    /// <see cref="PawnSetterStep"/>        Input: Single Sequence<Double>
    /// <see cref="ConeAreaStep"/>          Input: 2xDouble

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 35 [3.17784]

[3.18575]

    /// 
    public interface IOperatorStep { };
    public interface IGetterStep { };
    public interface ISetterStep { };

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 45 [3.17784]
[3.18740]
[3.18740]
```
        public event EventHandler<EffectStepValidatedEventArgs> EffectStepValidated;
```

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 51 [3.17784]

[3.18857]

        protected virtual void OnValidate() {
            OnValidated(this, new(ShortName));
        }
        protected virtual void OnValidated(object sender, EffectStepValidatedEventArgs e) {
            EffectStepValidated?.Invoke(sender, e);
        }

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ContextSetterStep.cs at line 9 [3.20176]
B:BD[3.20320] → [2.4035:4084]
```
    public class ContextSetterStep : SetterNode
```
[3.20320]
[3.20375]
```
    public class ContextSetterStep : SetterNode, ISetterStep
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ContextSetterStep.cs at line 24 [3.20176]

B:BD[3.20885] → [3.20885:20945]

        public override string ShortName => "Context Set";

[3.20885]

[3.20945]

        public override string ShortName {
            get {
                var resourceName = Resource.Type == null ? "*" : Resource.Type.Name;
                var registerName = Register.Type == null ? "*" : Register.Type.Name;
                return new($"Context.Set.{resourceName}.{registerName}");
            }
        }

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ContextGetterStep.cs at line 9 [3.22422]
B:BD[3.22633] → [3.22633:22688]
```
    public class ContextGetterStep : SingleGetterStep
```
[3.22633]
[3.22688]
```
    public class ContextGetterStep : SingleGetterStep, IGetterStep
```

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ContextGetterStep.cs at line 40 [3.22422]

B:BD[3.24129] → [3.24129:24189]

        public override string ShortName => "Context Get";

[3.24129]

[3.24189]

        public override string ShortName {
            get {
                var resourceName = Resource.Type == null ? "*" : Resource.Type.Name;
                var registerName = Register.Type == null ? "*" : Register.Type.Name;
                return new($"Context.Get.{resourceName}.{registerName}");
            }
        }

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ConstValueStep.cs at line 6 [3.24537]
∅:D[2.4436] → [3.24642:24694]
B:BD[3.24642] → [3.24642:24694]
```
    public class ConstValueStep : SingleGetterStep
```
[2.4436]
[3.24694]
```
    public class ConstValueStep : SingleGetterStep, IGetterStep
```
Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ConeAreaStep.cs at line 6 [2.1355]
B:BD[2.1432] → [2.1432:1476]
```
    public class ConeAreaStep : SetterNode
```
[2.1432]
[2.1476]
```
    public class ConeAreaStep : SetterNode, ISetterStep
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 58 [3.25328]
B:BD[3.27032] → [3.27032:27061]
```
  Position: {x: 337, y: 380}
```
[3.27032]
[3.27061]
```
  Position: {x: 229, y: 380}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 153 [3.25328]
B:BD[3.29992] → [3.29992:30021]
```
  Position: {x: 873, y: 386}
```
[3.29992]
[3.30021]
```
  Position: {x: 940, y: 386}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 193 [3.25328]
B:BD[3.31068] → [3.31068:31097]
```
  Position: {x: 163, y: 309}
```
[3.31068]
[3.31097]
```
  Position: {x: 115, y: 309}
```
Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 229 [3.25328]
B:BD[3.32233] → [3.32233:32262]
```
  Position: {x: 163, y: 473}
```
[3.32233]
[3.32262]
```
  Position: {x: 105, y: 473}
```

Replacement in Assets/Scenes/SampleScene.unity at line 5764 [4.780110080]

B:BD[4.780121071] → [2.4779:4860]

  m_LocalRotation: {x: 0.22914574, y: -0.070709124, z: 0.016692158, w: 0.970677}

[4.780121071]

[5.33888019]

  m_LocalRotation: {x: 0.22914574, y: -0.070709094, z: 0.016692149, w: 0.970677}

Replacement in Assets/Scenes/SampleScene.unity at line 7939 [4.780110080]

B:BD[4.780162310] → [2.4861:4942]

  m_LocalRotation: {x: 0.22914574, y: -0.070709124, z: 0.016692158, w: 0.970677}

[4.780162310]

[5.33918016]

  m_LocalRotation: {x: 0.22914574, y: -0.070709094, z: 0.016692149, w: 0.970677}

Replacement in Assets/Editor/Rune/RuneEffectView.cs at line 104 [3.33420]

B:BD[3.37388] → [3.37388:37609]

                foreach (var type in TypeCache.GetTypesDerivedFrom(typeof(SingleGetterStep))) {
                    e.menu.AppendAction($"Create [{type.Name}]", action => AddNode(type, action.eventInfo.mousePosition));

[3.37388]

[3.37609]

                foreach (var type in TypeCache.GetTypesDerivedFrom(typeof(IGetterStep))) {
                    e.menu.AppendAction($"Get/{type.Name}", action => AddNode(type, action.eventInfo.mousePosition));

Replacement in Assets/Editor/Rune/RuneEffectView.cs at line 107 [3.33420]

B:BD[3.37628] → [3.37628:37851]

                foreach (var type in TypeCache.GetTypesDerivedFrom(typeof(SequenceGetterStep))) {
                    e.menu.AppendAction($"Create [{type.Name}]", action => AddNode(type, action.eventInfo.mousePosition));

[3.37628]

[3.37851]

                foreach (var type in TypeCache.GetTypesDerivedFrom(typeof(IOperatorStep))) {
                    e.menu.AppendAction($"Operator/{type.Name}", action => AddNode(type, action.eventInfo.mousePosition));

Replacement in Assets/Editor/Rune/RuneEffectView.cs at line 111 [3.33420]

B:BD[3.37872] → [2.6270:6361]

∅:D[2.6361] → [3.37969:38093]

B:BD[3.37969] → [3.37969:38093]

                foreach (var type in TypeCache.GetTypesDerivedFrom(typeof(SetterNode))) {
                    e.menu.AppendAction($"Create [{type.Name}]", action => AddNode(type, action.eventInfo.mousePosition));

[3.37872]

[3.38093]

                foreach (var type in TypeCache.GetTypesDerivedFrom(typeof(ISetterStep))) {
                    e.menu.AppendAction($"Set/{type.Name}", action => AddNode(type, action.eventInfo.mousePosition));

Replacement in Assets/Editor/Rune/RuneEffectView.cs at line 115 [3.33420]

B:BD[3.38356] → [3.38356:38488]

                e.menu.AppendAction("Create Root Node", action => AddNode(typeof(EffectEndNode), action.eventInfo.mousePosition));

[3.38356]

[3.38488]

                e.menu.AppendAction("Root Node", action => AddNode(typeof(EffectEndNode), action.eventInfo.mousePosition));

Insertion in Assets/Editor/Rune/RuneEditor.uss at line 27 [3.40136]

[3.40565]

}
.GetterStep #title{
    background-color: #213555;
}
.SetterStep #title{
    background-color: #183D3D;
}
.OperatorStep #title {
    background-color: #451952;

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 16 [3.40896]

B:BD[3.41266] → [3.41266:41327]

        [SerializeField]
        RuneRef _selectedRuneRef;

[3.41266]

[3.41327]

        public RuneRef SelectedRuneRef;

Insertion in Assets/Editor/Rune/RuneEditor.cs at line 20 [3.40896]

[3.41396]


        [SerializeField]
        EffectStepNodeView _selectedNodeView;

Insertion in Assets/Editor/Rune/RuneEditor.cs at line 28 [3.40896]

[3.41608]

            window.SelectedRuneRef = Selection.activeObject as RuneRef;

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 34 [3.40896]

B:BD[3.41755] → [3.41755:41877]

            var dialogue = EditorUtility.InstanceIDToObject(instanceID) as RuneRef;
            if (dialogue != null) {

[3.41755]

[3.41877]

            var selectedRuneRef = EditorUtility.InstanceIDToObject(instanceID) as RuneRef;
            if (selectedRuneRef != null) {

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 76 [3.40896]

B:BD[3.43315] → [3.43315:43411]

                bindItem = (e, i) => (e as Label).text = _selectedRuneRef.RuneEffects[i].Guid,

[3.43315]

[3.43411]

                bindItem = (e, i) => (e as Label).text = SelectedRuneRef.RuneEffects[i].Guid,

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 109 [3.40896]

B:BD[3.44315] → [3.44315:44383]

            if (_selectedRuneRef.RuneEffects.Remove(runeEffect)) {

[3.44315]

[3.44383]

            if (SelectedRuneRef.RuneEffects.Remove(runeEffect)) {

Deletion in Assets/Editor/Rune/RuneEditor.cs at line 115 [3.40896]
B:BD[3.44627] → [3.44627:44676]
```
                // _runeEffects.RefreshItems();
```

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 122 [3.40896]

B:BD[3.44928] → [3.44928:45062]

            _selectedRuneRef.RuneEffects.Add(runeEffect);
            AssetDatabase.AddObjectToAsset(runeEffect, _selectedRuneRef);

[3.44928]

[3.45062]

            SelectedRuneRef.RuneEffects.Add(runeEffect);
            AssetDatabase.AddObjectToAsset(runeEffect, SelectedRuneRef);

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 128 [3.40896]

B:BD[3.45152] → [3.45152:45340]

            _runeEffects.itemsSource = _selectedRuneRef.RuneEffects;
            _runeEffects.RefreshItems();
            _selectedRuneEffect = _runeEffects.selectedItem as RuneEffect;

[3.45152]

[3.45340]

            if (SelectedRuneRef != null) {
                _runeEffects.itemsSource = SelectedRuneRef.RuneEffects;
                _runeEffects.RefreshItems();
                _selectedRuneEffect = _runeEffects.selectedItem as RuneEffect;
                if (_selectedRuneEffect == null && SelectedRuneRef.RuneEffects.Count > 0) {
                    _runeEffects.SetSelection(0);
                    _selectedRuneEffect = _runeEffects.selectedItem as RuneEffect;
                }
            }

Insertion in Assets/Editor/Rune/RuneEditor.cs at line 142 [3.40896]
[3.45534]
[3.45534]

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 145 [3.40896]

B:BD[3.45617] → [3.45617:45663]

                    _selectedRuneRef = rune;

[3.45617]

[3.45663]

                    SelectedRuneRef = rune;

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 150 [3.40896]

B:BD[3.45905] → [3.45905:46040]

                        if (_selectedRuneRef != runeRefCandidate) {
                            _selectedRuneRef = runeRefCandidate;

[3.45905]

[3.46040]

                        if (SelectedRuneRef != runeRefCandidate) {
                            SelectedRuneRef = runeRefCandidate;

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 159 [3.40896]

B:BD[3.46350] → [3.46350:46485]

                        if (_selectedRuneRef != runeRefCandidate) {
                            _selectedRuneRef = runeRefCandidate;

[3.46350]

[3.46485]

                        if (SelectedRuneRef != runeRefCandidate) {
                            SelectedRuneRef = runeRefCandidate;

Replacement in Assets/Editor/Rune/RuneEditor.cs at line 167 [3.40896]

B:BD[3.46693] → [3.46693:46746]

                    if (_selectedRuneRef == null) {

[3.46693]

[3.46746]

                    if (SelectedRuneRef == null) {

Insertion in Assets/Editor/Rune/RuneEditor.cs at line 175 [3.40896]

[3.46938]

            if (_selectedNodeView != null) {
                _selectedNodeView.Node.EffectStepValidated -= OnEffectStepValidated;
            }
            _selectedNodeView = nodeView;
            _selectedNodeView.Node.EffectStepValidated += OnEffectStepValidated;

Insertion in Assets/Editor/Rune/RuneEditor.cs at line 181 [3.40896]

[3.46991]

        }
        void OnEffectStepValidated(object sender, EffectStepValidatedEventArgs e) {
            _selectedNodeView.title = e.DisplayName;

Insertion in Assets/Editor/Rune/RuneEditor.cs at line 199 [3.40896]

[3.47420]

            if (_selectedNodeView != null) {
                _selectedNodeView.Node.EffectStepValidated -= OnEffectStepValidated;
            }

Insertion in Assets/Editor/Rune/EffectStepNodeView.cs at line 21 [3.47780]
[3.48410]
[3.48410]
Insertion in Assets/Editor/Rune/EffectStepNodeView.cs at line 25 [3.47780]
[3.48479]
[3.48479]
```
            SetClasses();
```

Insertion in Assets/Editor/Rune/EffectStepNodeView.cs at line 27 [3.47780]

[3.48490]


        void SetClasses() {
            switch (Node) {
                case IOperatorStep:
                    AddToClassList("OperatorStep");
                    break;
                case IGetterStep:
                    AddToClassList("GetterStep");
                    break;
                case ISetterStep:
                    AddToClassList("SetterStep");
                    break;
                default:
                    break;
            }
        }

Replacement in Assets/Editor/Rune/EffectStepNodeView.cs at line 46 [3.47780]
B:BD[3.48608] → [2.6492:6523]
```
                return "(N)";
```
[3.48608]
[3.48639]
```
                return "[]";
```
Replacement in Assets/Editor/Rune/EffectStepNodeView.cs at line 49 [3.47780]
B:BD[3.48716] → [2.6524:6555]
```
                return "(1)";
```
[3.48716]
[3.48745]
```
                return "";
```

Apply comments from usability test - colors, text, context menu

Dependencies

In channels

Change contents

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ZipStep.cs at line 8 [3.5653]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ZipStep.cs at line 29 [3.5653]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/RepeatStep.cs at line 7 [3.11055]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnSetterStep.cs at line 11 [3.12002]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnSetterStep.cs at line 25 [3.12002]

Deletion in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnGetterStep.cs at line 7 [3.14327]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnGetterStep.cs at line 8 [3.14327]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/PawnGetterStep.cs at line 34 [3.14327]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/OperatorStep.cs at line 7 [2.292]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/OperatorStep.cs at line 21 [2.292]

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/OperatorStep.cs at line 25 [2.292]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/FoldStep.cs at line 7 [3.16729]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/FoldStep.cs at line 25 [3.16729]

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 4 [3.17784]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 13 [3.17784]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 25 [3.17784]

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 30 [3.17784]

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 35 [3.17784]

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 45 [3.17784]

Insertion in Assets/Scripts/Combat/Runes/Effects/Nodes/EffectStepNode.cs at line 51 [3.17784]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ContextSetterStep.cs at line 9 [3.20176]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ContextSetterStep.cs at line 24 [3.20176]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ContextGetterStep.cs at line 9 [3.22422]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ContextGetterStep.cs at line 40 [3.22422]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ConstValueStep.cs at line 6 [3.24537]

Replacement in Assets/Scripts/Combat/Runes/Effects/Nodes/ConeAreaStep.cs at line 6 [2.1355]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 58 [3.25328]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 153 [3.25328]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 193 [3.25328]

Replacement in Assets/ScriptableObjects/Runes/TestRune.asset at line 229 [3.25328]