itai.sharim/TagFight - Change ZFSIN26KNM3DNHBUA67DKKHQYH62TZ627SNBHPO37IS3AB2XTHEQC

Use Enumarable.Repeat instead of new private function

Created by itai.sharim on October 27, 2022

ZFSIN26KNM3DNHBUA67DKKHQYH62TZ627SNBHPO37IS3AB2XTHEQC

Dependencies

In channels

main

Change contents

Replacement in Assets/Scripts/Combat/Runes/Effects/ResourceAccessors/PawnResourceAccessors.cs at line 82 [4.2560]

B:BD[3.9515] → [3.9515:9683]

                    foreach (var tuple in affected.Zip(Repeat<TResource, TUnit>(values), (transform, value) => (resource: transform.GetComponent<TResource>(), value))

[3.9515]

[3.9683]

                    var repeatedValues = Enumerable.Repeat(values.ToList(), int.MaxValue).SelectMany(value => value );
                    foreach (var tuple in affected.Zip(repeatedValues, (transform, value) => (resource: transform.GetComponent<TResource>(), value))

Deletion in Assets/Scripts/Combat/Runes/Effects/ResourceAccessors/PawnResourceAccessors.cs at line 86 [4.2560]

B:BD[3.9837] → [3.9837:10254]

                    }
                }
                private IEnumerable<Unit<TUnit>> Repeat<TResource, TUnit>(IEnumerable<Unit<TUnit>> values)
                    where TResource : Resource<TUnit>
                    where TUnit : IUnitType {
                    while (true) {
                        foreach (var val in values) {
                            yield return val;
                        }

Replacement in Assets/Scripts/Combat/Runes/Effects/EffectContext.cs at line 28 [5.6210]

B:BD[3.13848] → [2.571:634]

            System.Type key = typeof((TResource, TRegister));

[3.13848]

[2.634]

            var key = typeof((TResource, TRegister));

Replacement in Assets/Scripts/Combat/Runes/Effects/EffectContext.cs at line 37 [5.6210]

B:BD[3.14431] → [2.943:1006]

            System.Type key = typeof((TResource, TRegister));

[3.14431]

[2.1006]

            var key = typeof((TResource, TRegister));

Replacement in Assets/Scripts/Combat/Runes/Effects/AccumulateResourceEffect.cs at line 56 [4.7525]

B:BD[3.15457] → [3.15457:15660]

            return (a.Count == 1) ? b.Zip(Repeat(a),(valB, valA) => Operator.Operate(valA, valB)) :
                                    a.Zip(Repeat(b),(valA, valB) => Operator.Operate(valA, valB));

[3.15457]

[3.15660]

            var (shortList, maybeLongList) = a.Count switch {
                1 => (a, b),
                _ => (b, a)
            };
            var repeatedShortList = Enumerable.Repeat(shortList, int.MaxValue).SelectMany((val) => val);
            return maybeLongList.Zip(repeatedShortList, (x, y) => Operator.Operate(x, y));

Deletion in Assets/Scripts/Combat/Runes/Effects/AccumulateResourceEffect.cs at line 63 [4.7525]

∅:D[6.8054] → [4.8584:8586]

∅:D[3.15671] → [4.8584:8586]

B:BD[4.8584] → [4.8584:8586]

B:BD[4.8586] → [3.15672:15894]

∅:D[3.15894] → [4.8830:8841]

B:BD[4.8830] → [4.8830:8841]


        private IEnumerable<double> Repeat(IEnumerable<double> values) {
            while (true) {
                foreach (var val in values) {
                    yield return val;
                }
            }
        }

Replacement in Assets/Scenes/SampleScene.unity at line 5861 [7.780110080]

B:BD[7.780121071] → [2.1395:1476]

  m_LocalRotation: {x: 0.22914574, y: -0.070709124, z: 0.016692158, w: 0.970677}

[7.780121071]

[8.33888019]

  m_LocalRotation: {x: 0.22914575, y: -0.0707091, z: 0.01669215, w: 0.970677}

Replacement in Assets/Scenes/SampleScene.unity at line 8787 [7.780110080]

B:BD[7.780162310] → [2.1477:1558]

  m_LocalRotation: {x: 0.22914574, y: -0.070709124, z: 0.016692158, w: 0.970677}

[7.780162310]

[8.33918016]

  m_LocalRotation: {x: 0.22914575, y: -0.0707091, z: 0.01669215, w: 0.970677}