Cleaning up the cache in missing_context and find_alive

pmeunier

Jan 12, 2022, 6:18 PM

FABI77LLTZYJAH4YMQ4Y6LXGTHPQ52FSA4DNZ5HHYRU2PXY5WDIAC

Dependencies

• [2] 7NSTS6PK Adding a cache in find_alive to improve performance in some cases
• [3] CCLLB7OI Upgrading to Sanakirja 0.15 + version bump
• [4] AD6M434O find_alive performance (matters a lot for unrecord)
• [5] SXEYMYF7 Fixing the bad changes in history (unfortunately, by rebooting).
• [6] VO5OQW4W Removing anyhow in libpijul
• [7] 6YMDOZIB Refactoring apply
• [8] YN63NUZO Sanakirja 1.0

Change contents

• replacement in libpijul/src/missing_context.rs at line 85
  [2.197]→[2.197:237](∅→∅)
  − let mut alive = alive.borrow_mut();
  [2.197]

  [2.237]
  + let mut alive = alive.borrow().clone();
• replacement in libpijul/src/missing_context.rs at line 96
  [3.698828]→[2.276:305](∅→∅)
  − &mut *alive,
  [3.698828]

  [3.698856]
  + &mut alive,
• replacement in libpijul/src/missing_context.rs at line 101
  [3.698941]→[2.306:379](∅→∅)
  − repair_regular_up(txn, channel, &*alive, d, EdgeFlags::PSEUDO)?;
  [3.698941]

  [3.699912]
  + repair_regular_up(txn, channel, &alive, d, EdgeFlags::PSEUDO)?;
• replacement in libpijul/src/missing_context.rs at line 142
  [2.574]→[2.574:614](∅→∅)
  − let mut alive = alive.borrow_mut();
  [2.574]

  [2.614]
  + let mut alive = alive.borrow().clone();
• replacement in libpijul/src/missing_context.rs at line 147
  [3.10353]→[2.650:728](∅→∅)
  − crate::alive::remove_redundant_children(graph, vids, &mut *alive, c);
  [3.10353]

  [3.701271]
  + crate::alive::remove_redundant_children(graph, vids, &mut alive, c);
• edit in libpijul/src/missing_context.rs at line 424
  [3.707711]

  [3.707711]
  + self.alive_up_cache.clear();

  + self.alive_down_cache.clear();
• edit in libpijul/src/missing_context.rs at line 435
  [3.708016]

  [3.708016]
  + assert!(self.alive_up_cache.is_empty());

  + assert!(self.alive_down_cache.is_empty());
• edit in libpijul/src/find_alive.rs at line 49
  [3.456]→[3.764923:764978](∅→∅),[3.764923]→[3.764923:764978](∅→∅)
  − } else {

  − continue;
• edit in libpijul/src/find_alive.rs at line 50
  [3.764996]

  [3.764996]
  + } else {

  + stack.push(*v)
• edit in libpijul/src/find_alive.rs at line 53
  [3.765010]→[2.2068:2095](∅→∅)
  − stack.push(*v)