address clippy lints

[?]
Nov 30, 2020, 5:20 PM
ZXTHL45OYLOICXTXXEQ6AMNSLMQFZ6BFUJWMO6LZOSDK7ERROC5AC

Dependencies

  • [2] SXEYMYF7 Fixing the bad changes in history (unfortunately, by rebooting).
  • [3] UNZXTNSJ Change text format: order dependencies in the order they were on the channel at record time
  • [4] I52XSRUH Massive cleanup, and simplification
  • [5] MF3WAHBI commands/record: amend current change if unspecified
  • [6] 3YDPHBAN address non-controversial clippy lints
  • [7] KVBLRDOU Concatenating edits with order conflict resolutions (if relevant), and parsing the text format of the result
  • [8] O4DNWMPD Cleaunp and proofreading of libpijul::record
  • [9] WRNT4HRI
  • [10] UBCBQ5FG Removing pijul/src/commands/checkout.rs (unused file), as well as litorg comments

Change contents

  • replacement in pijul/src/commands/record.rs at line 102
    [2.104711][2.104711:104757]()
    signature: signature,
    [2.104711]
    [2.104757]
    signature,
  • replacement in libpijul/src/tests/conflict.rs at line 894
    [2.386280][2.386280:386298]()
    lines.sort();
    [2.386280]
    [2.386298]
    lines.sort_unstable();
  • replacement in libpijul/src/tests/conflict.rs at line 896
    [2.386382][2.386382:386401]()
    lines2.sort();
    [2.386382]
    [2.386401]
    lines2.sort_unstable();
  • replacement in libpijul/src/record.rs at line 640
    [2.512449][2.512449:512493]()
    .or_insert(Vec::new());
    [2.512449]
    [2.512493]
    .or_insert_with(Vec::new);
  • replacement in libpijul/src/record.rs at line 645
    [2.512643][2.512643:512687]()
    .or_insert(Vec::new());
    [2.512643]
    [2.512687]
    .or_insert_with(Vec::new);
  • replacement in libpijul/src/record.rs at line 708
    [2.515681][2.515681:515729]()
    .or_insert(Vec::new());
    [2.515681]
    [2.515729]
    .or_insert_with(Vec::new);
  • replacement in libpijul/src/record.rs at line 732
    [2.516947][2.516947:516991]()
    .or_insert(Vec::new());
    [2.516947]
    [2.516991]
    .or_insert_with(Vec::new);
  • replacement in libpijul/src/record.rs at line 901
    [2.523537][2.523537:523571]()
    edges: edges,
    [2.523537]
    [2.523571]
    edges,
  • replacement in libpijul/src/pristine/sanakirja.rs at line 978
    [2.564998][2.564998:565045]()
    self.put_channel(commit.clone())?;
    [2.564998]
    [2.565045]
    self.put_channel(commit)?;
  • replacement in libpijul/src/pristine/sanakirja.rs at line 1189
    [2.572629][2.572629:572665]()
    name: name.clone(),
    [2.572629]
    [2.572665]
    name,
  • replacement in libpijul/src/lib.rs at line 232
    [2.725076][2.725076:725172]()
    apply::apply_local_change(self, channel, &change, hash.clone(), &recorded.updatables)?;
    [2.725076]
    [2.725172]
    apply::apply_local_change(self, channel, &change, hash, &recorded.updatables)?;
  • replacement in libpijul/src/fs.rs at line 128
    [2.741885][2.741885:741935]()
    current = v.parent_inode.clone();
    [2.741885]
    [2.741935]
    current = v.parent_inode;
  • replacement in libpijul/src/diff/replace.rs at line 281
    [2.789395][2.789395:789439]()
    .or_insert(Vec::new());
    [2.789395]
    [2.789439]
    .or_default();
  • replacement in libpijul/src/diff/mod.rs at line 195
    [2.800245][2.800245:800297](),[2.800297][2.800297:800333](),[2.800333][2.800333:800348]()
    local: Local {
    line: 0,
    path: path.clone(),
    },
    [2.800245]
    [2.800348]
    local: Local { line: 0, path },
  • replacement in libpijul/src/diff/delete.rs at line 106
    [2.809117][2.809117:809445]()
    match diff.conflict_ends[diff.pos_a[i].conflict].conflict_type {
    ConflictType::Zombie => {
    solved_conflict_end = solved_conflict_end
    .max(diff.conflict_ends[diff.pos_a[i].conflict].end_pos)
    }
    _ => {}
    [2.809117]
    [2.809445]
    if let ConflictType::Zombie =
    diff.conflict_ends[diff.pos_a[i].conflict].conflict_type
    {
    solved_conflict_end =
    solved_conflict_end.max(diff.conflict_ends[diff.pos_a[i].conflict].end_pos)