jcdickinson/pijul - Change 3OW3YNZXF6DR2EI5XS7PDHUUZMARDU2JUJFJKIEWXQNSMCIBVAOQC

Dependencies completion in push and pull, updated after stabilisation of remote caches

Created by pmeunier on September 14, 2021

3OW3YNZXF6DR2EI5XS7PDHUUZMARDU2JUJFJKIEWXQNSMCIBVAOQC

Dependencies

In channels

main

Change contents

Deletion in "pijul/src/commands/pushpull.rs" at line 221 [4.111631]
B:BD[3.20240] → [3.20240:20264]
```
            remote_ref,
```
Insertion in "pijul/src/commands/pushpull.rs" at line 224 [4.111631]
[3.20343]
[3.20343]
```
            ..
```

Replacement in "pijul/src/commands/pushpull.rs" at line 277 [4.111631]

B:BD[5.158] → [2.902:991]

                let comp = complete_deps(&*txn.read(), &remote_ref, &repo.changes, &d)?;

[5.158]

[5.232]

                let comp = complete_deps(&repo.changes, &to_upload, &d)?;

Replacement in "pijul/src/commands/pushpull.rs" at line 421 [4.111631]

B:BD[5.566] → [2.992:1075]

                let comp = complete_deps(&*txn.read(), &None, &repo.changes, &d)?;

[5.566]

[5.642]

                let comp = complete_deps(&repo.changes, &to_download, &d)?;

Replacement in "pijul/src/commands/pushpull.rs" at line 554 [4.111631]

B:BD[4.122682] → [6.188:297]

fn complete_deps<T: TxnT, C: ChangeStore>(
    txn: &T,
    remote_changes: &Option<libpijul::RemoteRef<T>>,

[4.121148]

[5.843]

fn complete_deps<C: ChangeStore>(

Insertion in "pijul/src/commands/pushpull.rs" at line 556 [4.111631]
[5.854]
[7.2859]
```
    original: &[libpijul::Hash],
```

Replacement in "pijul/src/commands/pushpull.rs" at line 559 [4.111631]

B:BD[7.2937] → [2.1076:1171]

    let mut now_ = HashSet::new();
    let mut result = Vec::new();
    for &h in now.iter() {

[7.2937]

[2.1171]

    let original: HashSet<_> = original.iter().collect();
    let mut now_ = HashSet::with_capacity(original.len());
    let mut result = Vec::with_capacity(original.len());
    let mut stack: Vec<_> = now.iter().rev().cloned().collect();
    while let Some(h) = stack.pop() {
        stack.push(h);
        let l0 = stack.len();

Replacement in "pijul/src/commands/pushpull.rs" at line 567 [4.111631]

∅:D[8.327] → [6.298:350]

∅:D[2.1214] → [6.298:350]

B:BD[5.1255] → [6.298:350]

B:BD[6.350] → [9.12121:12181]

∅:D[9.12181] → [6.401:463]

∅:D[10.15077] → [6.401:463]

B:BD[6.401] → [6.401:463]

B:BD[6.463] → [2.1215:1247]

∅:D[2.1247] → [5.1326:1358]

B:BD[5.1326] → [5.1326:1358]

B:BD[5.1358] → [2.1248:1274]

            if let Some(ref rem) = remote_changes {
                if txn.remote_has_change(rem, &d.into())? {
                    continue;
                }
            }
            if now_.insert(d) {
                result.push(d);
                continue;

[2.1214]

[5.1390]

            if original.get(&d).is_some() && now_.get(&d).is_none() {
                // The user missed a dep.
                stack.push(d);

Replacement in "pijul/src/commands/pushpull.rs" at line 572 [4.111631]

B:BD[5.1414] → [2.1275:1330]

        if now_.insert(h) {
            result.push(h)

[5.1414]

[11.2286]

        if stack.len() == l0 {
            // We have all dependencies.
            stack.pop();
            if now_.insert(h) {
                result.push(h);
            }