laumann/pijul - Change YHG37GA4BELXO4I6TKXMEBIX5MHQT6DWFFFIYYUGLZ4UWCC3NGOQC

Removing one buffer copy in VertexBuffer

Created by pmeunier on January 12, 2022

YHG37GA4BELXO4I6TKXMEBIX5MHQT6DWFFFIYYUGLZ4UWCC3NGOQC

Dependencies

In channels

main

Change contents

Replacement in pijul/src/commands/credit.rs at line 97 [6.178684]

B:BD[4.6159] → [5.970:1035]

    fn output_line<E, C: FnOnce(&mut Vec<u8>) -> Result<(), E>>(

[4.6159]

[6.181121]

    fn output_line<E, C: FnOnce(&mut [u8]) -> Result<(), E>>(

Replacement in pijul/src/commands/credit.rs at line 106 [6.178684]
B:BD[6.181265] → [6.181265:181291]
```
        self.buf.clear();
```
[6.181265]
[6.181291]
```
        assert_eq!(self.buf.len(), v.end - v.start);
```
Replacement in libpijul/src/vertex_buffer.rs at line 17 [6.217202]
B:BD[5.5122] → [5.5122:5172]
```
        F: FnOnce(&mut Vec<u8>) -> Result<(), E>;
```
[5.5122]
[6.217952]
```
        F: FnOnce(&mut [u8]) -> Result<(), E>;
```

Replacement in libpijul/src/vertex_buffer.rs at line 91 [6.217202]

B:BD[5.5860] → [5.5860:5910]

        C: FnOnce(&mut Vec<u8>) -> Result<(), E>,

[5.5860]

[5.5910]

        C: FnOnce(&mut [u8]) -> Result<(), E>,

Replacement in libpijul/src/vertex_buffer.rs at line 93 [6.217202]
∅:D[5.5916] → [6.219993:220019]
B:BD[6.219993] → [6.219993:220019]
```
        self.buf.clear();
```
[5.5916]
[6.220019]
```
        self.buf.resize(v.end - v.start, 0);
```
Replacement in libpijul/src/vertex_buffer.rs at line 196 [6.217202]
B:BD[5.6335] → [5.6335:6385]
```
        C: FnOnce(&mut Vec<u8>) -> Result<(), E>,
```
[5.6335]
[5.6385]
```
        C: FnOnce(&mut [u8]) -> Result<(), E>,
```
Replacement in libpijul/src/vertex_buffer.rs at line 198 [6.217202]
∅:D[5.6391] → [6.222533:222559]
B:BD[6.222533] → [6.222533:222559]
```
        self.buf.clear();
```
[5.6391]
[6.222559]
```
        self.buf.resize(v.end - v.start, 0);
```
Replacement in libpijul/src/unrecord/working_copy.rs at line 104 [6.225940]
∅:D[7.499] → [6.229174:229205]
∅:D[5.7077] → [6.229174:229205]
∅:D[3.9301] → [6.229174:229205]
∅:D[8.21151] → [6.229174:229205]
B:BD[6.229174] → [6.229174:229205]
```
    let mut name = Vec::new();
```
[3.9301]
[9.652]
```
    let mut name = vec![0; source.end - source.start];
```

Replacement in libpijul/src/record.rs at line 584 [6.488880]

B:BD[10.52122] → [10.52122:52169]

                    let mut name = Vec::new();

[10.52122]

[10.52169]

                    let mut name = vec![0; child.end - child.start];

Replacement in libpijul/src/record.rs at line 1210 [6.488880]
B:BD[11.11052] → [11.11052:11087]
```
        let mut meta = Vec::new();
```
[11.11052]
[11.11087]
```
        let mut meta = vec![0; name_dest.end - name_dest.start];
```
Deletion in libpijul/src/record.rs at line 1326 [6.488880]
∅:D[2.309] → [6.512762:512793]
B:BD[6.512762] → [6.512762:512793]
```
        previous_name.clear();
```

Insertion in libpijul/src/record.rs at line 1327 [6.488880]

[12.52079]

[13.1032]

        previous_name.resize(parent_dest.end - parent_dest.start, 0);

Insertion in libpijul/src/record.rs at line 1641 [6.488880]

[14.627]

                previous_name.resize(parent_dest.end - parent_dest.start, 0);

Replacement in libpijul/src/output/mod.rs at line 226 [6.686190]
∅:D[15.732] → [11.23205:23240]
B:BD[11.23205] → [11.23205:23240]
```
    let mut name_buf = Vec::new();
```
[15.732]
[11.23240]
```
    let mut name_buf = vec![0; name_vertex.end - name_vertex.start];
```
Insertion in libpijul/src/fs.rs at line 640 [6.737429]
[8.109758]
[13.1605]
```
        buf.resize(dest.end - dest.start, 0);
```
Insertion in libpijul/src/fs.rs at line 739 [6.737429]
[6.755303]
[13.1750]
```
            buf.resize(dest.end - dest.start, 0);
```

Replacement in libpijul/src/fs.rs at line 889 [6.737429]

B:BD[16.908] → [16.908:942]

                name_buf.clear();

[16.908]

[16.942]

                name_buf.resize(name_dest.end - name_dest.start, 0);

Replacement in libpijul/src/fs.rs at line 1018 [6.737429]
B:BD[6.762917] → [6.762917:762947]
```
            name_buf.clear();
```
[6.762917]
[6.762947]
```
            name_buf.resize(name.end - name.start, 0);
```
Deletion in libpijul/src/diff/vertex_buffer.rs at line 6 [6.768903]
B:BD[6.769131] → [6.769131:769153]
```
    pub buf: Vec<u8>,
```
Deletion in libpijul/src/diff/vertex_buffer.rs at line 64 [6.768903]
B:BD[6.770937] → [6.770937:770993]
```
            buf: Vec::with_capacity(graph.len_bytes()),
```
Replacement in libpijul/src/diff/vertex_buffer.rs at line 138 [6.768903]
B:BD[5.32656] → [5.32656:32706]
```
        C: FnOnce(&mut Vec<u8>) -> Result<(), E>,
```
[5.32656]
[5.32706]
```
        C: FnOnce(&mut [u8]) -> Result<(), E>,
```

Replacement in libpijul/src/diff/vertex_buffer.rs at line 143 [6.768903]

B:BD[6.773750] → [6.773750:773803]

        self.buf.clear();
        c(&mut self.buf)?;

[6.773750]

[6.773803]

        let len = self.contents_a.len();
        self.contents_a.resize(len + (v.end - v.start), 0);
        c(&mut self.contents_a[len..])?;

Replacement in libpijul/src/diff/vertex_buffer.rs at line 147 [6.768903]
B:BD[6.773836] → [6.773836:773876]
```
            pos: self.contents_a.len(),
```
[6.773836]
[6.773876]
```
            pos: len,
```
Deletion in libpijul/src/diff/vertex_buffer.rs at line 152 [6.768903]
B:BD[6.774014] → [6.774014:774057]
```
        self.contents_a.extend(&self.buf);
```
Replacement in libpijul/src/changestore/mod.rs at line 34 [6.817216]
B:BD[6.818204] → [6.818204:818231]
```
        buf: &mut Vec<u8>,
```
[6.818204]
[5.33608]
```
        buf: &mut [u8],
```
Replacement in libpijul/src/changestore/mod.rs at line 43 [6.817216]
B:BD[6.818473] → [6.818473:818500]
```
        buf: &mut Vec<u8>,
```
[6.818473]
[5.33720]
```
        buf: &mut [u8],
```
Replacement in libpijul/src/changestore/mod.rs at line 90 [6.817216]
B:BD[6.819822] → [6.819822:819852]
```
        buf: &'a mut Vec<u8>,
```
[6.819822]
[13.2070]
```
        buf: &'a mut [u8],
```
Deletion in libpijul/src/changestore/mod.rs at line 92 [6.817216]
∅:D[13.2119] → [6.819911:819932]
∅:D[5.34335] → [6.819911:819932]
B:BD[6.819911] → [6.819911:819932]
```
        buf.clear();
```
Replacement in libpijul/src/changestore/memory.rs at line 51 [6.820702]
B:BD[6.821562] → [6.821562:821589]
```
        buf: &mut Vec<u8>,
```
[6.821562]
[5.34753]
```
        buf: &mut [u8],
```
Deletion in libpijul/src/changestore/memory.rs at line 53 [6.820702]
B:BD[5.34791] → [12.137549:137603]
```
        buf.resize(key.end.us() - key.start.us(), 0);
```
Insertion in libpijul/src/changestore/memory.rs at line 56 [6.820702]
[6.821758]
[6.821758]
```
        assert_eq!(buf.len(), key.end - key.start);
```
Replacement in libpijul/src/changestore/memory.rs at line 61 [6.820702]
∅:D[12.137672] → [6.821956:822022]
B:BD[6.821956] → [6.821956:822022]
```
        buf.clear();
        buf.extend(&p.contents[start..end]);
```
[12.137672]
[6.822022]
```
        buf.clone_from_slice(&p.contents[start..end]);
```
Replacement in libpijul/src/changestore/memory.rs at line 67 [6.820702]
B:BD[6.822127] → [6.822127:822154]
```
        buf: &mut Vec<u8>,
```
[6.822127]
[5.34792]
```
        buf: &mut [u8],
```
Deletion in libpijul/src/changestore/memory.rs at line 70 [6.820702]
B:BD[6.822237] → [12.137673:137731]
```
            buf.resize(key.end.us() - key.start.us(), 0);
```
Insertion in libpijul/src/changestore/memory.rs at line 73 [6.820702]
[6.822382]
[6.822382]
```
            assert_eq!(key.end.us() - key.start.us(), buf.len());
```

Replacement in libpijul/src/changestore/memory.rs at line 78 [6.820702]

∅:D[12.137808] → [6.822577:822651]

B:BD[6.822577] → [6.822577:822651]

            buf.clear();
            buf.extend(&p.contents[start..end]);

[12.137808]

[6.822651]

            buf.clone_from_slice(&p.contents[start..end]);

Replacement in libpijul/src/changestore/filesystem.rs at line 176 [6.824013]
B:BD[6.828584] → [6.828584:828611]
```
        buf: &mut Vec<u8>,
```
[6.828584]
[5.35754]
```
        buf: &mut [u8],
```
Deletion in libpijul/src/changestore/filesystem.rs at line 179 [6.824013]
∅:D[10.88582] → [12.137809:137863]
B:BD[5.35792] → [12.137809:137863]
```
        buf.resize(key.end.us() - key.start.us(), 0);
```
Insertion in libpijul/src/changestore/filesystem.rs at line 183 [6.824013]
[6.828797]
[6.828797]
```
        assert_eq!(key.end - key.start, buf.len());
```
Replacement in libpijul/src/changestore/filesystem.rs at line 193 [6.824013]
B:BD[6.829090] → [6.829090:829117]
```
        buf: &mut Vec<u8>,
```
[6.829090]
[5.35793]
```
        buf: &mut [u8],
```

Replacement in libpijul/src/changestore/filesystem.rs at line 196 [6.824013]

B:BD[6.829200] → [12.137922:137980]

            buf.resize(key.end.us() - key.start.us(), 0);

[6.829200]

[6.829263]

            assert_eq!(key.end.us() - key.start.us(), buf.len());

Replacement in libpijul/src/change/text_changes.rs at line 1096 [5.37976]
B:BD[5.85978] → [17.35423:35452]
```
                tmp.clear();
```
[5.85978]
[5.86007]
```
                tmp.resize(e.to.end - e.to.start, 0);
```
Replacement in libpijul/src/alive/output.rs at line 215 [6.988425]
B:BD[6.993511] → [6.993511:993560]
```
        let get_contents = |buf: &mut Vec<u8>| {
```
[6.993466]
[5.100565]
```
        let get_contents = |buf: &mut [u8]| {
```

Removing one buffer copy in VertexBuffer

Dependencies

In channels

Change contents

Replacement in pijul/src/commands/credit.rs at line 97 [6.178684]

Replacement in pijul/src/commands/credit.rs at line 106 [6.178684]

Replacement in libpijul/src/vertex_buffer.rs at line 17 [6.217202]

Replacement in libpijul/src/vertex_buffer.rs at line 91 [6.217202]

Replacement in libpijul/src/vertex_buffer.rs at line 93 [6.217202]

Replacement in libpijul/src/vertex_buffer.rs at line 196 [6.217202]

Replacement in libpijul/src/vertex_buffer.rs at line 198 [6.217202]

Replacement in libpijul/src/unrecord/working_copy.rs at line 104 [6.225940]

Replacement in libpijul/src/record.rs at line 584 [6.488880]

Replacement in libpijul/src/record.rs at line 1210 [6.488880]

Deletion in libpijul/src/record.rs at line 1326 [6.488880]

Insertion in libpijul/src/record.rs at line 1327 [6.488880]

Insertion in libpijul/src/record.rs at line 1641 [6.488880]

Replacement in libpijul/src/output/mod.rs at line 226 [6.686190]

Insertion in libpijul/src/fs.rs at line 640 [6.737429]

Insertion in libpijul/src/fs.rs at line 739 [6.737429]

Replacement in libpijul/src/fs.rs at line 889 [6.737429]

Replacement in libpijul/src/fs.rs at line 1018 [6.737429]

Deletion in libpijul/src/diff/vertex_buffer.rs at line 6 [6.768903]

Deletion in libpijul/src/diff/vertex_buffer.rs at line 64 [6.768903]

Replacement in libpijul/src/diff/vertex_buffer.rs at line 138 [6.768903]

Replacement in libpijul/src/diff/vertex_buffer.rs at line 143 [6.768903]

Replacement in libpijul/src/diff/vertex_buffer.rs at line 147 [6.768903]

Deletion in libpijul/src/diff/vertex_buffer.rs at line 152 [6.768903]

Replacement in libpijul/src/changestore/mod.rs at line 34 [6.817216]

Replacement in libpijul/src/changestore/mod.rs at line 43 [6.817216]

Replacement in libpijul/src/changestore/mod.rs at line 90 [6.817216]

Deletion in libpijul/src/changestore/mod.rs at line 92 [6.817216]

Replacement in libpijul/src/changestore/memory.rs at line 51 [6.820702]

Deletion in libpijul/src/changestore/memory.rs at line 53 [6.820702]

Insertion in libpijul/src/changestore/memory.rs at line 56 [6.820702]

Replacement in libpijul/src/changestore/memory.rs at line 61 [6.820702]

Replacement in libpijul/src/changestore/memory.rs at line 67 [6.820702]

Deletion in libpijul/src/changestore/memory.rs at line 70 [6.820702]

Insertion in libpijul/src/changestore/memory.rs at line 73 [6.820702]

Replacement in libpijul/src/changestore/memory.rs at line 78 [6.820702]

Replacement in libpijul/src/changestore/filesystem.rs at line 176 [6.824013]

Deletion in libpijul/src/changestore/filesystem.rs at line 179 [6.824013]

Insertion in libpijul/src/changestore/filesystem.rs at line 183 [6.824013]

Replacement in libpijul/src/changestore/filesystem.rs at line 193 [6.824013]

Replacement in libpijul/src/changestore/filesystem.rs at line 196 [6.824013]

Replacement in libpijul/src/change/text_changes.rs at line 1096 [5.37976]

Replacement in libpijul/src/alive/output.rs at line 215 [6.988425]