korrat/beancount-importers - Change WS3UUOV3DGSOZSN4V2O6YZDFO3M4NIC6BCYWGGEHFBCV4KZJPQHAC

Extract commodity type into separate crate

Created by korrat on June 23, 2023

WS3UUOV3DGSOZSN4V2O6YZDFO3M4NIC6BCYWGGEHFBCV4KZJPQHAC

Dependencies

In channels

main

Change contents

Deletion in common/beancount-types/src/that.rs at line 36 [5.2458]

B:BD[5.4722] → [5.4722:4777]

B:BD[5.4777] → [6.3975:4029]

∅:D[6.4029] → [5.4777:4821]

B:BD[5.4777] → [5.4777:4821]

B:BD[5.4874] → [5.4874:5842]


mod commodities {
    use {
        crate::Commodity,
        core::{fmt::Debug, hash::Hash, str::FromStr},
        static_assertions::assert_impl_all,
        test_case::test_case,
    };
    assert_impl_all!(
        Commodity: Copy,
        Debug,
        FromStr,
        Hash,
        Ord,
        TryFrom<&'static str>
    );
    #[test_case("A"; "single letter")]
    #[test_case("USD"; "dollar")]
    #[test_case("EUR"; "euro")]
    #[test_case("MSFT"; "stock")]
    #[test_case("AIRMILE"; "creative")]
    #[test_case("DE.-_3"; "with special characters")]
    fn parse_when_valid(name: &str) {
        let commodity = Commodity::try_from(name).unwrap();
        assert_eq!(commodity.to_string(), name);
    }
    #[test_case("0"; "starting with number")]
    #[test_case("D-"; "ending with dash")]
    #[test_case("E_"; "ending with underscore")]
    #[test_case("X."; "ending with dot")]
    #[test_case("X 3"; "containing space")]
    #[test_case("X\\0"; "containing backslash")]
    fn do_not_parse_when_invalid(name: &str) {
        Commodity::try_from(name).unwrap_err();
    }
    // TODO proptest?
}

Replacement in common/beancount-types/src/lib.rs at line 1 [5.5874]
B:BD[5.5874] → [2.840:880]
```
#![warn(clippy::all, clippy::pedantic)]
```
[5.5874]
[2.880]
```
#![warn(clippy::all, clippy::nursery, clippy::pedantic)]
```
Insertion in common/beancount-types/src/lib.rs at line 9 [5.5874]
[3.2176]
[3.2176]
```
pub use beancount_commodity::Commodity;
```
Deletion in common/beancount-types/src/lib.rs at line 14 [5.5874]
B:BD[6.4156] → [6.4156:4193]
```
pub use crate::commodity::Commodity;
```
Deletion in common/beancount-types/src/lib.rs at line 37 [5.5874]
B:BD[5.5953] → [5.5953:5968]
```
mod commodity;
```

Replacement in common/beancount-types/Cargo.toml at line 26 [5.25786]

B:BD[3.2285] → [3.2285:2336]

beancount-account.path = "../../beancount/account"

[3.2285]

[3.2336]

beancount-account.path   = "../../beancount/account"
beancount-commodity.path = "../../beancount/commodity"

File addition: commodity (d--x------)
[3.1]
File addition: tests (d--x------)
[0.1]

File addition: basic.rs (---x------)

[0.24]

use core::fmt::Debug;
use core::hash::Hash;
use core::str::FromStr;
use beancount_commodity::Commodity;
use static_assertions::assert_impl_all;
use test_case::test_case;
assert_impl_all!(
    Commodity: Copy,
    Debug,
    FromStr,
    Hash,
    Ord,
    TryFrom<&'static str>
);
#[test_case("A"; "single letter")]
#[test_case("USD"; "dollar")]
#[test_case("EUR"; "euro")]
#[test_case("MSFT"; "stock")]
#[test_case("AIRMILE"; "creative")]
#[test_case("DE.-_3"; "with special characters")]
fn parse_when_valid(name: &str) {
    let commodity = Commodity::try_from(name).unwrap();
    assert_eq!(commodity.to_string(), name);
}
#[test_case("0"; "starting with number")]
#[test_case("D-"; "ending with dash")]
#[test_case("E_"; "ending with underscore")]
#[test_case("X."; "ending with dot")]
#[test_case("X 3"; "containing space")]
#[test_case("X\\0"; "containing backslash")]
fn do_not_parse_when_invalid(name: &str) {
    Commodity::try_from(name).unwrap_err();
}
// TODO proptest?

File addition: src (d--x------)
[0.1]
File move: commodity.rs → lib.rs
BF:BFD[5.44] → [5.8091:8127]
BF:BF[5.8127] → [5.8128:8128]
[0.1067]
[5.8128]
Insertion in beancount/commodity/src/lib.rs at line 1 [5.8128]
[5.8128]
[6.4876]
```
#![warn(clippy::all, clippy::nursery, clippy::pedantic)]
```

File addition: Cargo.toml (---x------)

[0.1]

[package]
name = "beancount-commodity"
edition.workspace      = true
publish.workspace      = true
rust-version.workspace = true
version.workspace      = true
[dependencies]
# Inherited dependencies
arrayvec.workspace   = true
delegate.workspace   = true
lazy-regex.workspace = true
miette.workspace     = true
serde.workspace      = true
snafu.workspace      = true
[dev-dependencies]
static_assertions.workspace = true
test-case.workspace         = true

Deletion in beancount/account/Cargo.toml at line 3 [3.1218]
B:BD[3.1256] → [3.1256:1291]
```
version = "0.1.0"
edition = "2021"
```

Replacement in beancount/account/Cargo.toml at line 4 [3.1218]

B:BD[3.1292] → [3.1292:1389]

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[3.1292]

[3.1389]

edition.workspace      = true
publish.workspace      = true
rust-version.workspace = true
version.workspace      = true

Replacement in beancount/account/Cargo.toml at line 11 [3.1218]
B:BD[3.1430] → [3.1430:1456]
```
delegate.workspace = true
```
[3.1430]
[3.1456]
```
delegate.workspace   = true
```

Replacement in beancount/account/Cargo.toml at line 13 [3.1218]

B:BD[3.1484] → [3.1484:1576]

miette.workspace = true
momo.workspace = true
serde.workspace = true
snafu.workspace = true

[3.1484]

[3.1576]

miette.workspace     = true
momo.workspace       = true
serde.workspace      = true
snafu.workspace      = true

Deletion in beancount/account/Cargo.toml at line 19 [3.1218]
B:BD[3.1596] → [3.1596:1623]
```
test-case.workspace = true
```
Insertion in beancount/account/Cargo.toml at line 20 [3.1218]
[3.1658]
```
test-case.workspace         = true
```
Replacement in Cargo.lock at line 205 [8.9916]
B:BD[7.2189] → [7.2189:2207]
```
version = "0.1.0"
```
[7.2189]
[7.2207]
```
version = "0.0.0-dev.0"
```

Insertion in Cargo.lock at line 218 [8.9916]

[9.279]

[4.15218]

name = "beancount-commodity"
version = "0.0.0-dev.0"
dependencies = [
 "arrayvec",
 "delegate",
 "lazy-regex",
 "miette",
 "serde",
 "snafu",
 "static_assertions",
 "test-case",
]
[[package]]

Insertion in Cargo.lock at line 328 [8.9916]
[7.2353]
[5.26614]
```
 "beancount-commodity",
```

Extract commodity type into separate crate

Dependencies

In channels

Change contents

Deletion in common/beancount-types/src/that.rs at line 36 [5.2458]

Replacement in common/beancount-types/src/lib.rs at line 1 [5.5874]

Insertion in common/beancount-types/src/lib.rs at line 9 [5.5874]

Deletion in common/beancount-types/src/lib.rs at line 14 [5.5874]

Deletion in common/beancount-types/src/lib.rs at line 37 [5.5874]

Replacement in common/beancount-types/Cargo.toml at line 26 [5.25786]

File addition: commodity (d--x------)

File addition: tests (d--x------)

File addition: basic.rs (---x------)

File addition: src (d--x------)

File move: commodity.rs → lib.rs

Insertion in beancount/commodity/src/lib.rs at line 1 [5.8128]

File addition: Cargo.toml (---x------)

Deletion in beancount/account/Cargo.toml at line 3 [3.1218]

Replacement in beancount/account/Cargo.toml at line 4 [3.1218]

Replacement in beancount/account/Cargo.toml at line 11 [3.1218]

Replacement in beancount/account/Cargo.toml at line 13 [3.1218]

Deletion in beancount/account/Cargo.toml at line 19 [3.1218]

Insertion in beancount/account/Cargo.toml at line 20 [3.1218]

Replacement in Cargo.lock at line 205 [8.9916]

Insertion in Cargo.lock at line 218 [8.9916]

Insertion in Cargo.lock at line 328 [8.9916]