change: use simple type aliases consistently

laumann

Feb 9, 2024, 3:05 PM

72V7NBNWF4EQ4Z7NRBVTUCAI3CFM54HVF4RCS4ZAY75UQBZZT7CQC

Dependencies

• [2] QSQNGA5K changestore: load changes on demand
• [3] ZS3UJEZU change: support version = 4 (noenc) format
• [4] 7HUCJG6Z change: fix output bug in print_change() for multiple authors
• [5] 3FT3XTJM change: support -v/-h flags
• [6] XRGUHSC4 change: fix some formatting issues
• [7] ZTDGWUGP add repository structure
• [8] ZKAOPMCH change: Implement decoding of edits, atoms, positions, among others
• [9] XTVLIC24 change: refactor to print_change()
• [10] KEC3WLFN change: remove debugging lines
• [11] U3JWO63Y change: deduplicate some code repetition
• [12] NEORNIZE change: decode and print file moves
• [13] QLH63JBH change: replace calls to abort() with die()
• [14] YDQLW2ZO change: rework printing of patches - print Edit and Newvertex types
• [15] EHVLRMEF change: add vertexeq, fix deleted lines duplication
• [16] YFBKBUKB change: rename binstat -> bc
• [17] XDWQHPFD change: add cli option to do "raw" dump
• [18] WFA5BBRF Fix warnings
• [19] JAGXXSR7 change: initial work on decoding hunks
• [20] OBKF6SII change: decompress the hashed section too
• [21] 2U7P5SFQ Change struct names "struct foo -> typedef struct Foo"
• [22] QEFCNNVC change: display offsets for given change file
• [23] SMB3M6ES change: rework to make more testable
• [24] FMYCPGKD change: extract hash list decoding into reused function
• [25] RRYWNHFE change: pass verbose to print_atom()
• [26] Q7TKZCJP Add initial support for reading the offsets from a (fixed) change
• [27] RIWSVVAS change: decompress the 'contents' with zstd_seekable
• [28] JVU3TTT5 all: switch away from typedefing anonymous structs
• [29] TGT4VSME change: decode FILE_ADD
• [30] 5D2IYPL7 change: introduce changestore, print deleted lines
• [31] LPGHALLK change: adjust printing of file adds
• [32] NZNIG2UL Fix lots of warnings, adjust build flags

Change contents

• replacement in change.c at line 75
  [5.15]→[5.344:412](∅→∅)
  − change_readhash(struct bincode *bc, uint8_t *dest, uint8_t variant)
  [5.15]

  [5.81]
  + change_readhash(struct bincode *bc, u8 *dest, u8 variant)
• replacement in change.c at line 92
  [5.88]→[5.88:101](∅→∅),[5.101]→[5.442:453](∅→∅)
  − size_t len;

  − size_t i;
  [5.88]

  [5.109]
  + usize len;

  + usize i;
• replacement in change.c at line 100
  [5.255]→[5.555:615](∅→∅)
  − target->entries[i].variant = (uint8_t)bincode_getu32(bc);
  [5.255]

  [5.305]
  + target->entries[i].variant = (u8)bincode_getu32(bc);
• replacement in change.c at line 111
  [5.769]→[5.769:822](∅→∅)
  − pos->change.variant = (uint8_t)bincode_getu32(bc);
  [5.769]

  [5.398]
  + pos->change.variant = (u8)bincode_getu32(bc);
• replacement in change.c at line 113
  [5.417]→[5.823:881](∅→∅)
  − bc, (uint8_t *)&pos->change.bytes, pos->change.variant
  [5.417]

  [5.483]
  + bc, (u8 *)&pos->change.bytes, pos->change.variant
• replacement in change.c at line 126
  [5.1517]→[5.975:1012](∅→∅)
  − uint8_t ishash = bincode_getu8(bc);
  [5.1517]

  [5.1559]
  + u8 ishash = bincode_getu8(bc);
• replacement in change.c at line 128
  [5.1574]→[5.1013:1122](∅→∅)
  − hash->variant = (uint8_t)bincode_getu32(bc);

  − change_readhash(bc, (uint8_t *)hash->bytes, hash->variant);
  [5.1574]

  [5.1734]
  + hash->variant = (u8)bincode_getu32(bc);

  + change_readhash(bc, (u8 *)hash->bytes, hash->variant);
• replacement in change.c at line 138
  [5.2852]→[5.2013:2030](∅→∅)
  − uint8_t ishash;
  [5.2852]

  [5.2877]
  + u8 ishash;
• replacement in change.c at line 142
  [5.2080]→[5.1283:1392](∅→∅)
  − hash->variant = (uint8_t)bincode_getu32(bc);

  − change_readhash(bc, (uint8_t *)hash->bytes, hash->variant);
  [5.2080]

  [5.2460]
  + hash->variant = (u8)bincode_getu32(bc);

  + change_readhash(bc, (u8 *)hash->bytes, hash->variant);
• replacement in change.c at line 161
  [5.2916]→[5.2916:2929](∅→∅),[5.2929]→[5.454:465](∅→∅)
  − size_t len;

  − size_t i;
  [5.2916]

  [5.3192]
  + usize len;

  + usize i;
• replacement in change.c at line 192
  [5.3827]→[5.466:477](∅→∅),[5.477]→[5.59:72](∅→∅),[5.3350]→[5.59:72](∅→∅)
  − size_t i;

  − size_t len;
  [5.3827]

  [5.2307]
  + usize i;

  + usize len;
• replacement in change.c at line 206
  [5.404]→[5.0:13](∅→∅)
  − uint32_t x;
  [5.404]

  [5.13]
  + u32 x;
• replacement in change.c at line 263
  [5.3855]→[5.3607:3628](∅→∅),[5.3628]→[5.478:489](∅→∅),[5.3870]→[5.478:489](∅→∅)
  − uint64_t len, slen;

  − size_t i;
  [5.3855]

  [3.126]
  + u64 len, slen;

  + usize i;
• replacement in change.c at line 388
  [3.778]→[3.778:794](∅→∅)
  − size_t len, i;
  [3.778]

  [3.794]
  + usize len, i;
• replacement in change.c at line 515
  [5.1977]→[5.1977:1994](∅→∅)
  − static uint8_t *
  [5.1977]

  [5.1994]
  + static u8 *
• replacement in change.c at line 517
  [5.2010]→[5.2010:2091](∅→∅)
  − struct changestore *changes, struct atom *change, uint8_t *contents,

  − size_t *n
  [5.2010]

  [5.2091]
  + struct changestore *changes, struct atom *change, u8 *contents,

  + usize *n
• replacement in change.c at line 525
  [5.434]→[5.2157:2195](∅→∅),[5.2157]→[5.2157:2195](∅→∅)
  − uint8_t *buf = NULL;

  − size_t sz = 0;
  [5.434]

  [5.2195]
  + u8 *buf = NULL;

  + usize sz = 0;
• replacement in change.c at line 532
  [5.2295]→[5.2295:2334](∅→∅)
  − buf = xmalloc(sizeof(uint8_t) * sz);
  [5.2295]

  [5.2334]
  + buf = xmalloc(sizeof(u8) * sz);
• replacement in change.c at line 543
  [5.2559]→[5.2559:2605](∅→∅)
  − for (size_t i = 0; i < e->edges.len; i++) {
  [5.2559]

  [5.2605]
  + for (usize i = 0; i < e->edges.len; i++) {
• replacement in change.c at line 549
  [5.509]→[5.509:546](∅→∅)
  − size_t z = vto->end - vto->start;
  [5.509]

  [5.2953]
  + usize z = vto->end - vto->start;
• replacement in change.c at line 564
  [5.3381]→[5.3381:3417](∅→∅)
  − buf, sz + sizeof(uint8_t) * z
  [5.3381]

  [5.3417]
  + buf, sz + sizeof(u8) * z
• replacement in change.c at line 567
  [5.618]→[5.3438:3479](∅→∅),[5.3438]→[5.3438:3479](∅→∅)
  − buf = xmalloc(sizeof(uint8_t) * z);
  [5.618]

  [5.619]
  + buf = xmalloc(sizeof(u8) * z);
• replacement in change.c at line 582
  [5.4059]→[5.503:514](∅→∅),[5.64]→[5.503:514](∅→∅)
  − size_t i;
  [5.4059]

  [5.72]
  + usize i;
• replacement in change.c at line 593
  [5.399]→[5.399:430](∅→∅)
  − print_edgeflags(uint8_t flags)
  [5.399]

  [5.430]
  + print_edgeflags(u8 flags)
• replacement in change.c at line 604
  [5.3618]→[5.3618:3671](∅→∅)
  − printcontents(uint8_t *buf, size_t len, char prefix)
  [5.3618]

  [5.3671]
  + printcontents(u8 *buf, usize len, char prefix)
• replacement in change.c at line 607
  [5.3690]→[5.3690:3713](∅→∅)
  − size_t i;

  − uint8_t x;
  [5.3690]

  [5.3713]
  + usize i;

  + u8 x;
• replacement in change.c at line 628
  [5.78]→[5.78:123](∅→∅)
  − for (size_t i = 0; i < m->edges.len; i++) {
  [5.78]

  [5.123]
  + for (usize i = 0; i < m->edges.len; i++) {
• replacement in change.c at line 652
  [5.609]→[5.609:674](∅→∅)
  − struct changestore *changes, struct atom *a, uint8_t *contents,
  [5.609]

  [5.674]
  + struct changestore *changes, struct atom *a, u8 *contents,
• replacement in change.c at line 658
  [5.4149]→[5.3974:4000](∅→∅)
  − size_t n;

  − uint8_t *res;
  [5.4149]

  [5.446]
  + usize n;

  + u8 *res;
• replacement in change.c at line 698
  [5.603]→[5.603:685](∅→∅)
  − read_filemetadata(struct filemetadata *m, uint8_t *contents, size_t contents_len)
  [5.603]

  [5.685]
  + read_filemetadata(struct filemetadata *m, u8 *contents, usize contents_len)
• replacement in change.c at line 700
  [5.687]→[5.687:700](∅→∅)
  − size_t len;
  [5.687]

  [5.700]
  + usize len;
• replacement in change.c at line 719
  [3.2800]→[3.2800:2864](∅→∅)
  − struct filemetadata *m, uint8_t *contents, size_t contents_len
  [3.2800]

  [3.2864]
  + struct filemetadata *m, u8 *contents, usize contents_len
• replacement in change.c at line 722
  [3.2868]→[3.2868:2881](∅→∅)
  − size_t len;
  [3.2868]

  [3.2881]
  + usize len;
• replacement in change.c at line 759
  [5.5135]→[5.782:854](∅→∅)
  − struct changestore *changes, struct hashed *hashed, uint8_t *contents,
  [5.5135]

  [5.854]
  + struct changestore *changes, struct hashed *hashed, u8 *contents,
• replacement in change.c at line 763
  [5.308]→[5.594:605](∅→∅),[5.605]→[3.3117:3190](∅→∅)
  − size_t i;

  − void (*fn_read_filemetadata)(struct filemetadata *, uint8_t *, size_t);
  [5.308]

  [5.316]
  + usize i;

  + void (*fn_read_filemetadata)(struct filemetadata *, u8 *, usize);
• replacement in change.c at line 777
  [4.27]→[5.606:618](∅→∅),[5.601]→[5.606:618](∅→∅)
  − size_t j;
  [4.27]

  [5.610]
  + usize j;
• replacement in change.c at line 830
  [5.41]→[5.41:65](∅→∅)
  − uint64_t start, end;
  [5.41]

  [5.65]
  + u64 start, end;
• replacement in change.c at line 860
  [5.1123]→[5.1123:1147](∅→∅)
  − uint64_t start, end;
  [5.1123]

  [5.1147]
  + u64 start, end;
• replacement in change.c at line 1061
  [2.512]→[2.512:523](∅→∅)
  − size_t i;
  [2.512]

  [2.523]
  + usize i;
• replacement in change.c at line 1078
  [2.929]→[2.929:940](∅→∅)
  − size_t i;
  [2.929]

  [2.940]
  + usize i;
• replacement in change.c at line 1083
  [2.999]→[2.999:1034](∅→∅)
  − size_t newcap = store->cap << 1;
  [2.999]

  [2.1034]
  + usize newcap = store->cap << 1;
• replacement in change.c at line 1102
  [2.1324]→[2.1324:1396](∅→∅)
  − changestoreinit(struct changestore *s, size_t cap, const char *repodir)
  [2.1324]

  [2.1396]
  + changestoreinit(struct changestore *s, usize cap, const char *repodir)
• replacement in change.c at line 1113
  [2.1564]→[2.1564:1575](∅→∅)
  − size_t i;
  [2.1564]

  [2.1575]
  + usize i;
• replacement in change.c at line 1130
  [2.1845]→[2.1845:1859](∅→∅)
  − size_t i, j;
  [2.1845]

  [2.1859]
  + usize i, j;
• replacement in change.c at line 1169
  [5.8278]→[3.3545:3556](∅→∅)
  − size_t x;
  [5.8278]

  [5.8292]
  + usize x;
• replacement in change.c at line 1205
  [5.405]→[5.2909:2927](∅→∅)
  − size_t hash_len;
  [5.405]

  [5.224]
  + usize hash_len;