laumann/ani - Change 2U7P5SFQG3AVALKMPJF4WMZE6PXIXXZYOMZ3RZKILBUJ4UMFXVIAC

Change struct names "struct foo -> typedef struct Foo"

Created by laumann on October 7, 2022

2U7P5SFQG3AVALKMPJF4WMZE6PXIXXZYOMZ3RZKILBUJ4UMFXVIAC

Dependencies

In channels

main

Change contents

Replacement in vertex.h at line 20 [6.33]
B:BD[6.396] → [6.396:416]
```
struct position {};
```
[6.396]
[6.416]
```
typedef struct {
} Position;
```
Replacement in vertex.h at line 27 [6.33]
B:BD[6.539] → [6.539:555]
```
struct vertex {
```
[6.539]
[6.555]
```
typedef struct {
```
Replacement in vertex.h at line 30 [6.33]
B:BD[6.621] → [6.621:624]
```
};
```
[6.621]
[6.624]
```
} Vertex;
```
Insertion in init.c at line 4 [7.262]
[7.339]
[7.339]
```
#include "common.h"
```
Replacement in hunk.h at line 4 [6.664]
B:BD[6.704] → [6.704:735]
```
struct local {
	char *path;
};
```
[6.704]
[6.735]
```
typedef struct {
	str path;
} Local;
```
Replacement in hunk.h at line 8 [6.664]
B:BD[6.736] → [6.736:757]
```
enum basehunk_type {
```
[6.736]
[6.757]
```
typedef enum {
```
Replacement in hunk.h at line 22 [6.664]
B:BD[6.961] → [6.961:964]
```
};
```
[6.961]
[6.964]
```
} basehunktype;
```
Replacement in hunk.h at line 24 [6.664]
B:BD[6.965] → [6.965:1000]
```
struct file_move {
	char *path;
};
```
[6.965]
[6.1000]
```
typedef struct {
	str path;
} Filemove;
```
Replacement in hunk.h at line 28 [6.664]
B:BD[6.1001] → [6.1001:1015]
```
struct edit {
```
[6.1001]
[6.1015]
```
typedef struct {
```
Replacement in hunk.h at line 30 [6.664]
B:BD[6.1031] → [6.1031:1034]
```
};
```
[6.1031]
[6.1034]
```
} Edit;
```
Replacement in hunk.h at line 32 [6.664]
B:BD[6.1035] → [6.1035:1056]
```
struct replacement {
```
[6.1035]
[6.1056]
```
typedef struct {
```
Replacement in hunk.h at line 35 [6.664]
B:BD[6.1095] → [6.1095:1119]
```
	struct local local;
};
```
[6.1095]
[6.1119]
```
	Local local;
} Replacement;
```

Replacement in hunk.h at line 38 [6.664]

B:BD[6.1120] → [6.1120:1169]

struct basehunk {
	enum basehunk_type hunk_type;

[6.1120]

[6.1169]

typedef struct {
	basehunktype hunktype;

Replacement in hunk.h at line 41 [6.664]

B:BD[6.1178] → [6.1178:1263]

		struct file_move file_move;
		struct edit edit;
		struct replacement replacement;

[6.1178]

[6.1263]

		Filemove filemove;
		Edit edit;
		Replacement replacement;

Replacement in hunk.h at line 45 [6.664]
B:BD[6.1272] → [6.1272:1275]
```
};
```
[6.1272]
[6.1275]
```
} Basehunk;
```

Replacement in hunk.h at line 47 [6.664]

B:BD[6.1276] → [6.1276:1332]

const char *hunk_basehunk_type_str(enum basehunk_type);

[6.1276]

[6.1332]

const char *hunk_basehunk_type_str(basehunktype);

Insertion in hunk.c at line 3 [6.1372]
[6.1413]
[6.1413]
```
#include "common.h"
```

Replacement in hunk.c at line 8 [6.1372]

B:BD[6.1445] → [6.1445:1498]

hunk_basehunk_type_str(enum basehunk_type hunk_type)

[6.1445]

[6.1498]

hunk_basehunk_type_str(basehunktype hunk_type)

Replacement in hash.h at line 9 [8.31]
B:BD[8.131] → [8.131:145]
```
struct hash {
```
[8.131]
[8.145]
```
typedef struct {
```
Replacement in hash.h at line 12 [8.31]
B:BD[8.225] → [8.225:228]
```
};
```
[8.225]
[8.228]
```
} Hash;
```
Replacement in hash.h at line 14 [8.31]
B:BD[8.229] → [8.229:248]
```
struct hash_list {
```
[8.229]
[8.248]
```
typedef struct {
```
Replacement in hash.h at line 16 [8.31]
B:BD[8.261] → [8.261:287]
```
	struct hash *entries;
};
```
[8.261]
[8.287]
```
	Hash *entries;
} Hashlist;
```
Replacement in hash.h at line 19 [8.31]
B:BD[8.288] → [8.288:320]
```
void hash_print(struct hash *);
```
[8.288]
[8.320]
```
void hashprint(Hash *);
```
Insertion in hash.c at line 6 [8.360]
[8.421]
[8.421]
```
#include "common.h"
```
Replacement in hash.c at line 11 [8.360]
B:BD[8.445] → [8.445:475]
```
hash_print(struct hash *hash)
```
[8.445]
[8.475]
```
hashprint(Hash *hash)
```

Replacement in hash.c at line 21 [8.360]

B:BD[8.578] → [2.88:132]

		base32_encode_hash(b32hash, hash->bytes);

[8.578]

[2.132]

		base32_hashencode(b32hash, hash->bytes);

File addition: common.h (----------)

[9.1]

#ifndef ANI_COMMON_H
#define ANI_COMMON_H
typedef char * str;
/* Banned functions */
/*
 * This header lists functions that have been banned from our code base,
 * because they're too easy to misuse (and even if used correctly,
 * complicate audits). Including this header turns them into compile-time
 * errors.
 */
#define BANNED(func) sorry_##func##_is_a_banned_function
#undef strcpy
#define strcpy(x, y) BANNED(strcpy)
#undef strcat
#define strcat(x, y) BANNED(strcat)
#undef strncpy
#define strncpy(x, y, n) BANNED(strncpy)
#undef strncat
#define strncat(x, y, n) BANNED(strncat)
#undef sprintf
#undef vsprintf
#define sprintf(...) BANNED(sprintf)
#define vsprintf(...) BANNED(vsprintf)
#undef gmtime
#define gmtime(t) BANNED(gmtime)
#undef localtime
#define localtime(t) BANNED(localtime)
#undef ctime
#define ctime(t) BANNED(ctime)
#undef ctime_r
#define ctime_r(t, buf) BANNED(ctime_r)
#undef asctime
#define asctime(t) BANNED(asctime)
#undef asctime_r
#define asctime_r(t, buf) BANNED(asctime_r)
#endif

Replacement in change.h at line 15 [10.80]
B:BD[10.307] → [10.307:324]
```
struct offsets {
```
[10.307]
[10.324]
```
typedef struct {
```
Replacement in change.h at line 23 [10.80]
∅:D[11.409] → [10.634:637]
B:BD[10.634] → [10.634:637]
```
};
```
[11.409]
[10.637]
```
} Offsets;
```

Replacement in change.h at line 35 [10.80]

B:BD[10.810] → [12.0:108]

/**
 * A list of key-value collections (BTreeMap)
 */
struct authors {
	size_t len;
	struct author *map;
};

[10.810]

[12.108]

typedef struct {
	str key;
	str value;
} Authorentry;

Replacement in change.h at line 41 [10.80]
B:BD[12.169] → [12.169:185]
```
struct author {
```
[12.169]
[12.185]
```
typedef struct {
```
Replacement in change.h at line 43 [10.80]
B:BD[12.198] → [12.198:232]
```
	struct author_entry *entries;
};
```
[12.198]
[12.232]
```
	Authorentry *entries;
} Author;
```

Replacement in change.h at line 46 [10.80]

B:BD[12.233] → [12.233:284]

struct author_entry {
	char *key;
	char *value;
};

[12.233]

[12.284]

/**
 * A list of key-value collections (BTreeMap)
 */
typedef struct {
	size_t len;
	Author *map;
} Authors;

Replacement in change.h at line 54 [10.80]

∅:D[12.285] → [13.0:173]

B:BD[10.810] → [13.0:173]

B:BD[13.173] → [11.410:477]

∅:D[12.353] → [13.209:212]

∅:D[11.477] → [13.209:212]

∅:D[14.573] → [13.209:212]

B:BD[13.209] → [13.209:212]

struct change_header {
	char *message;		/* the "commit" message */
	char *description;	/* the other undescribed part of a change */
	char *timestamp;	/* yes, as a string */
	struct authors authors; /* a list of "key"="value" collections */
};

[12.285]

[13.212]

typedef struct {
	str message;	 /* the "commit" message */
	str description; /* the other undescribed part of a change */
	str timestamp;	 /* yes, as a string */
	Authors authors; /* a list of "key"="value" collections */
} Changeheader;

Replacement in change.h at line 68 [10.80]
B:BD[13.458] → [13.458:474]
```
struct hashed {
```
[13.458]
[11.478]
```
typedef struct {
```

Replacement in change.h at line 70 [10.80]

∅:D[11.542] → [13.538:568]

B:BD[13.538] → [13.538:568]

B:BD[13.568] → [11.543:659]

∅:D[11.659] → [13.661:664]

∅:D[8.817] → [13.661:664]

B:BD[13.661] → [13.661:664]

	struct change_header header;
	struct hash_list dependencies; /* array of hashes */
	struct hash_list extra_known;  /* another array of hashes */
};

[11.542]

[13.664]

	Changeheader header;
	Hashlist dependencies; /* array of hashes */
	Hashlist extraknown;   /* another array of hashes */
} Hashed;

Replacement in change.h at line 81 [10.80]
B:BD[10.959] → [10.959:1005]
```
int decode_offsets(int fd, struct offsets *);
```
[10.959]
[10.1005]
```
int decode_offsets(int fd, Offsets *);
```
Insertion in change.c at line 10 [10.1047]
[10.1192]
[14.574]
```
#include "common.h"
```
Deletion in change.c at line 18 [10.1047]
B:BD[14.618] → [6.2151:2152]
Deletion in change.c at line 38 [10.1047]
B:BD[15.3] → [15.3:15]
B:BD[15.15] → [16.0:21]
∅:D[16.21] → [15.36:78]
B:BD[15.36] → [15.36:78]
∅:D[15.78] → [17.0:3]
B:BD[18.238] → [17.0:3]
```
static void
cmd_change_usage()
{
	printf("ani change [-h] [-v] <hash>\n");
}
```

Replacement in change.c at line 49 [10.1047]

B:BD[10.1493] → [19.0:51]

change_decode_offsets(int fd, struct offsets *off)

[10.1493]

[10.1537]

change_decode_offsets(int fd, Offsets *off)

Replacement in change.c at line 53 [10.1047]
B:BD[10.1587] → [3.0:31]
```
	struct bincode_state binstat;
```
[10.1587]
[10.1603]
```
	Bincode binstat;
```

Replacement in change.c at line 156 [10.1047]

B:BD[20.6] → [20.6:86]

change_decode_hashlist(struct bincode_state *binstat, struct hash_list *target)

[20.6]

[20.86]

change_decode_hashlist(Bincode *binstat, Hashlist *target)

Replacement in change.c at line 163 [10.1047]

B:BD[20.162] → [20.162:217]

	target->entries = xmalloc(sizeof(struct hash) * len);

[20.162]

[18.1067]

	target->entries = xmalloc(sizeof(Hash) * len);

Replacement in change.c at line 184 [10.1047]

B:BD[6.2257] → [6.2257:2311]

change_decode_position(struct bincode_state *binstat)

[6.2257]

[6.2311]

change_decode_position(Bincode *binstat)

Replacement in change.c at line 186 [10.1047]

B:BD[6.2313] → [6.2313:2380]

	uint64_t change_position; /* FIXME this should be its own type */

[6.2313]

[6.2380]

	uint64_t changepos; /* FIXME this should be its own type */

Replacement in change.c at line 189 [10.1047]
B:BD[6.2412] → [6.2412:2432]
```
		struct hash hash;
```
[6.2412]
[6.2432]
```
		Hash hash;
```
Replacement in change.c at line 202 [10.1047]
B:BD[6.2670] → [6.2670:2691]
```
		hash_print(&hash);
```
[6.2670]
[6.2691]
```
		hashprint(&hash);
```

Replacement in change.c at line 204 [10.1047]

B:BD[6.2694] → [6.2694:2789]

	change_position = bincode_getu64(binstat);
	printf("ChangePosition(%lu)\n", change_position);

[6.2694]

[6.2789]

	changepos = bincode_getu64(binstat);
	printf("ChangePosition(%lu)\n", changepos);

Replacement in change.c at line 209 [10.1047]

B:BD[6.2797] → [6.2797:2850]

change_decode_newedge(struct bincode_state *binstat)

[6.2797]

[6.2850]

change_decode_newedge(Bincode *binstat)

Replacement in change.c at line 226 [10.1047]
B:BD[6.3269] → [6.3269:3319]
```
change_decode_atom(struct bincode_state *binstat)
```
[6.3269]
[6.3319]
```
change_decode_atom(Bincode *binstat)
```
Replacement in change.c at line 255 [10.1047]
B:BD[6.3802] → [6.3802:3853]
```
change_decode_hunks(struct bincode_state *binstat)
```
[6.3802]
[6.3853]
```
change_decode_hunks(Bincode *binstat)
```

Replacement in change.c at line 262 [10.1047]

B:BD[6.3940] → [6.3940:3998]

		enum basehunk_type hunk_type = bincode_getu32(binstat);

[6.3940]

[6.3998]

		basehunktype hunk_type = bincode_getu32(binstat);

Replacement in change.c at line 293 [10.1047]
B:BD[11.1059] → [4.0:47]
```
	uint8_t *expected_hash, struct hashed *hashed
```
[11.1059]
[11.1083]
```
	uint8_t *expected_hash, Hashed *hashed
```
Replacement in change.c at line 302 [10.1047]
B:BD[14.648] → [21.0:31]
```
	struct bincode_state binstat;
```
[14.648]
[22.2591]
```
	Bincode binstat;
```

Replacement in change.c at line 358 [10.1047]

B:BD[4.358] → [4.358:426]

	hashed->header.authors.map = xmalloc(sizeof(struct author) * len);

[4.358]

[12.513]

	hashed->header.authors.map = xmalloc(sizeof(Author) * len);

Replacement in change.c at line 364 [10.1047]
∅:D[4.522] → [11.1290:1331]
B:BD[11.1290] → [11.1290:1331]
```
			xmalloc(sizeof(struct author) * len);
```
[4.522]
[4.523]
```
			xmalloc(sizeof(Author) * len);
```

Replacement in change.c at line 380 [10.1047]

B:BD[8.1575] → [4.790:847]

	change_decode_hashlist(&binstat, &hashed->extra_known);

[8.1575]

[23.226]

	change_decode_hashlist(&binstat, &hashed->extraknown);

Replacement in change.c at line 410 [10.1047]
B:BD[18.1722] → [18.1722:1772]
```
change_read_contents(int fd, struct offsets *off)
```
[18.1722]
[18.1772]
```
change_read_contents(int fd, Offsets *off)
```
Replacement in change.c at line 426 [10.1047]
∅:D[24.121] → [10.2233:2254]
B:BD[10.2233] → [10.2233:2254]
```
	struct offsets off;
```
[24.121]
[22.2600]
```
	Offsets off;
```
Replacement in change.c at line 432 [10.1047]
B:BD[11.2126] → [4.895:918]
```
	struct hashed hashed;
```
[11.2126]
[10.2254]
```
	Hashed hashed;
```
Replacement in change.c at line 447 [10.1047]
B:BD[10.2474] → [13.1430:1472]
```
	base32_decode_hash(contents_hash, hash);
```
[10.2474]
[10.2474]
```
	base32_hashdecode(contents_hash, hash);
```

Replacement in change.c at line 493 [10.1047]

B:BD[4.2072] → [4.2072:2119]

		hash_print(&hashed.dependencies.entries[i]);

[4.2072]

[4.2119]

		hashprint(&hashed.dependencies.entries[i]);

Replacement in change.c at line 495 [10.1047]

B:BD[4.2122] → [4.2122:2170]

	for (i = 0; i < hashed.extra_known.len; i++) {

[4.2122]

[4.2170]

	for (i = 0; i < hashed.extraknown.len; i++) {

Replacement in change.c at line 497 [10.1047]

B:BD[4.2185] → [4.2185:2231]

		hash_print(&hashed.extra_known.entries[i]);

[4.2185]

[4.2231]

		hashprint(&hashed.extraknown.entries[i]);

Insertion in change.c at line 517 [10.1047]

[10.2996]

}
static void
cmd_change_usage()
{
	printf("ani change [-h] [-v] <hash>\n");

Replacement in bincode.h at line 20 [14.1676]
B:BD[14.1998] → [21.786:809]
```
struct bincode_state {
```
[14.1998]
[11.2365]
```
typedef struct {
```
Replacement in bincode.h at line 23 [14.1676]
B:BD[21.867] → [21.867:870]
```
};
```
[21.867]
[14.1998]
```
} Bincode;
```

Replacement in bincode.h at line 31 [14.1676]

B:BD[14.2156] → [21.871:1065]

uint8_t bincode_getu8(struct bincode_state *);
uint16_t bincode_getu16(struct bincode_state *);
uint32_t bincode_getu32(struct bincode_state *);
uint64_t bincode_getu64(struct bincode_state *);

[14.2156]

[14.2264]

uint8_t bincode_getu8(Bincode *);
uint16_t bincode_getu16(Bincode *);
uint32_t bincode_getu32(Bincode *);
uint64_t bincode_getu64(Bincode *);

Replacement in bincode.h at line 44 [14.1676]

B:BD[14.2502] → [21.1066:1120]

B:BD[21.1120] → [6.4819:4885]

char *bincode_getstr(struct bincode_state *, size_t);
void bincode_getbytes(struct bincode_state *, uint8_t *, size_t);

[14.2502]

[14.2543]

char *bincode_getstr(Bincode *, size_t);
void bincode_getbytes(Bincode *, uint8_t *, size_t);

Insertion in bincode.c at line 5 [14.2731]
[14.2812]
[14.2812]
```
#include "common.h"
```
Replacement in bincode.c at line 11 [14.2731]
B:BD[21.1130] → [21.1130:1169]
```
bincode_getu8(struct bincode_state *s)
```
[21.1130]
[21.1169]
```
bincode_getu8(Bincode *s)
```
Replacement in bincode.c at line 23 [14.2731]
B:BD[14.2866] → [21.1252:1292]
```
bincode_getu16(struct bincode_state *s)
```
[14.2866]
[14.2893]
```
bincode_getu16(Bincode *s)
```
Replacement in bincode.c at line 37 [14.2731]
B:BD[14.2953] → [21.1339:1379]
```
bincode_getu32(struct bincode_state *s)
```
[14.2953]
[14.2980]
```
bincode_getu32(Bincode *s)
```
Replacement in bincode.c at line 52 [14.2731]
B:BD[14.3092] → [21.1426:1466]
```
bincode_getu64(struct bincode_state *s)
```
[14.3092]
[14.3119]
```
bincode_getu64(Bincode *s)
```
Replacement in bincode.c at line 69 [14.2731]
B:BD[14.3329] → [21.1513:1565]
```
bincode_getstr(struct bincode_state *s, size_t len)
```
[14.3329]
[14.3368]
```
bincode_getstr(Bincode *s, size_t len)
```

Replacement in bincode.c at line 85 [14.2731]

B:BD[6.4891] → [6.4891:4960]

bincode_getbytes(struct bincode_state *s, uint8_t *dest, size_t len)

[6.4891]

[25.430]

bincode_getbytes(Bincode *s, uint8_t *dest, size_t len)

Replacement in base32.h at line 10 [13.1604]

B:BD[13.1831] → [13.1831:1886]

void base32_decode_hash(uint8_t *dst, char const *in);

[13.1831]

[2.266]

void base32_hashdecode(uint8_t *dst, char const *in);

Replacement in base32.h at line 12 [13.1604]

B:BD[2.267] → [2.267:322]

void base32_encode_hash(char *dst, uint8_t const *in);

[2.267]

[13.1886]

void base32_hashencode(char *dst, uint8_t const *in);

Insertion in base32.c at line 2 [13.1928]
[13.1949]
[2.323]
```
#include "common.h"
```

Replacement in base32.c at line 49 [13.1928]

B:BD[13.3080] → [13.3080:3129]

base32_decode_hash(uint8_t *dst, char const *in)

[13.3080]

[13.3129]

base32_hashdecode(uint8_t *dst, char const *in)

Replacement in base32.c at line 88 [13.1928]

B:BD[2.983] → [2.983:1034]

base32_encode_hash(char *dst, uint8_t const *hash)

[2.983]

[2.1034]

base32_hashencode(char *dst, uint8_t const *hash)

Replacement in atom.h at line 10 [6.5021]
B:BD[6.5201] → [6.5201:5218]
```
enum atom_type {
```
[6.5201]
[6.5218]
```
typedef enum {
```
Replacement in atom.h at line 13 [6.5021]
B:BD[6.5241] → [6.5241:5244]
```
};
```
[6.5241]
[6.5244]
```
} atomtype;
```

Replacement in atom.h at line 15 [6.5021]

B:BD[6.5245] → [6.5245:5342]

struct new_vertex {
	struct hash up_context; /* FIXME Option<Hash> */
	struct hash down_context;

[6.5245]

[6.5342]

typedef struct {
	Hash upcontext; /* FIXME Option<Hash> */
	Hash downcontext;

Replacement in atom.h at line 22 [6.5021]
B:BD[6.5530] → [6.5530:5533]
```
};
```
[6.5530]
[6.5533]
```
} Newvertex;
typedef struct {
} Edgemap;
```
Replacement in atom.h at line 28 [6.5021]
B:BD[6.5548] → [6.5548:5575]
```
	enum atom_type atom_type;
```
[6.5548]
[6.5575]
```
	atomtype atomtype;
```
Replacement in atom.h at line 30 [6.5021]
B:BD[6.5584] → [6.5584:5616]
```
		struct new_vertex new_vertex;
```
[6.5584]
[6.5616]
```
		Newvertex newvertex;
		Edgemap edgemap;
```
Insertion in ani.c at line 4 [26.30]
[7.1130]
[7.1130]
```
#include "common.h"
```
Replacement in ani.c at line 17 [26.30]
∅:D[10.3226] → [7.1173:1186]
B:BD[26.174] → [7.1173:1186]
```
struct cmd {
```
[10.3226]
[7.1186]
```
typedef struct {
```
Replacement in ani.c at line 20 [26.30]
B:BD[7.1237] → [7.1237:1240]
```
};
```
[7.1237]
[7.1240]
```
} Cmd;
```
Replacement in ani.c at line 22 [26.30]
B:BD[7.1241] → [7.1241:1274]
```
static struct cmd commands[] = {
```
[7.1241]
[7.1274]
```
static Cmd commands[] = {
```
Replacement in ani.c at line 37 [26.30]
B:BD[7.1354] → [7.1354:1374]
```
static struct cmd *
```
[7.1354]
[7.1374]
```
static Cmd *
```
Replacement in ani.c at line 41 [26.30]
B:BD[7.1408] → [7.1408:1424]
```
	struct cmd *p;
```
[7.1408]
[7.1424]
```
	Cmd *p;
```
Replacement in ani.c at line 54 [26.30]
∅:D[27.350] → [7.1606:1628]
B:BD[7.1606] → [7.1606:1628]
```
	struct cmd *command;
```
[27.350]
[7.1628]
```
	Cmd *command;
```

Insertion in README.md at line 34 [29.31]

[5.327]

[28.0]


### Header files
Simple rule: include files should never include include files (see
[pikestyle][pikestyle]). Instead they state (in comments or implicitly)
what files they need to have included first, the problem of deciding which
files to include is pushed to the user. (vendored header files are exempted
from this rule to make it easier to update a vendored dependency.)

Replacement in README.md at line 43 [29.31]

B:BD[28.1] → [5.328:346]

### Include files

[28.1]

[30.278]

In addition, system include files should be grouped first before any user
include files, and the first user include file _must_ be common.h. All .c
files in this project _must_ include common.h As an example, this is the
correct way to include files:
    #include <stdlib.h>
    #include <stdint.h>
    #include <stdio.h>

Replacement in README.md at line 52 [29.31]

B:BD[30.279] → [30.279:505]

Simple rule: include files should never include include files.  Instead they
state (in comments or implicitly) what files they need to have included first,
the problem of deciding which files to include is pushed to the user.

[30.279]

[30.505]

    #include "common.h"
    #include "atom.h"
Prefer to leave a blank line in between the system includes and user includes.
### Type declarations

Replacement in README.md at line 59 [29.31]

B:BD[30.506] → [5.347:423]

[ the above is listed straight from pikestyle, see [pikestyle][pikestyle] ]

[30.506]

[30.571]

Structs are the only types that should be declared with a capital
letter. Simple types should be declared with lowercase letters.

Change struct names "struct foo -> typedef struct Foo"

Dependencies

In channels

Change contents

Replacement in vertex.h at line 20 [6.33]

Replacement in vertex.h at line 27 [6.33]

Replacement in vertex.h at line 30 [6.33]

Insertion in init.c at line 4 [7.262]

Replacement in hunk.h at line 4 [6.664]

Replacement in hunk.h at line 8 [6.664]

Replacement in hunk.h at line 22 [6.664]

Replacement in hunk.h at line 24 [6.664]

Replacement in hunk.h at line 28 [6.664]

Replacement in hunk.h at line 30 [6.664]

Replacement in hunk.h at line 32 [6.664]

Replacement in hunk.h at line 35 [6.664]

Replacement in hunk.h at line 38 [6.664]

Replacement in hunk.h at line 41 [6.664]

Replacement in hunk.h at line 45 [6.664]

Replacement in hunk.h at line 47 [6.664]

Insertion in hunk.c at line 3 [6.1372]

Replacement in hunk.c at line 8 [6.1372]

Replacement in hash.h at line 9 [8.31]

Replacement in hash.h at line 12 [8.31]

Replacement in hash.h at line 14 [8.31]

Replacement in hash.h at line 16 [8.31]

Replacement in hash.h at line 19 [8.31]

Insertion in hash.c at line 6 [8.360]

Replacement in hash.c at line 11 [8.360]

Replacement in hash.c at line 21 [8.360]

File addition: common.h (----------)

Replacement in change.h at line 15 [10.80]

Replacement in change.h at line 23 [10.80]

Replacement in change.h at line 35 [10.80]

Replacement in change.h at line 41 [10.80]

Replacement in change.h at line 43 [10.80]

Replacement in change.h at line 46 [10.80]

Replacement in change.h at line 54 [10.80]

Replacement in change.h at line 68 [10.80]

Replacement in change.h at line 70 [10.80]

Replacement in change.h at line 81 [10.80]

Insertion in change.c at line 10 [10.1047]

Deletion in change.c at line 18 [10.1047]

Deletion in change.c at line 38 [10.1047]

Replacement in change.c at line 49 [10.1047]

Replacement in change.c at line 53 [10.1047]

Replacement in change.c at line 156 [10.1047]

Replacement in change.c at line 163 [10.1047]

Replacement in change.c at line 184 [10.1047]

Replacement in change.c at line 186 [10.1047]

Replacement in change.c at line 189 [10.1047]

Replacement in change.c at line 202 [10.1047]

Replacement in change.c at line 204 [10.1047]

Replacement in change.c at line 209 [10.1047]

Replacement in change.c at line 226 [10.1047]

Replacement in change.c at line 255 [10.1047]

Replacement in change.c at line 262 [10.1047]

Replacement in change.c at line 293 [10.1047]

Replacement in change.c at line 302 [10.1047]

Replacement in change.c at line 358 [10.1047]

Replacement in change.c at line 364 [10.1047]

Replacement in change.c at line 380 [10.1047]

Replacement in change.c at line 410 [10.1047]

Replacement in change.c at line 426 [10.1047]

Replacement in change.c at line 432 [10.1047]

Replacement in change.c at line 447 [10.1047]

Replacement in change.c at line 493 [10.1047]

Replacement in change.c at line 495 [10.1047]

Replacement in change.c at line 497 [10.1047]

Insertion in change.c at line 517 [10.1047]

Replacement in bincode.h at line 20 [14.1676]

Replacement in bincode.h at line 23 [14.1676]

Replacement in bincode.h at line 31 [14.1676]

Replacement in bincode.h at line 44 [14.1676]

Insertion in bincode.c at line 5 [14.2731]

Replacement in bincode.c at line 11 [14.2731]

Replacement in bincode.c at line 23 [14.2731]

Replacement in bincode.c at line 37 [14.2731]

Replacement in bincode.c at line 52 [14.2731]

Replacement in bincode.c at line 69 [14.2731]