laumann/ani - Change U3JWO63YYQDCJX7CWXCS3N26CHY2TASADTCQIEDSJ7WC25GLZD5QC

change: deduplicate some code repetition

In no fewer than four places the same switch statement was used to figure out what kind of hash to read from the bincode input.

Created by laumann on May 12, 2023

U3JWO63YYQDCJX7CWXCS3N26CHY2TASADTCQIEDSJ7WC25GLZD5QC

Dependencies

In channels

main

Change contents

Insertion in change.c at line 151 [5.1047]

[3.2591]

[4.1065]

}
static void
change_readhash(Bincode *binstat, uint8_t *dest, uint8_t variant)
{
	switch (variant) {
	case HASH_BLAKE3:
		bincode_getbytes(binstat, dest, BLAKE3_BYTES);
		break;
	case HASH_NONE:
		/* Do nothing - no bytes to consume */
		break;
	default:
		die("unknown hash variant: %u", variant);
	}

Replacement in change.c at line 180 [5.1047]

∅:D[2.129] → [6.311:371]

B:BD[6.311] → [6.311:371]

B:BD[6.371] → [7.989:1068]

∅:D[7.1068] → [6.514:583]

B:BD[6.514] → [6.514:583]

B:BD[6.583] → [8.2209:2246]

		switch (target->entries[i].variant) {
		case HASH_BLAKE3:
			bincode_getbytes(
				binstat, target->entries[i].bytes, BLAKE3_BYTES
			);
			break;
		case HASH_NONE:
			/* Do nothing, no bytes to consume */
			break;
		default:
			abort();
		}

[2.129]

[8.2246]

		change_readhash(
			binstat, target->entries[i].bytes,
			target->entries[i].variant
		);

Replacement in change.c at line 192 [5.1047]

B:BD[7.1196] → [7.1196:1347]

∅:D[7.1347] → [8.2509:2537]

B:BD[8.2509] → [8.2509:2537]

B:BD[8.2537] → [7.1348:1375]

		switch (pos->change.variant) {
		case HASH_BLAKE3:
			bincode_getbytes(
				binstat, (uint8_t *)&pos->change.bytes,
				BLAKE3_BYTES
			);
			break;
		case HASH_NONE:
			break;
		default:
			abort();
		}

[7.1196]

[7.1375]

		change_readhash(
			binstat, (uint8_t *)&pos->change.bytes,
			pos->change.variant
		);

Replacement in change.c at line 210 [5.1047]
B:BD[7.1626] → [7.1626:1653]
∅:D[7.1653] → [8.2537:2578]
B:BD[8.2537] → [8.2537:2578]
B:BD[8.2578] → [7.1654:1704]
∅:D[7.1704] → [8.2627:2643]
B:BD[8.2627] → [8.2627:2643]
B:BD[8.2643] → [7.1705:1733]
∅:D[7.1733] → [8.2643:2670]
B:BD[8.2643] → [8.2643:2670]
```
		switch (hash->variant) {
		case HASH_BLAKE3:
			bincode_getbytes(
				binstat, (uint8_t *)hash->bytes, BLAKE3_BYTES
			);
			break;
		case HASH_NONE:
			break;
		default:
			abort();
		}
```
[7.1626]
[7.1734]
```
		change_readhash(binstat, (uint8_t *)hash->bytes, hash->variant);
```

Replacement in change.c at line 224 [5.1047]

B:BD[7.2132] → [7.2132:2321]

		switch (hash->variant) {
		case HASH_BLAKE3:
			bincode_getbytes(
				binstat, (uint8_t *)hash->bytes, BLAKE3_BYTES
			);
			break;
		case HASH_NONE:
			break;
		default:
			abort();
		}

[7.2132]

[7.2460]

		change_readhash(binstat, (uint8_t *)hash->bytes, hash->variant);

Insertion in change.c at line 227 [5.1047]
[7.2465]
[7.2465]