{"header":{"message":"Turning a panic into an error when making a patch","description":null,"timestamp":"2023-07-04T10:41:29.538460717Z","authors":[{}]},"hash":"FMLTNQ4EYXA54OGII5AX2G2I7YFDVNMTOM7GDDTCKBTWGZPABH2AC","authors":[{"login":"pmeunier","key":"FZQ2g7VfnzLYM4mtTVDk9HAZjA8Jk9ndkwN1icgbtWUr"}],"deps":{"hashes":[["FMLTNQ4EYXA54OGII5AX2G2I7YFDVNMTOM7GDDTCKBTWGZPABH2AC","Turning a panic into an error when making a patch"],["AA",null],["ZDK3GNDBWXJ2OXFDYB72ZCEBGLBF4MKE5K3PVHDZATHJ7HJIDPRQC","Tag transactions (including a massive refactoring of errors)"],["VO5OQW4W2656DIYYRNZ3PO7TQ4JOKQ3GVWE5ALUTYVMX3WMXJOYQC","Removing anyhow in libpijul"],["I52XSRUH5RVHQBFWVMAQPTUSPAJ4KNVID2RMI3UGCVKFLYUO6WZAC","Massive cleanup, and simplification"],["GHO6DWPILBBTL6CVZKERJBTFL3EY6ZT4YM4E5R4S6YPGVFKFHCVAC","Refactoring iterators"],["SMMBFECLGSUKRZW5YPOQPOQCOY2CH2OTZXBSZ3KG2N3J3HQZ5PSAC","Converting to the new patch format \"online\""],["FXEDPLRI7PXLDXV634ZA6D5Q3ZWG3ESTKJTMRPJ4MAHI7PKU3M6AC","Resurrecting tests, and type cleanup (no need for Arc> anymore)"],["UNZXTNSJI4YRY3EQ3M4HMBKQDNYDTY6B7IZRBNYGDJXTA2UKYWRAC","Change text format: order dependencies in the order they were on the channel at record time"],["NUAOEIXMKZO5KQWQ3TLQWO3RIXBPJU4QOPW7MGCV3ITDAUHFEK5QC","Adding inode and byte to Local"],["UN2M77YUIQZMPH5CQARPUUK2Q66RHN5J6BIIQQFEJ35DSFSKFFPQC","Test new changes against the old code. Fix several small bugs."],["SXEYMYF7P4RZMZ46WPL4IZUTSQ2ATBWYZX7QNVMS3SGOYXYOHAGQC","Fixing the bad changes in history (unfortunately, by rebooting)."],["5FI6SBEZ6RERERUAIWQJVAY66BEZ7YQOYOUNK2DPOLRGS2X326RAC","Re-implement change printing and parsing"],["CCLLB7OIFNFYJZTG3UCI7536TOCWSCSXR67VELSB466R24WLJSDAC","Upgrading to Sanakirja 0.15 + version bump"],["CCFJ7VO3I73FE3MZRS5RSDRYNZVW7AXC345P4BXS7JIL2TU3LQJQC","Renaming \"Record\" to \"Hunk\" in the changes"],["YN63NUZO4LVJ7XPMURDULTXBVJKW5MVCTZ24R7Z52QMHO3HPDUVQC","Sanakirja 1.0"],["I24UEJQLCH2SOXA4UHIYWTRDCHSOPU7AFTRUOTX7HZIAV4AZKYEQC","Various post-fire fixes"],["A3RM526Y7LUXNYW4TL56YKQ5GVOK2R5D7JJVTSQ6TT5MEXIR6YAAC","Integrating identity malleability"],["73NW2X2MI767RYNTKS67ZB5QUWYEAA4SCORLD52K36ZU3JAK67AQC","Returning a parse error instead of panicking when parsing a text change"]],"deps":["ZDK3GNDBWXJ2OXFDYB72ZCEBGLBF4MKE5K3PVHDZATHJ7HJIDPRQC"],"known":["SXEYMYF7P4RZMZ46WPL4IZUTSQ2ATBWYZX7QNVMS3SGOYXYOHAGQC","UNZXTNSJI4YRY3EQ3M4HMBKQDNYDTY6B7IZRBNYGDJXTA2UKYWRAC","I52XSRUH5RVHQBFWVMAQPTUSPAJ4KNVID2RMI3UGCVKFLYUO6WZAC","VO5OQW4W2656DIYYRNZ3PO7TQ4JOKQ3GVWE5ALUTYVMX3WMXJOYQC","CCLLB7OIFNFYJZTG3UCI7536TOCWSCSXR67VELSB466R24WLJSDAC","GHO6DWPILBBTL6CVZKERJBTFL3EY6ZT4YM4E5R4S6YPGVFKFHCVAC","CCFJ7VO3I73FE3MZRS5RSDRYNZVW7AXC345P4BXS7JIL2TU3LQJQC","YN63NUZO4LVJ7XPMURDULTXBVJKW5MVCTZ24R7Z52QMHO3HPDUVQC","I24UEJQLCH2SOXA4UHIYWTRDCHSOPU7AFTRUOTX7HZIAV4AZKYEQC","SMMBFECLGSUKRZW5YPOQPOQCOY2CH2OTZXBSZ3KG2N3J3HQZ5PSAC","FXEDPLRI7PXLDXV634ZA6D5Q3ZWG3ESTKJTMRPJ4MAHI7PKU3M6AC","NUAOEIXMKZO5KQWQ3TLQWO3RIXBPJU4QOPW7MGCV3ITDAUHFEK5QC","5FI6SBEZ6RERERUAIWQJVAY66BEZ7YQOYOUNK2DPOLRGS2X326RAC","UN2M77YUIQZMPH5CQARPUUK2Q66RHN5J6BIIQQFEJ35DSFSKFFPQC"]},"hunks":[{"Replacement":{"inode":{"change":3,"pos":488880},"path":"libpijul/src/record.rs","line":1379,"ins":{"up_context":[{"change":3,"pos":615}],"down_context":[{"change":3,"pos":646}],"flag":"BLOCK","start":0,"end":43,"inode":{"change":3,"pos":488880}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":615},"to":{"change":3,"start":615,"end":646},"introduced_by":3}],"inode":{"change":3,"pos":488880}},"ins_contents":[{"Add":" crate::change::MakeChangeError,"}],"del_contents":[{"Del":" TxnErr,\n"}]}},{"Replacement":{"inode":{"change":3,"pos":831311},"path":"libpijul/src/change.rs","line":211,"ins":{"up_context":[{"change":3,"pos":835985}],"down_context":[{"change":3,"pos":836025}],"flag":"BLOCK","start":44,"end":102,"inode":{"change":3,"pos":831311}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":835985},"to":{"change":3,"start":117887,"end":117947},"introduced_by":3}],"inode":{"change":3,"pos":831311}},"ins_contents":[{"Add":") -> Result<(Vec, Vec), MakeChangeError> {"}],"del_contents":[{"Del":") -> Result<(Vec, Vec), TxnErr> {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":831311},"path":"libpijul/src/change.rs","line":292,"ins":{"up_context":[{"change":3,"pos":838412}],"down_context":[{"change":3,"pos":838416}],"flag":"BLOCK","start":103,"end":141,"inode":{"change":3,"pos":831311}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":838412},"to":{"change":3,"start":119096,"end":119137},"introduced_by":3}],"inode":{"change":3,"pos":831311}},"ins_contents":[{"Add":") -> Result<(), MakeChangeError> {"}],"del_contents":[{"Del":") -> Result<(), TxnErr> {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":831311},"path":"libpijul/src/change.rs","line":301,"ins":{"up_context":[{"change":3,"pos":838610}],"down_context":[{"change":3,"pos":138571}],"flag":"BLOCK","start":142,"end":297,"inode":{"change":3,"pos":831311}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":838610},"to":{"change":3,"start":64147,"end":64208},"introduced_by":3}],"inode":{"change":3,"pos":831311}},"ins_contents":[{"Add":" let from = if let Ok(from) = txn.find_block_end(channel, e_from) {"},{"Add":" from"},{"Add":" } else {"},{"Add":" return Err(MakeChangeError::InvalidChange)"},{"Add":" };"}],"del_contents":[{"Del":" let from = txn.find_block_end(channel, e_from).unwrap();\n"}]}},{"Replacement":{"inode":{"change":3,"pos":831311},"path":"libpijul/src/change.rs","line":331,"ins":{"up_context":[{"change":3,"pos":839310}],"down_context":[{"change":3,"pos":839314}],"flag":"BLOCK","start":298,"end":336,"inode":{"change":3,"pos":831311}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":839310},"to":{"change":3,"start":119501,"end":119542},"introduced_by":3}],"inode":{"change":3,"pos":831311}},"ins_contents":[{"Add":") -> Result<(), MakeChangeError> {"}],"del_contents":[{"Del":") -> Result<(), TxnErr> {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":831311},"path":"libpijul/src/change.rs","line":340,"ins":{"up_context":[{"change":3,"pos":839506}],"down_context":[{"change":3,"pos":839565}],"flag":"BLOCK","start":337,"end":486,"inode":{"change":3,"pos":831311}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":839506},"to":{"change":3,"start":64209,"end":64268},"introduced_by":3}],"inode":{"change":3,"pos":831311}},"ins_contents":[{"Add":" let mut to = if let Ok(to) = txn.find_block(channel, to_pos) {"},{"Add":" to"},{"Add":" } else {"},{"Add":" return Err(MakeChangeError::InvalidChange)"},{"Add":" };"}],"del_contents":[{"Del":" let mut to = txn.find_block(channel, to_pos).unwrap();\n"}]}},{"Edit":{"inode":{"change":3,"pos":831311},"path":"libpijul/src/change.rs","line":1319,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":867084}],"down_context":[{"change":18,"pos":41299}],"flag":"BLOCK","start":487,"end":1013,"inode":{"change":3,"pos":831311}}},"contents":[{"Add":"#[derive(Error)]"},{"Add":"pub enum MakeChangeError {"},{"Add":" #[error(transparent)]"},{"Add":" Graph(#[from] TxnErr<::GraphError>),"},{"Add":" #[error(\"Invalid change\")]"},{"Add":" InvalidChange,"},{"Add":"}"},{"Add":""},{"Add":"impl std::fmt::Debug for MakeChangeError {"},{"Add":" fn fmt(&self, fmt: &mut std::fmt::Formatter) -> std::fmt::Result {"},{"Add":" match self {"},{"Add":" MakeChangeError::Graph(e) => std::fmt::Debug::fmt(e, fmt),"},{"Add":" MakeChangeError::InvalidChange => std::fmt::Debug::fmt(\"InvalidChange\", fmt),"},{"Add":" }"},{"Add":" }"},{"Add":"}"},{"Add":""}]}},{"Replacement":{"inode":{"change":3,"pos":831311},"path":"libpijul/src/change.rs","line":1346,"ins":{"up_context":[{"change":3,"pos":867387}],"down_context":[{"change":3,"pos":105473}],"flag":"BLOCK","start":1014,"end":1058,"inode":{"change":3,"pos":831311}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":867387},"to":{"change":3,"start":122599,"end":122645},"introduced_by":3}],"inode":{"change":3,"pos":831311}},"ins_contents":[{"Add":" ) -> Result> {"}],"del_contents":[{"Del":" ) -> Result> {\n"}]}},{"Edit":{"inode":{"change":3,"pos":37976},"path":"libpijul/src/change/text_changes.rs","line":22,"atom":{"NewVertex":{"up_context":[{"change":19,"pos":127}],"down_context":[{"change":3,"pos":38343}],"flag":"BLOCK","start":1059,"end":1255,"inode":{"change":3,"pos":37976}}},"contents":[{"Add":"}"},{"Add":""},{"Add":"#[derive(Debug, Error)]"},{"Add":"pub enum TextDeErrorDeps {"},{"Add":" #[error(transparent)]"},{"Add":" TextDe(#[from] TextDeError),"},{"Add":" #[error(transparent)]"},{"Add":" MakeChange(#[from]MakeChangeError),"}]}},{"Replacement":{"inode":{"change":3,"pos":37976},"path":"libpijul/src/change/text_changes.rs","line":200,"ins":{"up_context":[{"change":3,"pos":43075}],"down_context":[{"change":3,"pos":59017}],"flag":"BLOCK","start":1256,"end":1300,"inode":{"change":3,"pos":37976}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":43075},"to":{"change":3,"start":43075,"end":43112},"introduced_by":3}],"inode":{"change":3,"pos":37976}},"ins_contents":[{"Add":" ) -> Result> {"}],"del_contents":[{"Del":" ) -> Result {\n"}]}},{"Replacement":{"inode":{"change":3,"pos":37976},"path":"libpijul/src/change/text_changes.rs","line":203,"ins":{"up_context":[{"change":3,"pos":122944}],"down_context":[{"change":3,"pos":43278}],"flag":"BLOCK","start":1301,"end":1380,"inode":{"change":3,"pos":37976}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":122944},"to":{"change":3,"start":105569,"end":105656},"introduced_by":3}],"inode":{"change":3,"pos":37976}},"ins_contents":[{"Add":" dependencies(txn, &channel.read(), change.hashed.changes.iter())?;"}],"del_contents":[{"Del":" dependencies(txn, &channel.read(), change.hashed.changes.iter()).unwrap();\n"}]}},{"Edit":{"inode":{"change":3,"pos":944089},"path":"libpijul/src/apply.rs","line":17,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":36928}],"down_context":[{"change":2,"pos":36928}],"flag":"BLOCK","start":1381,"end":1432,"inode":{"change":3,"pos":944089}}},"contents":[{"Add":" MakeChange(crate::change::MakeChangeError),"}]}},{"Edit":{"inode":{"change":3,"pos":944089},"path":"libpijul/src/apply.rs","line":25,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":37258}],"down_context":[{"change":2,"pos":37258}],"flag":"BLOCK","start":1433,"end":1504,"inode":{"change":3,"pos":944089}}},"contents":[{"Add":" ApplyError::MakeChange(e) => std::fmt::Debug::fmt(e, fmt),"}]}},{"Edit":{"inode":{"change":3,"pos":944089},"path":"libpijul/src/apply.rs","line":35,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":37610}],"down_context":[{"change":2,"pos":37610}],"flag":"BLOCK","start":1505,"end":1578,"inode":{"change":3,"pos":944089}}},"contents":[{"Add":" ApplyError::MakeChange(e) => std::fmt::Display::fmt(e, fmt),"}]}},{"Edit":{"inode":{"change":3,"pos":944089},"path":"libpijul/src/apply.rs","line":94,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":123882}],"down_context":[{"change":2,"pos":39642}],"flag":"BLOCK","start":1579,"end":1805,"inode":{"change":3,"pos":944089}}},"contents":[{"Add":"impl From>"},{"Add":" for ApplyError"},{"Add":"{"},{"Add":" fn from(err: crate::change::MakeChangeError) -> Self {"},{"Add":" ApplyError::MakeChange(err)"},{"Add":" }"},{"Add":"}"},{"Add":""}]}}],"owner":"laumann","repo":"pijul","token":"Ar+Ot/KPtivH8orn8xXIoQVHZ3xSNX2qmwa68EqXKoc=","login":null}

…

Dependencies

Change contents