laumann/pijul - Change QNJBR73KCSCCF6FTHGZDF2K7PZQL3EFKZFOBT77KYZBMALTTW6OQC

don't return Result for infallible functions

Created by danieleades on December 5, 2020

QNJBR73KCSCCF6FTHGZDF2K7PZQL3EFKZFOBT77KYZBMALTTW6OQC

Dependencies

In channels

main

Change contents

Replacement in libpijul/src/pristine/mod.rs at line 325 [3.586748]

B:BD[2.39007] → [2.39007:39237]

    Ok(Position {
        change: if let Some(p) = pos.change {
            if let Some(p) = txn.get_internal(p) {
                p
            } else {
                return Err(crate::Error::InconsistentChange);
            }

[2.39007]

[2.39237]

    let change = if let Some(p) = pos.change {
        if let Some(p) = txn.get_internal(p) {
            p

Replacement in libpijul/src/pristine/mod.rs at line 329 [3.586748]

B:BD[2.39254] → [2.39254:39287]

            change_id
        },

[2.39254]

[2.39287]

            return Err(crate::Error::InconsistentChange);
        }
    } else {
        change_id
    };
    Ok(Position {
        change,

Replacement in libpijul/src/diff/replace.rs at line 37 [3.779907]
B:BD[3.781057] → [3.781057:781094]
```
    ) -> Result<(), anyhow::Error> {
```
[3.781057]
[3.781094]
```
    ) {
```
Replacement in libpijul/src/diff/replace.rs at line 80 [3.779907]
B:BD[3.782557] → [3.782557:782596]
```
                        return Ok(());
```
[3.782557]
[3.782596]
```
                        return;
```
Deletion in libpijul/src/diff/replace.rs at line 96 [3.779907]
B:BD[3.783039] → [3.783039:783054]
```
        Ok(())
```
Replacement in libpijul/src/diff/mod.rs at line 111 [3.793247]
B:BD[3.797108] → [3.797108:797127]
```
                )?
```
[3.797108]
[3.797127]
```
                );
```

Replacement in libpijul/src/diff/mod.rs at line 114 [3.793247]

B:BD[3.797176] → [3.797176:797262]

                self.replace(&d, &mut conflict_contexts, &lines_a, &lines_b, &dd, r)?

[3.797176]

[3.797262]

                self.replace(&d, &mut conflict_contexts, &lines_a, &lines_b, &dd, r);

Replacement in libpijul/src/diff/delete.rs at line 21 [3.805350]
B:BD[3.805988] → [3.805988:806025]
```
    ) -> Result<(), anyhow::Error> {
```
[3.805988]
[3.806025]
```
    ) {
```
Deletion in libpijul/src/diff/delete.rs at line 37 [3.805350]
B:BD[3.806419] → [3.806419:806434]
```
        Ok(())
```

don't return Result for infallible functions

Dependencies

In channels

Change contents

Replacement in libpijul/src/pristine/mod.rs at line 325 [3.586748]

Replacement in libpijul/src/pristine/mod.rs at line 329 [3.586748]

Replacement in libpijul/src/diff/replace.rs at line 37 [3.779907]

Replacement in libpijul/src/diff/replace.rs at line 80 [3.779907]

Deletion in libpijul/src/diff/replace.rs at line 96 [3.779907]

Replacement in libpijul/src/diff/mod.rs at line 111 [3.793247]

Replacement in libpijul/src/diff/mod.rs at line 114 [3.793247]

Replacement in libpijul/src/diff/delete.rs at line 21 [3.805350]

Deletion in libpijul/src/diff/delete.rs at line 37 [3.805350]