Refusing to parse patches to binary files converted to text format, as there is no way to make sense of them

pmeunier

Feb 24, 2023, 3:58 PM

FVN4TICG4UKBMKUHCZ2KOLQYPEJZGBEN3KLDP6LOMD2MGQERT5HAC

Dependencies

• [2] 5FI6SBEZ Re-implement change printing and parsing
• [3] 5NHRJ5PY Cleaner handling of binary changes in the text format
• [4] T4VEIGHR change parsing accounts for editors which trim trailing whitespace
• [5] YQMLICLW Fix the hunk_roundtrip test, simplify code, improve test coverage, fix some edge cases.

Change contents

• replacement in libpijul/src/change/parse.rs at line 362
  [2.74358]→[2.74358:74511](∅→∅)
  − let (i, res) = fold_many0(

  − complete(|i| parse_content_line(leading_char, i)),

  − String::new,

  − |s, r| s + r.as_str(),

  − )(i)?;
  [2.74358]

  [2.74511]
  + let (i, res) = if leading_char == '+' {

  + fold_many1(

  + complete(|i| parse_content_line(leading_char, i)),

  + String::new,

  + |s, r| s + r.as_str(),

  + )(i)?

  + } else {

  + fold_many0(

  + complete(|i| parse_content_line(leading_char, i)),

  + String::new,

  + |s, r| s + r.as_str(),

  + )(i)?

  + };