fix libpijul tests, and an unnecessary clone

fogti

Aug 4, 2021, 8:05 PM

MCAUAMZZBW4VURDFPLOIYTRRYXCXUWP5BD3TO3OEVK4WBD2HBLUAC

Dependencies

• [2] FXEDPLRI Resurrecting tests, and type cleanup (no need for Arc<RwLock<…>> anymore)
• [3] IUH7IMWE Contributor license agreements
• [4] CCLLB7OI Upgrading to Sanakirja 0.15 + version bump
• [5] IIV3EL2X Cleanup, formatting, and fixing the Git feature
• [6] 7UPL3Y2A Unrecord: don't restore the same unrecorded file deletion twice in the inodes and tree tables
• [7] 6YMDOZIB Refactoring apply
• [8] EEBKW7VT Keys and identities
• [9] Q45QHPO4 Feedback on network stuff
• [10] I24UEJQL Various post-fire fixes
• [11] YN63NUZO Sanakirja 1.0
• [12] TIPZ7UXN Started fixing the tests for parallel record/output
• [13] I52XSRUH Massive cleanup, and simplification
• [14] SHSJ3Y53 Fixing more tests
• [15] SXEYMYF7 Fixing the bad changes in history (unfortunately, by rebooting).
• [16] A3RM526Y Integrating identity malleability
• [17] GHO6DWPI Refactoring iterators

Change contents

• replacement in libpijul/src/tests/unrecord.rs at line 179
  [4.254881]→[4.254881:254916](∅→∅)
  − repo.remove_path("file")?;
  [4.254881]

  [4.254916]
  + repo.remove_path("file", false)?;
• replacement in libpijul/src/tests/unrecord.rs at line 238
  [4.257170]→[4.257170:257205](∅→∅)
  − repo.remove_path("file")?;
  [4.257170]

  [4.257205]
  + repo.remove_path("file", false)?;
• replacement in libpijul/src/tests/unrecord.rs at line 313
  [4.259956]→[4.259956:259990](∅→∅)
  − repo.remove_path("a/b/c/d")?;
  [4.259956]

  [2.5732]
  + repo.remove_path("a/b/c/d", false)?;
• replacement in libpijul/src/tests/unrecord.rs at line 316
  [4.260073]→[4.260073:260103](∅→∅)
  − repo.remove_path("a/b")?;
  [4.260073]

  [2.5810]
  + repo.remove_path("a/b", true)?;
• replacement in libpijul/src/tests/unrecord.rs at line 435
  [4.264240]→[4.264240:264271](∅→∅)
  − repo.remove_path("file")?;
  [4.264240]

  [2.7732]
  + repo.remove_path("file", false)?;
• replacement in libpijul/src/tests/unrecord.rs at line 581
  [4.269046]→[4.269046:269080](∅→∅)
  − repo.remove_path("file")?
  [4.269046]

  [4.269080]
  + repo.remove_path("file", false)?
• replacement in libpijul/src/tests/unrecord.rs at line 795
  [4.1226]→[4.1226:1257](∅→∅)
  − repo.remove_path("file")?;
  [4.1226]

  [2.11714]
  + repo.remove_path("file", false)?;
• replacement in libpijul/src/tests/rm_file.rs at line 41
  [4.277524]→[4.277524:277560](∅→∅)
  − repo_bob.remove_path("a/b/c")?;
  [4.277524]

  [4.277560]
  + repo_bob.remove_path("a/b/c", true)?;
• replacement in libpijul/src/tests/missing_context.rs at line 70
  [4.293696]→[4.293696:293737](∅→∅)
  − repo_alice.remove_path("file")?;
  [4.293696]

  [4.293737]
  + repo_alice.remove_path("file", false)?;
• replacement in libpijul/src/tests/filesystem.rs at line 35
  [4.301560]→[4.301560:301629](∅→∅)
  − repo.remove_path("dir/file.old")?;

  − repo.remove_path("dir")?;
  [4.301560]

  [4.301629]
  + repo.remove_path("dir/file.old", false)?;

  + repo.remove_path("dir", true)?;
• replacement in libpijul/src/tests/filesystem.rs at line 74
  [4.302890]→[4.302890:302959](∅→∅)
  − repo.remove_path("dir/file.old")?;

  − repo.remove_path("dir")?;
  [4.302890]

  [4.302959]
  + repo.remove_path("dir/file.old", false)?;

  + repo.remove_path("dir", true)?;
• replacement in libpijul/src/tests/file_conflicts.rs at line 433
  [4.319071]→[4.319071:319125](∅→∅)
  − repo_alice.remove_path(&files_alice[1]).unwrap();
  [4.319071]

  [2.33720]
  + repo_alice.remove_path(&files_alice[1], false).unwrap();
• replacement in libpijul/src/tests/file_conflicts.rs at line 453
  [4.319849]→[4.319849:319899](∅→∅)
  − repo_bob.remove_path(&files_bob[1]).unwrap();
  [4.319849]

  [4.319899]
  + repo_bob.remove_path(&files_bob[1], false).unwrap();
• replacement in libpijul/src/tests/file_conflicts.rs at line 497
  [4.321497]→[4.321497:321533](∅→∅)
  − repo_alice.remove_path("a/b")?;
  [4.321497]

  [2.34764]
  + repo_alice.remove_path("a/b", true)?;
• replacement in libpijul/src/tests/file_conflicts.rs at line 609
  [4.325363]→[4.325363:325399](∅→∅)
  − repo_alice.remove_path("a/b")?;
  [4.325363]

  [4.325399]
  + repo_alice.remove_path("a/b", true)?;
• replacement in libpijul/src/tests/file_conflicts.rs at line 646
  [4.326598]→[4.326598:326717](∅→∅)
  − // repo_alice.remove_path("a/b/c/file").unwrap_or(());

  − // repo_alice.remove_path("a/b/c/file2").unwrap_or(());
  [4.326598]

  [4.326717]
  + // repo_alice.remove_path("a/b/c/file", false).unwrap_or(());

  + // repo_alice.remove_path("a/b/c/file2", false).unwrap_or(());
• replacement in libpijul/src/tests/file_conflicts.rs at line 734
  [4.329422]→[4.329422:329458](∅→∅)
  − repo_alice.remove_path("a/b")?;
  [4.329422]

  [4.329458]
  + repo_alice.remove_path("a/b", true)?;
• replacement in libpijul/src/tests/file_conflicts.rs at line 877
  [4.334292]→[4.334292:334328](∅→∅)
  − repo_alice.remove_path("a/b")?;
  [4.334292]

  [2.39866]
  + repo_alice.remove_path("a/b", true)?;
• replacement in libpijul/src/tests/file_conflicts.rs at line 1057
  [4.340873]→[4.340873:340914](∅→∅)
  − repo_bob.remove_path("a/b/c/file")?;
  [4.340873]

  [2.43117]
  + repo_bob.remove_path("a/b/c/file", false)?;
• replacement in libpijul/src/tests/file_conflicts.rs at line 1137
  [4.343405]→[4.343405:343451](∅→∅)
  − repo_charlie.remove_path("a/b/c/alice")?;
  [4.343405]

  [2.44211]
  + repo_charlie.remove_path("a/b/c/alice", false)?;
• replacement in libpijul/src/tests/file_conflicts.rs at line 1248
  [4.347311]→[4.347311:347359](∅→∅)
  − repo_bob.remove_path("file").unwrap_or(());
  [4.347311]

  [2.45806]
  + repo_bob.remove_path("file", false).unwrap_or(());
• replacement in libpijul/src/tests/file_conflicts.rs at line 1276
  [4.348258]→[4.348258:348303](∅→∅)
  − repo_bob.remove_path("bob").unwrap()
  [4.348258]

  [4.348303]
  + repo_bob.remove_path("bob", false).unwrap()
• replacement in libpijul/src/tests/file_conflicts.rs at line 1278
  [4.348316]→[4.348316:348363](∅→∅)
  − repo_bob.remove_path("alice").unwrap()
  [4.348316]

  [4.348363]
  + repo_bob.remove_path("alice", false).unwrap()
• replacement in libpijul/src/tests/file_conflicts.rs at line 1387
  [4.14459]→[4.351912:351960](∅→∅),[4.21487]→[4.351912:351960](∅→∅),[2.47568]→[4.351912:351960](∅→∅),[4.351912]→[4.351912:351960](∅→∅)
  − repo_bob.remove_path("file").unwrap_or(());
  [2.47568]

  [2.47569]
  + repo_bob.remove_path("file", false).unwrap_or(());
• replacement in libpijul/src/tests/file_conflicts.rs at line 1479
  [4.354912]→[4.354912:354959](∅→∅)
  − repo_bob.remove_path("dir").unwrap_or(());
  [4.354912]

  [2.48947]
  + repo_bob.remove_path("dir", true).unwrap_or(());
• replacement in libpijul/src/tests/conflict.rs at line 2580
  [2.80889]→[4.439761:439793](∅→∅),[4.439761]→[4.439761:439793](∅→∅)
  − repo_bob.remove_path("a")?;
  [2.80889]

  [2.80890]
  + repo_bob.remove_path("a", true)?;
• replacement in libpijul/src/tests/change.rs at line 120
  [4.451008]→[4.451008:451040](∅→∅)
  − repo.remove_path("file2")?;
  [4.451008]

  [2.84477]
  + repo.remove_path("file2", false)?;
• replacement in libpijul/src/tests/add_file.rs at line 116
  [4.458037]→[4.43936:43983](∅→∅)
  − repo.remove_path("dir/file").unwrap();
  [4.458037]

  [2.86491]
  + repo.remove_path("dir/file", false).unwrap();
• replacement in libpijul/src/tests/add_file.rs at line 173
  [4.3723]→[4.3723:3755](∅→∅)
  − repo.remove_path("a/b/c")?;
  [4.3723]

  [4.3755]
  + repo.remove_path("a/b/c", true)?;
• replacement in libpijul/src/tests/add_file.rs at line 328
  [4.464952]→[4.464952:464994](∅→∅)
  − repo_alice.remove_path("dir/file2")?;
  [4.464952]

  [4.464994]
  + repo_alice.remove_path("dir/file2", false)?;
• replacement in libpijul/src/tests/add_file.rs at line 456
  [4.469234]→[4.469234:469266](∅→∅)
  − repo_bob.remove_path("a")?;
  [4.469234]

  [2.92166]
  + repo_bob.remove_path("a", false)?;
• replacement in libpijul/src/tests/add_file.rs at line 629
  [4.474584]→[4.474584:474620](∅→∅)
  − repo_alice.remove_path("dir")?;
  [4.474584]

  [2.93866]
  + repo_alice.remove_path("dir", true)?;
• replacement in libpijul/src/tests/add_file.rs at line 657
  [4.36726]→[4.475391:475428](∅→∅),[4.475391]→[4.475391:475428](∅→∅)
  − repo_alice.remove_path("dir2")?;
  [4.36726]

  [4.475428]
  + repo_alice.remove_path("dir2", true)?;
• replacement in libpijul/src/tests/add_file.rs at line 742
  [4.477555]→[4.477555:477597](∅→∅)
  − repo.remove_path("filedir").unwrap();
  [4.477555]

  [4.477597]
  + repo.remove_path("filedir", true).unwrap();
• replacement in libpijul/src/key.rs at line 152
  [4.9733]→[4.38618:38703](∅→∅)
  − key: bs58::encode(&key.public.clone().to_bytes()).into_string(),
  [4.9733]

  [4.38703]
  + key: bs58::encode(key.public.as_bytes()).into_string(),