nuttycom/aftok - Change BWN72T44GRRZ6K2OPN56FTLNEB7J7AGC7T2U5HSMLEKUPGJP2NUAC

Don't accept work timestamp from an external source.

Created by Kris Nuttycombe on October 19, 2016

BWN72T44GRRZ6K2OPN56FTLNEB7J7AGC7T2U5HSMLEKUPGJP2NUAC

Dependencies

In channels

main

Change contents

Insertion in lib/Aftok/Json.hs at line 17 [5.19]
[3.790]
[4.3094]
```
import           Data.Thyme.Clock                 as C
```

Replacement in lib/Aftok/Json.hs at line 250 [5.19]

B:BD[3.4290] → [2.540:664]

parseLogEvent :: Object -> Parser LogEvent
parseLogEvent x = 
  (StartWork <$> x .: "start") <|> (StopWork <$> x .: "stop")

[3.4290]

[2.664]

parseLogEntry :: Value -> Parser (C.UTCTime -> LogEntry)
parseLogEntry = unversion parseLogEntry' where 
  parseLogEntry' (Version 2 0) (Object x) = do
    creditTo'  <- x .: "creditTo" >>= parseCreditTo
    eventCtr   <- x .: "eventType" >>= nameEvent
    eventMeta' <- x .: "eventMeta"
    pure $ \t -> LogEntry creditTo' (eventCtr t) eventMeta'

Deletion in lib/Aftok/Json.hs at line 258 [5.19]

B:BD[2.665] → [2.665:938]

parseLogEntry :: Value -> Parser LogEntry
parseLogEntry = unversion parseLogEntry' where 
  parseLogEntry' (Version 2 0) (Object x) =
    LogEntry <$> (x .: "creditTo" >>= parseCreditTo)
             <*> (x .: "event" >>= parseLogEvent)
             <*> (x .: "eventMeta")

Replacement in server/Aftok/Snaplet/WorkLog.hs at line 47 [6.5424]

B:BD[2.1598] → [2.1598:1687]

    Right entry -> snapEval $ createEvent pid uid (event.eventTime .~ timestamp $ entry)

[2.1598]

[6.6347]

    Right entry -> snapEval $ createEvent pid uid (entry timestamp)