nuttycom/aftok - Change FXJQACESPGTLPG5ELXBU3M3OQXUZQQIR7HPIEHQ3FNUTMWVH4WBAC

Ensure that auction is not ended at the time of bid

Created by Kris Nuttycombe on May 18, 2016

FXJQACESPGTLPG5ELXBU3M3OQXUZQQIR7HPIEHQ3FNUTMWVH4WBAC

Dependencies

In channels

main

Change contents

Replacement in lib/Aftok/Database.hs at line 51 [5.4936]

B:BD[3.7075] → [4.4782:4842]

  RaiseDBError     :: forall x. DBError -> DBOp x -> DBOp x

[3.7075]

[3.7204]

  RaiseDBError     :: forall x y. DBError -> DBOp x -> DBOp y

Insertion in lib/Aftok/Database.hs at line 57 [5.4936]
[4.4937]
[4.4937]
```
                       | AuctionEnded
```
Replacement in lib/Aftok/Database.hs at line 69 [5.4936]
B:BD[4.5275] → [4.5275:5316]
```
raiseSubjectNotFound :: DBOp x -> DBOp x
```
[4.5275]
[6.480]
```
raiseSubjectNotFound :: DBOp y -> DBOp x
```
Replacement in lib/Aftok/Database.hs at line 172 [5.4936]
B:BD[7.851] → [7.851:883]
```
  let findAuc = FindAuction aid
```
[7.851]
[7.883]
```
  let findOp = FindAuction aid
```

Replacement in lib/Aftok/Database.hs at line 174 [5.4936]

B:BD[7.892] → [7.892:1006]

    maybeAuc <- fc findAuc
    _ <- traverse (\auc -> checkProjectAuth (auc ^. A.projectId) uid findAuc) maybeAuc

[7.892]

[7.1006]

    maybeAuc <- fc findOp
    _ <- traverse (\auc -> checkProjectAuth (auc ^. A.projectId) uid findOp) maybeAuc

Insertion in lib/Aftok/Database.hs at line 177 [5.4936]

[7.1024]

[2.21]


findAuction' :: AuctionId -> UserId -> DBProg Auction
findAuction' aid uid = 
  let findOp = FindAuction aid
  in  do
    maybeAuc <- fc findOp
    _ <- traverse (\auc -> checkProjectAuth (auc ^. A.projectId) uid findOp) maybeAuc
    maybe (fc $ raiseSubjectNotFound findOp) pure maybeAuc

Replacement in lib/Aftok/Database.hs at line 187 [5.4936]
B:BD[2.80] → [2.80:141]
```
createBid aid uid bid = do
  maybeAuc <- findAuction aid uid
```
[2.80]
[2.141]
```
createBid aid uid bid = 
```

Replacement in lib/Aftok/Database.hs at line 189 [5.4936]

B:BD[2.176] → [2.176:247]

  fc $ maybe (raiseSubjectNotFound createOp) (const createOp) maybeAuc

[2.176]

  in  do
    auc <- findAuction' aid uid
    fc $ if view bidTime bid > view auctionEnd auc 
      then raiseOpForbidden uid AuctionEnded createOp
      else createOp

Insertion in server/Aftok/Snaplet/Auctions.hs at line 68 [8.2441]
[2.1576]
```
    
```

Ensure that auction is not ended at the time of bid

Dependencies

In channels

Change contents

Replacement in lib/Aftok/Database.hs at line 51 [5.4936]

Insertion in lib/Aftok/Database.hs at line 57 [5.4936]

Replacement in lib/Aftok/Database.hs at line 69 [5.4936]

Replacement in lib/Aftok/Database.hs at line 172 [5.4936]

Replacement in lib/Aftok/Database.hs at line 174 [5.4936]

Insertion in lib/Aftok/Database.hs at line 177 [5.4936]

Replacement in lib/Aftok/Database.hs at line 187 [5.4936]

Replacement in lib/Aftok/Database.hs at line 189 [5.4936]

Insertion in server/Aftok/Snaplet/Auctions.hs at line 68 [8.2441]