#1 Investigating what happened to this repository

Opened by pmeunier on January 24, 2021
pmeunier on January 24, 2021

Hi! This isn’t really a bug report for zhur, but rather for Pijul. There’s no need for you to do anything, but I just wanted to apologise, and I wanted you to be aware that I’m investigating the issue right now.

One of the patches from this repository (specifically hunk 124 in patch 5MSYGDDYLVQ…) is bad, and causes some of the invariants in Pijul to break.

There are two causes for this:

  • The patch displayer/parser seems to have a bug with replacements of lines not ending in \n (which are always the last line of the file).
  • The core algorithm in Pijul doesn’t check for that particular sort of bug. But since it breaks everything, I’ll add it now.

This is my top priority, starting today, and until it’s fixed. I’ll try my best to produce a backwards-compatible solution, so you don’t have to record those patches again.

oreganoli on January 24, 2021

Cool, don’t sweat it. I have local backups anyway.

pmeunier on January 27, 2021

Hi! I finally fixed this today in Libpijul. I tried my best to achieve backwards compatibility, but since you had a few changes depending on the offending one (5MSY…), this wasn’t possible. Here is how to fix it:

  • Install the latest Pijul, either from this repository, or simply with cargo install pijul --version "~1.0.0-alpha". This will download the latest libpijul with the fix. The version of Pijul didn’t change.

  • I’ve reset your repository on the Nest to the last state that worked, so you can just clone it. I have backups of your invalid changes if you need them.

  • After the clone, delete all the files and directories except .pijul, copy your files over to the new repository, and record again.

  • Push to this repository.

Sorry again