{"header":{"message":"Keeping patches that have a review","description":null,"timestamp":"2026-07-29T10:44:33.472172522Z","authors":[{}]},"hash":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC","authors":[{"login":"pmeunier","key":"AAAAC3NzaC1lZDI1NTE5AAAAILagOJFgwaMNhBWQINinKOXmqS4Gh5NgxgriXwdOoINJ"}],"deps":{"hashes":[["72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC","Keeping patches that have a review"],["AA",null],["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","Initial patch"],["3UYOLOBPKKDEBN4VX4GZT2KXVH3WJF3SBTWZADD2SQW4463KDKBAC","Rollback failed CI/CD jobs, and allow CI-only channels"],["IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC","Replacing approvals with 'different pusher and author'"],["OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC","Grandfathering: marking existing history as ok when switching to a strict review policy"],["AH4IBU3TU6SQEJHUA3RNI2RFXZSSIC4NAWX72WVS6X3LLG5LQMXAC","New approval system"],["AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","Redesign (fat change)"],["PCR2LDLTK6XVSBXJL6IMGQP7GSE5UNFCT6WRM2H5EPQ2AZWFRCFAC","update + CI"]],"deps":["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","3UYOLOBPKKDEBN4VX4GZT2KXVH3WJF3SBTWZADD2SQW4463KDKBAC","IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC"],"known":["PCR2LDLTK6XVSBXJL6IMGQP7GSE5UNFCT6WRM2H5EPQ2AZWFRCFAC","AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","AH4IBU3TU6SQEJHUA3RNI2RFXZSSIC4NAWX72WVS6X3LLG5LQMXAC","OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC"]},"hunks":[{"Replacement":{"inode":{"change":2,"pos":319304},"path":"api/src/ssh.rs","line":1401,"ins":{"up_context":[{"change":4,"pos":14290}],"down_context":[{"change":4,"pos":14634}],"flag":"BLOCK","start":0,"end":666,"inode":{"change":2,"pos":319304}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":14290},"to":{"change":4,"start":14290,"end":14634},"introduced_by":4}],"inode":{"change":2,"pos":319304}},"ins_contents":[{"Add":{"text":" let reviewers: Vec<(Option, Option>)> =","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:97"}},{"Add":{"text":" rc::review_comments","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:137"}},{"Add":{"text":" .filter(rc::repository_id.eq(id.repo_id))","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:203"}},{"Add":{"text":" .filter(rc::change.eq(hash.to_base32()))","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:268"}},{"Add":{"text":" .select((rc::author, rc::grandfathered_at))","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:336"}},{"Add":{"text":" .load(&mut self.db.get().await?)","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:393"}},{"Add":{"text":" .await?;","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:426"}},{"Add":{"text":" // A grandfathered \"review all\" vouches for pre-existing history","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:507"}},{"Add":{"text":" // and satisfies the policy regardless of authorship.","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:577"}},{"Add":{"text":" let grandfathered = reviewers.iter().any(|(_, gf_at)| gf_at.is_some());","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:665"}}],"del_contents":[{"Del":{"text":" let reviewers: Vec> = rc::review_comments","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:14366"}},{"Del":{"text":" .filter(rc::repository_id.eq(id.repo_id))","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:14428"}},{"Del":{"text":" .filter(rc::change.eq(hash.to_base32()))","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:14489"}},{"Del":{"text":" .select(rc::author)","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:14529"}},{"Del":{"text":" .load::>(&mut self.db.get().await?)","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:14604"}},{"Del":{"text":" .await?;","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:14633"}}]}},{"Replacement":{"inode":{"change":2,"pos":319304},"path":"api/src/ssh.rs","line":1413,"ins":{"up_context":[{"change":4,"pos":14729}],"down_context":[{"change":4,"pos":14760}],"flag":"BLOCK","start":667,"end":711,"inode":{"change":2,"pos":319304}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":14729},"to":{"change":4,"start":14729,"end":14760},"introduced_by":4}],"inode":{"change":2,"pos":319304}},"ins_contents":[{"Add":{"text":" .filter_map(|(a, _)| a)","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:710"}}],"del_contents":[{"Del":{"text":" .flatten()","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:14759"}}]}},{"Replacement":{"inode":{"change":2,"pos":319304},"path":"api/src/ssh.rs","line":1416,"ins":{"up_context":[{"change":4,"pos":14849}],"down_context":[{"change":4,"pos":14899}],"flag":"BLOCK","start":712,"end":780,"inode":{"change":2,"pos":319304}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":14849},"to":{"change":4,"start":14849,"end":14899},"introduced_by":4}],"inode":{"change":2,"pos":319304}},"ins_contents":[{"Add":{"text":" if !grandfathered && distinct.len() < min_reviews {","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:779"}}],"del_contents":[{"Del":{"text":" if distinct.len() < min_reviews {","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:14898"}}]}},{"Replacement":{"inode":{"change":2,"pos":431834},"path":"api/src/replication.rs","line":248,"ins":{"up_context":[{"change":2,"pos":438039}],"down_context":[{"change":2,"pos":438082}],"flag":"BLOCK","start":781,"end":1144,"inode":{"change":2,"pos":431834}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":438039},"to":{"change":2,"start":438039,"end":438082},"introduced_by":2}],"inode":{"change":2,"pos":431834}},"ins_contents":[{"Add":{"text":" // Orphaned in no channel — safe to prune, UNLESS the","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:860"}},{"Add":{"text":" // change has been reviewed, in which case it must be","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:938"}},{"Add":{"text":" // retained so the review isn't left pointing at a","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1013"}},{"Add":{"text":" // deleted file.","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1054"}},{"Add":{"text":" Ok(Ok(false)) if !hash_has_review(&s.db, repo, &hash).await => {","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1143"}}],"del_contents":[{"Del":{"text":" Ok(Ok(false)) => {","pos":"D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC:438081"}}]}},{"Edit":{"inode":{"change":2,"pos":431834},"path":"api/src/replication.rs","line":650,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":11307}],"down_context":[{"change":3,"pos":11307}],"flag":"BLOCK","start":1145,"end":1922,"inode":{"change":2,"pos":431834}}},"contents":[{"Add":{"text":"","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1145"}},{"Add":{"text":"/// Whether the change `hash` carries at least one review within the origin","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1221"}},{"Add":{"text":"/// family — the origin repo `origin` itself or any fork of it, which is exactly","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1304"}},{"Add":{"text":"/// the set that shares the per-origin changestore. Such a change must survive","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1383"}},{"Add":{"text":"/// unrecord GC, otherwise its reviews would point at a deleted file. Fails safe:","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1465"}},{"Add":{"text":"/// if the check can't be run, we report `true` (keep the file) rather than risk","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1546"}},{"Add":{"text":"/// destroying a reviewed patch.","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1579"}},{"Add":{"text":"async fn hash_has_review(","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1605"}},{"Add":{"text":" db: &crate::config::Db,","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1633"}},{"Add":{"text":" origin: uuid::Uuid,","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1657"}},{"Add":{"text":" hash: &pijul_core::Hash,","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1686"}},{"Add":{"text":") -> bool {","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1698"}},{"Add":{"text":" use crate::db::repositories::dsl as r;","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1741"}},{"Add":{"text":" use crate::db::review_comments::dsl as rc;","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1788"}},{"Add":{"text":" use diesel::{BoolExpressionMethods, ExpressionMethods, QueryDsl};","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1858"}},{"Add":{"text":" use diesel_async::RunQueryDsl;","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1893"}},{"Add":{"text":" use pijul_core::Base32;","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1921"}}]}},{"Edit":{"inode":{"change":2,"pos":431834},"path":"api/src/replication.rs","line":668,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":11308}],"down_context":[{"change":3,"pos":11308}],"flag":"BLOCK","start":1923,"end":2361,"inode":{"change":2,"pos":431834}}},"contents":[{"Add":{"text":" let hash_b32 = hash.to_base32();","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:1959"}},{"Add":{"text":" let mut conn = match db.get().await {","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2001"}},{"Add":{"text":" Ok(c) => c,","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2021"}},{"Add":{"text":" Err(_) => return true,","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2052"}},{"Add":{"text":" };","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2059"}},{"Add":{"text":" diesel::select(diesel::dsl::exists(","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2099"}},{"Add":{"text":" rc::review_comments","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2127"}},{"Add":{"text":" .inner_join(r::repositories)","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2168"}},{"Add":{"text":" .filter(rc::change.eq(&hash_b32))","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2214"}},{"Add":{"text":" .filter(r::id.eq(origin).or(r::fork_origin.eq(origin))),","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2283"}},{"Add":{"text":" ))","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2290"}},{"Add":{"text":" .get_result::(&mut conn)","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2325"}},{"Add":{"text":" .await","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2336"}},{"Add":{"text":" .unwrap_or(true)","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2357"}},{"Add":{"text":"}","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2359"}},{"Add":{"text":"","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2360"}}]}},{"Replacement":{"inode":{"change":2,"pos":431834},"path":"api/src/replication.rs","line":786,"ins":{"up_context":[{"change":3,"pos":15624}],"down_context":[{"change":3,"pos":15687}],"flag":"BLOCK","start":2362,"end":2427,"inode":{"change":2,"pos":431834}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":15624},"to":{"change":3,"start":15624,"end":15687},"introduced_by":3}],"inode":{"change":2,"pos":431834}},"ins_contents":[{"Add":{"text":" let mut conn = db.get().await.map_err(|_| Error::Join)?;","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2426"}}],"del_contents":[{"Del":{"text":" let mut db = db.get().await.map_err(|_| Error::Join)?;","pos":"3UYOLOBPKKDEBN4VX4GZT2KXVH3WJF3SBTWZADD2SQW4463KDKBAC:15686"}}]}},{"Replacement":{"inode":{"change":2,"pos":431834},"path":"api/src/replication.rs","line":798,"ins":{"up_context":[{"change":3,"pos":16106}],"down_context":[{"change":3,"pos":16141}],"flag":"BLOCK","start":2428,"end":2465,"inode":{"change":2,"pos":431834}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":16106},"to":{"change":3,"start":16106,"end":16141},"introduced_by":3}],"inode":{"change":2,"pos":431834}},"ins_contents":[{"Add":{"text":" .execute(&mut *conn)","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2464"}}],"del_contents":[{"Del":{"text":" .execute(&mut *db)","pos":"3UYOLOBPKKDEBN4VX4GZT2KXVH3WJF3SBTWZADD2SQW4463KDKBAC:16140"}}]}},{"Replacement":{"inode":{"change":2,"pos":431834},"path":"api/src/replication.rs","line":821,"ins":{"up_context":[{"change":3,"pos":16799}],"down_context":[{"change":3,"pos":16851}],"flag":"BLOCK","start":2466,"end":2520,"inode":{"change":2,"pos":431834}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":16799},"to":{"change":3,"start":16799,"end":16851},"introduced_by":3}],"inode":{"change":2,"pos":431834}},"ins_contents":[{"Add":{"text":" .get_result::(&mut *conn)","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2519"}}],"del_contents":[{"Del":{"text":" .get_result::(&mut *db)","pos":"3UYOLOBPKKDEBN4VX4GZT2KXVH3WJF3SBTWZADD2SQW4463KDKBAC:16850"}}]}},{"Replacement":{"inode":{"change":2,"pos":431834},"path":"api/src/replication.rs","line":824,"ins":{"up_context":[{"change":3,"pos":16888}],"down_context":[{"change":3,"pos":16976}],"flag":"BLOCK","start":2521,"end":2611,"inode":{"change":2,"pos":431834}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":16888},"to":{"change":3,"start":16888,"end":16976},"introduced_by":3}],"inode":{"change":2,"pos":431834}},"ins_contents":[{"Add":{"text":" crate::repository::recompute_storage(&mut *conn, &locks.config, owner_id)","pos":"72GKTFST3CQUPMMBTX2L5Q7WRDKZJW3P7IX5O7LV367IKLKZWJOAC:2610"}}],"del_contents":[{"Del":{"text":" crate::repository::recompute_storage(&mut *db, &locks.config, owner_id)","pos":"3UYOLOBPKKDEBN4VX4GZT2KXVH3WJF3SBTWZADD2SQW4463KDKBAC:16975"}}]}}],"owner":"pijul","repo":"nest","token":"aJewtcFw3onf4hbMlB4JUA0UiABy7AUP7ujkGzLzVa4=","login":null}

…

Dependencies

Change contents

Review