{"header":{"message":"make patch approval idempotent, mark landed patches","description":"On pouvait approuver le même patch autant de fois qu'on cliquait : chaque clic insérait une ligne de verdict, notifiait l'auteur et postait sur Zulip.\n\n- api: un verdict NU (sans texte) identique au verdict courant du relecteur est un no-op — changer d'avis, ou accompagner le verdict d'un commentaire, reste enregistré.\n- ui: les boutons [approve] / [request changes] sont désactivés quand le verdict est déjà en vigueur, dans les deux vues de relecture.\n- ui: dans les discussions, un patch présent sur le canal visé porte un badge « ⇑ landed on » sur sa ligne d'entête, et la fiche dit explicitement « not landed on yet » sinon.","timestamp":"2026-09-18T10:14:43.719842917Z","authors":[{}]},"hash":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC","authors":[{"login":"pmeunier","key":"AAAAC3NzaC1lZDI1NTE5AAAAILagOJFgwaMNhBWQINinKOXmqS4Gh5NgxgriXwdOoINJ"}],"deps":{"hashes":[["AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC","make patch approval idempotent, mark landed patches"],["AA",null],["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","Initial patch"],["YYJ76Q7V6G7FHSNZ25MU3ZZY5KGXIODBHLWOZUGB4FIKL7PUCNAAC","Initial attempt at CI/CD"],["AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","Redesign (fat change)"],["HY6KW56TNL5TWFPDQLZBDURE2DZSHKSBDKW53VQOR55DSEU7I7QQC","Missing files"],["KUJXFMTMOVHBULDQ7O24QUKTAZAZJT7CNQFZPMHZQSJPE52A5HDQC","Improving the review process"],["KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC","Improving the review workflow"],["KFSQE75KWAHLOYZ2OQF2ABFFGW6GVUSOFFB5ZTTJFJARCQYE4FAAC","Cosmetic changes to the review process"],["T67XALXLSMSQTWVDVRXL3J4T3BBUSUEBXBWU6ZZZTWXSPTUCT4OAC","Improve patch approvals in discussions"],["PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC","Review workflow: add author in discussion, not pusher"],["CZRBDICZTJVO72RFQL4H6ESNNABJXYNDEOIGCNZK3GJAQEA42OKQC","More review notifications"],["WWHAOKMTRIREJUHU3BFM37INTQDPSCZJ2PLPMJCLDKXBIAZSFO2AC","Show each patch's current channels in a discussion, drop the landed timeline"],["YWCAAV5ZWZRVRO2UKZCWLCLMYRPGCSNY6AFNRCZ7DPTTJVIBRFKQC","Browser notifications"],["HZHICIY3EVCJIISRCCNNVL3N3VNINPGOKXJHT47H4CSTR3DGI3IAC","update ui/src/routes/[user]/[repo]/change/[hash]/Palimpsest.svelte"],["QJ3Z4HYTZMJAAVHCJ3LRZJKS2MLUX65GQPQM7JHL7NYJDWOHPNDAC","update ui/src/routes/[user]/[repo]/change/[hash]/ReviewPanel.svelte"],["EG3MNPQXLNF62UQAP3342JC4OL47MAUCYJM6Q4G7BVVBM2VXMDCAC","Patch reviews"]],"deps":["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","YYJ76Q7V6G7FHSNZ25MU3ZZY5KGXIODBHLWOZUGB4FIKL7PUCNAAC","AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","HY6KW56TNL5TWFPDQLZBDURE2DZSHKSBDKW53VQOR55DSEU7I7QQC","KUJXFMTMOVHBULDQ7O24QUKTAZAZJT7CNQFZPMHZQSJPE52A5HDQC","KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC","KFSQE75KWAHLOYZ2OQF2ABFFGW6GVUSOFFB5ZTTJFJARCQYE4FAAC","T67XALXLSMSQTWVDVRXL3J4T3BBUSUEBXBWU6ZZZTWXSPTUCT4OAC","PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC","CZRBDICZTJVO72RFQL4H6ESNNABJXYNDEOIGCNZK3GJAQEA42OKQC","WWHAOKMTRIREJUHU3BFM37INTQDPSCZJ2PLPMJCLDKXBIAZSFO2AC"],"known":["YWCAAV5ZWZRVRO2UKZCWLCLMYRPGCSNY6AFNRCZ7DPTTJVIBRFKQC","HZHICIY3EVCJIISRCCNNVL3N3VNINPGOKXJHT47H4CSTR3DGI3IAC","QJ3Z4HYTZMJAAVHCJ3LRZJKS2MLUX65GQPQM7JHL7NYJDWOHPNDAC"]},"hunks":[{"Edit":{"inode":{"change":5,"pos":5383},"path":"api/src/change/comments.rs","line":242,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":12030}],"down_context":[{"change":5,"pos":12030}],"flag":"BLOCK","start":0,"end":1140,"inode":{"change":5,"pos":5383}}},"contents":[{"Add":{"text":" // Une approbation (ou un refus) SANS texte ne dit rien de plus que le","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:74"}},{"Add":{"text":" // verdict lui-même : la reposter alors qu'elle est déjà le verdict courant","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:157"}},{"Add":{"text":" // du relecteur est un double-clic, pas une seconde relecture. On répond OK","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:238"}},{"Add":{"text":" // sans rien écrire — sinon la page empilait des « approved » identiques,","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:321"}},{"Add":{"text":" // l'auteur recevait une notification de plus et Zulip un message de plus à","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:402"}},{"Add":{"text":" // chaque clic. Changer d'avis (approve → reject) reste évidemment enregistré,","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:489"}},{"Add":{"text":" // et un verdict accompagné d'un commentaire est un vrai message : il passe.","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:571"}},{"Add":{"text":" if verdict.is_some() && contents.is_empty() {","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:621"}},{"Add":{"text":" let current: Option> = rc::review_comments","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:687"}},{"Add":{"text":" .filter(rc::repository_id.eq(id))","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:733"}},{"Add":{"text":" .filter(rc::change.eq(&p.hash))","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:777"}},{"Add":{"text":" .filter(rc::author.eq(uid))","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:817"}},{"Add":{"text":" .filter(rc::verdict.is_not_null())","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:864"}},{"Add":{"text":" .order_by(rc::creation_date.desc())","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:912"}},{"Add":{"text":" .select(rc::verdict)","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:945"}},{"Add":{"text":" .first(&mut db)","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:973"}},{"Add":{"text":" .await","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:992"}},{"Add":{"text":" .optional()?;","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1018"}},{"Add":{"text":" if current.flatten().as_deref() == verdict {","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1071"}},{"Add":{"text":" return Ok(axum::http::StatusCode::OK);","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1122"}},{"Add":{"text":" }","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1132"}},{"Add":{"text":" }","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1138"}},{"Add":{"text":"","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1139"}}]}},{"Edit":{"inode":{"change":8,"pos":306},"path":"ui/src/routes/[user]/[repo]/change/[hash]/ReviewPanel.svelte","line":10,"atom":{"NewVertex":{"up_context":[{"change":8,"pos":570}],"down_context":[{"change":8,"pos":570}],"flag":"BLOCK","start":1142,"end":1539,"inode":{"change":8,"pos":306}}},"contents":[{"Add":{"text":" // Même règle que le serveur (api/src/change/comments.rs) : reposter un","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1217"}},{"Add":{"text":" // verdict nu déjà en vigueur est un double-clic, pas une relecture. Le bouton","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1300"}},{"Add":{"text":" // le dit plutôt que de faire semblant d'agir. Avec du texte, c'est un vrai","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1379"}},{"Add":{"text":" // message : le bouton redevient actif.","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1421"}},{"Add":{"text":" let draft = $state('');","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1447"}},{"Add":{"text":" const castBare = (v: 'approve' | 'reject') => !draft.trim() && ctx.verdicts.mine === v;","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1537"}},{"Add":{"text":"","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1538"}}]}},{"Edit":{"inode":{"change":8,"pos":306},"path":"ui/src/routes/[user]/[repo]/change/[hash]/ReviewPanel.svelte","line":22,"atom":{"NewVertex":{"up_context":[{"change":8,"pos":753}],"down_context":[{"change":8,"pos":753}],"flag":"BLOCK","start":1540,"end":1560,"inode":{"change":8,"pos":306}}},"contents":[{"Add":{"text":" draft = '';","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1559"}}]}},{"Replacement":{"inode":{"change":8,"pos":306},"path":"ui/src/routes/[user]/[repo]/change/[hash]/ReviewPanel.svelte","line":83,"ins":{"up_context":[{"change":8,"pos":3248}],"down_context":[{"change":8,"pos":3409}],"flag":"BLOCK","start":1561,"end":1713,"inode":{"change":8,"pos":306}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":8,"pos":3308},"to":{"change":8,"start":3308,"end":3409},"introduced_by":8}],"inode":{"change":8,"pos":306}},"ins_contents":[{"Add":{"text":" ","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1712"}}],"del_contents":[{"Del":{"text":" ","pos":"KFSQE75KWAHLOYZ2OQF2ABFFGW6GVUSOFFB5ZTTJFJARCQYE4FAAC:3408"}}]}},{"Replacement":{"inode":{"change":8,"pos":306},"path":"ui/src/routes/[user]/[repo]/change/[hash]/ReviewPanel.svelte","line":89,"ins":{"up_context":[{"change":8,"pos":3440}],"down_context":[{"change":11,"pos":8334}],"flag":"BLOCK","start":1714,"end":1801,"inode":{"change":8,"pos":306}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":8,"pos":3440},"to":{"change":8,"start":3440,"end":3502},"introduced_by":8}],"inode":{"change":8,"pos":306}},"ins_contents":[{"Add":{"text":" ","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:1800"}}],"del_contents":[{"Del":{"text":" ","pos":"KFSQE75KWAHLOYZ2OQF2ABFFGW6GVUSOFFB5ZTTJFJARCQYE4FAAC:3501"}}]}},{"Replacement":{"inode":{"change":8,"pos":306},"path":"ui/src/routes/[user]/[repo]/change/[hash]/ReviewPanel.svelte","line":91,"ins":{"up_context":[{"change":11,"pos":8363}],"down_context":[{"change":11,"pos":8477}],"flag":"BLOCK","start":1802,"end":2138,"inode":{"change":8,"pos":306}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":8363},"to":{"change":11,"start":8363,"end":8477},"introduced_by":11}],"inode":{"change":8,"pos":306}},"ins_contents":[{"Add":{"text":" ","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:2074"}},{"Add":{"text":" {castBare('approve') ? 'Approved ✓' : 'Approve'}","pos":"AV7OZ3653NOD3UKPCQD3XUHYXI6EIR2CPZCHHBHLKWB6VJHCYNBAC:2137"}}],"del_contents":[{"Del":{"text":"

…

Dependencies

Change contents

Review