{"header":{"message":"Don't show 'needs review' if no channel requires it","description":null,"timestamp":"2026-07-29T07:46:41.785716607Z","authors":[{}]},"hash":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC","authors":[{"login":"pmeunier","key":"AAAAC3NzaC1lZDI1NTE5AAAAILagOJFgwaMNhBWQINinKOXmqS4Gh5NgxgriXwdOoINJ"}],"deps":{"hashes":[["GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC","Don't show 'needs review' if no channel requires it"],["AA",null],["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","Initial patch"],["AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","Redesign (fat change)"],["IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC","Replacing approvals with 'different pusher and author'"]],"deps":["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC"],"known":[]},"hunks":[{"Replacement":{"inode":{"change":2,"pos":95158},"path":"ui/src/routes/[user]/[repo]/change/+page.svelte","line":62,"ins":{"up_context":[{"change":3,"pos":4788821}],"down_context":[{"change":3,"pos":4788821}],"flag":"BLOCK","start":0,"end":295,"inode":{"change":2,"pos":95158}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4788821},"to":{"change":4,"start":1180,"end":1423},"introduced_by":4}],"inode":{"change":2,"pos":95158}},"ins_contents":[{"Add":{"text":" {#if data.reviews_wanted}","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:31"}},{"Add":{"text":" ","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:99"}},{"Add":{"text":" ","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:195"}},{"Add":{"text":" Only patches needing review","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:265"}},{"Add":{"text":" ","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:282"}},{"Add":{"text":" {/if}","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:294"}}],"del_contents":[{"Del":{"text":" ","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:1245"}},{"Del":{"text":" ","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:1339"}},{"Del":{"text":" Only patches needing review","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:1407"}},{"Del":{"text":" ","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:1422"}}]}},{"Edit":{"inode":{"change":2,"pos":554127},"path":"api/src/change/list.rs","line":32,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":554853}],"down_context":[{"change":2,"pos":554853}],"flag":"BLOCK","start":296,"end":523,"inode":{"change":2,"pos":554127}}},"contents":[{"Add":{"text":" /// True when at least one channel in this repo requires reviews","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:364"}},{"Add":{"text":" /// (`min_reviews > 0`). Only then are the per-patch `needs_review` flags","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:442"}},{"Add":{"text":" /// computed and the \"needs review\" filter shown.","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:496"}},{"Add":{"text":" reviews_wanted: bool,","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:522"}}]}},{"Edit":{"inode":{"change":2,"pos":554127},"path":"api/src/change/list.rs","line":88,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":555995}],"down_context":[{"change":2,"pos":555995}],"flag":"BLOCK","start":524,"end":1116,"inode":{"change":2,"pos":554127}}},"contents":[{"Add":{"text":"","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:524"}},{"Add":{"text":" // Does any channel in this repo actually require reviews? Only then do we","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:603"}},{"Add":{"text":" // bother flagging patches as needing one.","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:650"}},{"Add":{"text":" let reviews_wanted: bool = {","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:683"}},{"Add":{"text":" use crate::db::channel_settings::dsl as cs;","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:735"}},{"Add":{"text":" use diesel::ExpressionMethods as _;","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:779"}},{"Add":{"text":" use diesel::QueryDsl as _;","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:814"}},{"Add":{"text":" use diesel_async::RunQueryDsl as _;","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:858"}},{"Add":{"text":" diesel::select(diesel::dsl::exists(","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:902"}},{"Add":{"text":" cs::channel_settings","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:935"}},{"Add":{"text":" .filter(cs::repo_id.eq(id))","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:979"}},{"Add":{"text":" .filter(cs::min_reviews.gt(0)),","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1027"}},{"Add":{"text":" ))","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1038"}},{"Add":{"text":" .get_result(&mut db)","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1067"}},{"Add":{"text":" .await","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1082"}},{"Add":{"text":" .unwrap_or(false)","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1108"}},{"Add":{"text":" };","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1115"}}]}},{"Edit":{"inode":{"change":2,"pos":554127},"path":"api/src/change/list.rs","line":144,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":5007818}],"down_context":[{"change":3,"pos":5007818}],"flag":"BLOCK","start":1117,"end":1149,"inode":{"change":2,"pos":554127}}},"contents":[{"Add":{"text":" reviews_wanted,","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1148"}}]}},{"Replacement":{"inode":{"change":2,"pos":554127},"path":"api/src/change/list.rs","line":228,"ins":{"up_context":[{"change":4,"pos":36254}],"down_context":[{"change":4,"pos":36421}],"flag":"BLOCK","start":1150,"end":1402,"inode":{"change":2,"pos":554127}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":36254},"to":{"change":4,"start":36254,"end":36421},"introduced_by":4}],"inode":{"change":2,"pos":554127}},"ins_contents":[{"Add":{"text":" // channel would block) — but only if some channel here actually requires","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1229"}},{"Add":{"text":" // reviews. A review counts if its author's login differs from every author","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1309"}},{"Add":{"text":" // login of the patch; a general \"LGTM\" (null position) counts.","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1377"}},{"Add":{"text":" if reviews_wanted {","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1401"}}],"del_contents":[{"Del":{"text":" // channel would block). A review counts if its author's login differs from","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:36333"}},{"Del":{"text":" // every author login of the patch; a general \"LGTM\" (null position) counts.","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:36414"}},{"Del":{"text":" {","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:36420"}}]}},{"Edit":{"inode":{"change":2,"pos":554127},"path":"api/src/change/list.rs","line":290,"atom":{"NewVertex":{"up_context":[{"change":2,"pos":557393}],"down_context":[{"change":2,"pos":557393}],"flag":"BLOCK","start":1403,"end":1431,"inode":{"change":2,"pos":554127}}},"contents":[{"Add":{"text":" reviews_wanted,","pos":"GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC:1430"}}]}}],"owner":"pijul","repo":"nest","token":"aKFL3Wjgsjg3kYRUpouT7K6faRKid8JYHnfv7w65Efg=","login":null}

…

Dependencies

Change contents

Review