{"header":{"message":"Missing files","description":null,"timestamp":"2026-07-14T19:12:22.998362394Z","authors":[{}]},"hash":"HY6KW56TNL5TWFPDQLZBDURE2DZSHKSBDKW53VQOR55DSEU7I7QQC","authors":[{"login":"pmeunier","key":"AAAAC3NzaC1lZDI1NTE5AAAAILagOJFgwaMNhBWQINinKOXmqS4Gh5NgxgriXwdOoINJ"}],"deps":{"hashes":[["HY6KW56TNL5TWFPDQLZBDURE2DZSHKSBDKW53VQOR55DSEU7I7QQC","Missing files"],["AA",null],["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","Initial patch"]],"deps":["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC"],"known":[]},"hunks":[{"FileAdd":{"meta":{"basename":"http_auth.rs","metadata":0},"context":[{"change":2,"pos":319271}],"contents":[{"Add":"//! HTTP authentication with the same SSH keys, without touching the database."},{"Add":"//!"},{"Add":"//! A client proves possession of one of its registered SSH login keys by"},{"Add":"//! signing a canonical, host-bound payload (SSHSIG, namespace `pijul-http-login`)"},{"Add":"//! and posting it to `/login/ssh`. In return it gets a stateless bearer token:"},{"Add":"//!"},{"Add":"//! ```text"},{"Add":"//! token = user_id(16) ‖ iat(8, big-endian) ‖ HMAC-SHA256(subkey, user_id‖iat)"},{"Add":"//! ```"},{"Add":"//!"},{"Add":"//! Verification is a single HMAC + constant-time compare — no DB, no session"},{"Add":"//! table. TTL and a global \"not before\" kill-switch are enforced server-side"},{"Add":"//! against the issued-at timestamp."},{"Add":""},{"Add":"use crate::Config;"},{"Add":"use axum::{Json, extract::State};"},{"Add":"use diesel::{ExpressionMethods, OptionalExtension, QueryDsl};"},{"Add":"use diesel_async::RunQueryDsl;"},{"Add":"use openssl::{hash::MessageDigest, pkey::PKey, sign::Signer};"},{"Add":"use serde::{Deserialize, Serialize};"},{"Add":"use std::time::{SystemTime, UNIX_EPOCH};"},{"Add":"use thrussh_keys::PublicKeyBase64;"},{"Add":"use thrussh_keys::key::{OpenSSLPKey, PublicKey, SignatureHash};"},{"Add":"use uuid::Uuid;"},{"Add":""},{"Add":"const LOGIN_NAMESPACE: &str = \"pijul-http-login\";"},{"Add":"const TOKEN_TTL_SECS: u64 = 24 * 3600;"},{"Add":"const TOKEN_LEN: usize = 16 + 8 + 32;"},{"Add":""},{"Add":"#[derive(Deserialize)]"},{"Add":"pub struct SshLogin {"},{"Add":" /// base64(sshsig.to_bytes()); the signing public key is inside it."},{"Add":" signature: String,"},{"Add":"}"},{"Add":""},{"Add":"#[derive(Serialize)]"},{"Add":"pub struct SshLoginResponse {"},{"Add":" token: String,"},{"Add":" expires_in: u64,"},{"Add":"}"},{"Add":""},{"Add":"fn now() -> u64 {"},{"Add":" SystemTime::now()"},{"Add":" .duration_since(UNIX_EPOCH)"},{"Add":" .map(|d| d.as_secs())"},{"Add":" .unwrap_or(0)"},{"Add":"}"},{"Add":""},{"Add":"fn hmac(key: &[u8], data: &[u8]) -> Vec {"},{"Add":" let k = PKey::hmac(key).unwrap();"},{"Add":" let mut s = Signer::new(MessageDigest::sha256(), &k).unwrap();"},{"Add":" s.update(data).unwrap();"},{"Add":" s.sign_to_vec().unwrap()"},{"Add":"}"},{"Add":""},{"Add":"// Domain-separated subkey so the token MAC never collides with cookie signing,"},{"Add":"// which shares `hmac_secret`. Bump the label to force a global logout."},{"Add":"fn token_key(config: &Config) -> Vec {"},{"Add":" hmac(&config.hmac_secret, b\"pijul-http-token-v1\")"},{"Add":"}"},{"Add":""},{"Add":"/// The payload the client signs: just this host, under a dedicated namespace."},{"Add":"/// Over HTTPS there's nothing to replay, so no timestamp/nonce is needed here."},{"Add":"fn login_payload(host: &str) -> Vec {"},{"Add":" host.as_bytes().to_vec()"},{"Add":"}"},{"Add":""},{"Add":"// Match `auth_publickey`'s handling so RSA login keys resolve. (RSA"},{"Add":"// `public_key_bytes()` is already canonical, so this is mostly future-proofing.)"},{"Add":"fn login_key_bytes(pk: &PublicKey) -> Vec {"},{"Add":" match pk {"},{"Add":" PublicKey::RSA { key, .. } => PublicKey::RSA {"},{"Add":" key: OpenSSLPKey(key.0.clone()),"},{"Add":" hash: SignatureHash::SHA2_512,"},{"Add":" }"},{"Add":" .public_key_bytes(),"},{"Add":" k => k.public_key_bytes(),"},{"Add":" }"},{"Add":"}"},{"Add":""},{"Add":"pub async fn ssh_login("},{"Add":" State(config): State,"},{"Add":" Json(req): Json,"},{"Add":") -> Result, crate::Error> {"},{"Add":" let sig = data_encoding::BASE64_NOPAD.decode(req.signature.as_bytes())?;"},{"Add":" let sshsig = thrussh_keys::SshSig::from_bytes(&sig).map_err(|_| crate::Error::WrongSignature)?;"},{"Add":""},{"Add":" // Right ceremony, this host, valid signature."},{"Add":" if sshsig.namespace != LOGIN_NAMESPACE {"},{"Add":" return Err(crate::Error::WrongSignature);"},{"Add":" }"},{"Add":" if !sshsig"},{"Add":" .verify(&login_payload(&config.host))"},{"Add":" .map_err(|_| crate::Error::WrongSignature)?"},{"Add":" {"},{"Add":" return Err(crate::Error::WrongSignature);"},{"Add":" }"},{"Add":""},{"Add":" // Resolve to one of this user's SSH login keys (same registry SSH auth uses)."},{"Add":" let key_bytes = login_key_bytes(&sshsig.public_key);"},{"Add":" let mut db = config.db.get().await?;"},{"Add":" let user_id: Uuid = {"},{"Add":" use crate::db::publickeys::dsl as pk;"},{"Add":" use crate::db::users::dsl as u;"},{"Add":" u::users"},{"Add":" .inner_join(pk::publickeys)"},{"Add":" .filter(pk::bin.eq(&key_bytes))"},{"Add":" .filter(u::is_active)"},{"Add":" .select(u::id)"},{"Add":" .get_result::(&mut db)"},{"Add":" .await"},{"Add":" .optional()?"},{"Add":" .ok_or(crate::Error::Forbidden)?"},{"Add":" };"},{"Add":""},{"Add":" // Mint: user_id ‖ iat ‖ HMAC."},{"Add":" let mut payload = Vec::with_capacity(24);"},{"Add":" payload.extend_from_slice(user_id.as_bytes());"},{"Add":" payload.extend_from_slice(&now().to_be_bytes());"},{"Add":" let mut tok = payload.clone();"},{"Add":" tok.extend_from_slice(&hmac(&token_key(&config), &payload));"},{"Add":""},{"Add":" Ok(Json(SshLoginResponse {"},{"Add":" token: data_encoding::BASE64URL_NOPAD.encode(&tok),"},{"Add":" expires_in: TOKEN_TTL_SECS,"},{"Add":" }))"},{"Add":"}"},{"Add":""},{"Add":"/// Resolve `Authorization: Bearer ` to a user with a single HMAC check —"},{"Add":"/// no DB, no await. Absent/invalid/expired → `None` (anonymous READ)."},{"Add":"pub fn bearer_user(config: &Config, headers: &http::HeaderMap) -> Option {"},{"Add":" let b64 = headers"},{"Add":" .get(http::header::AUTHORIZATION)?"},{"Add":" .to_str()"},{"Add":" .ok()?"},{"Add":" .strip_prefix(\"Bearer \")?;"},{"Add":" let raw = data_encoding::BASE64URL_NOPAD.decode(b64.as_bytes()).ok()?;"},{"Add":" if raw.len() != TOKEN_LEN {"},{"Add":" return None;"},{"Add":" }"},{"Add":" let (payload, tag) = raw.split_at(24);"},{"Add":" if !openssl::memcmp::eq(&hmac(&token_key(config), payload), tag) {"},{"Add":" return None;"},{"Add":" }"},{"Add":" let iat = u64::from_be_bytes(payload[16..24].try_into().ok()?);"},{"Add":" let now = now();"},{"Add":" // Server-side TTL policy + global kill-switch, both against the issued-at."},{"Add":" if now.saturating_sub(iat) > TOKEN_TTL_SECS || iat < config.token_not_before {"},{"Add":" return None;"},{"Add":" }"},{"Add":" Some(Uuid::from_slice(&payload[..16]).ok()?)"},{"Add":"}"}]}},{"FileAdd":{"meta":{"basename":"comments.rs","metadata":0},"context":[{"change":2,"pos":548910}],"contents":[{"Add":"//! Review comments on a patch, **decoupled from discussions**: stored in"},{"Add":"//! `review_comments`, keyed by (repository, change). A `position` anchors"},{"Add":"//! a comment to a line (its end `Position`, `\"{change}:{byte}\"`);"},{"Add":"//! a null position is a general, patch-level comment. Discussions are a"},{"Add":"//! separate concept — the patch page only *links* to any the patch"},{"Add":"//! appears in."},{"Add":""},{"Add":"use crate::Config;"},{"Add":"use crate::permissions::Perm;"},{"Add":"use axum::{"},{"Add":" Json, debug_handler,"},{"Add":" extract::{ConnectInfo, Path, State},"},{"Add":"};"},{"Add":"use axum_extra::extract::SignedCookieJar;"},{"Add":"use diesel::prelude::*;"},{"Add":"use diesel_async::RunQueryDsl;"},{"Add":"use pijul_core::Base32;"},{"Add":"use serde_derive::*;"},{"Add":"use std::net::SocketAddr;"},{"Add":""},{"Add":"#[derive(Debug, Deserialize)]"},{"Add":"pub struct CommentsPath {"},{"Add":" hash: String,"},{"Add":"}"},{"Add":""},{"Add":"#[derive(Debug, Serialize)]"},{"Add":"pub struct DiscInfo {"},{"Add":" number: i32,"},{"Add":" title: String,"},{"Add":"}"},{"Add":""},{"Add":"#[derive(Debug, Serialize)]"},{"Add":"pub struct CommentJson {"},{"Add":" id: uuid::Uuid,"},{"Add":" author: Option,"},{"Add":" html: String,"},{"Add":" /// Raw markdown source, so the author can edit it in place."},{"Add":" contents: String,"},{"Add":" date: i64,"},{"Add":" /// `\"{change_base32}:{byte_pos}\"` for a line comment; absent for a"},{"Add":" /// general patch-level comment."},{"Add":" #[serde(skip_serializing_if = \"Option::is_none\")]"},{"Add":" position: Option,"},{"Add":"}"},{"Add":""},{"Add":"#[derive(Debug, Serialize)]"},{"Add":"pub struct CommentsResponse {"},{"Add":" /// CSRF token minted from the caller's session (the sole issuer on the"},{"Add":" /// patch page — see note in `context.rs`); the client posts with it."},{"Add":" csrf: String,"},{"Add":" /// Discussions this patch appears in — for linking, not for anchoring."},{"Add":" discussions: Vec,"},{"Add":" comments: Vec,"},{"Add":"}"},{"Add":""},{"Add":"/// All review comments on this patch (line-anchored and general), plus the"},{"Add":"/// discussions the patch belongs to (for a link)."},{"Add":"#[debug_handler]"},{"Add":"pub async fn comments("},{"Add":" State(config): State,"},{"Add":" jar: SignedCookieJar,"},{"Add":" csrf: axum_csrf::CsrfToken,"},{"Add":" repo: crate::repository::RepoPath,"},{"Add":" Path(p): Path,"},{"Add":") -> Result<(axum_csrf::CsrfToken, Json), crate::Error> {"},{"Add":" let csrf_token = csrf.authenticity_token()?;"},{"Add":" let (uid, _login) = crate::get_user_login_(&jar, &config).await?;"},{"Add":" let mut db = config.db.get().await?;"},{"Add":" let (id, _, _) ="},{"Add":" crate::repository::repository_id(&mut db, &repo.owner, &repo.repo, uid, Perm::READ).await?;"},{"Add":""},{"Add":" use crate::db::discussion_changes::dsl as dc;"},{"Add":" use crate::db::discussions::dsl as d;"},{"Add":" use crate::db::review_comments::dsl as rc;"},{"Add":" use crate::db::users::dsl as u;"},{"Add":""},{"Add":" type Row = ("},{"Add":" uuid::Uuid,"},{"Add":" Option,"},{"Add":" chrono::DateTime,"},{"Add":" String,"},{"Add":" String,"},{"Add":" Option,"},{"Add":" );"},{"Add":" let rows: Vec = rc::review_comments"},{"Add":" .left_join(u::users)"},{"Add":" .filter(rc::repository_id.eq(id))"},{"Add":" .filter(rc::change.eq(&p.hash))"},{"Add":" .select(("},{"Add":" rc::id,"},{"Add":" u::login.nullable(),"},{"Add":" rc::creation_date,"},{"Add":" rc::cached_html,"},{"Add":" rc::contents,"},{"Add":" rc::position,"},{"Add":" ))"},{"Add":" .order_by(rc::creation_date)"},{"Add":" .get_results(&mut db)"},{"Add":" .await?;"},{"Add":""},{"Add":" let comments = rows"},{"Add":" .into_iter()"},{"Add":" .map(|(id, author, date, html, contents, position)| CommentJson {"},{"Add":" id,"},{"Add":" author,"},{"Add":" html,"},{"Add":" contents,"},{"Add":" date: date.timestamp(),"},{"Add":" position,"},{"Add":" })"},{"Add":" .collect();"},{"Add":""},{"Add":" let discussions: Vec = dc::discussion_changes"},{"Add":" .inner_join(d::discussions)"},{"Add":" .filter(dc::change.eq(&p.hash))"},{"Add":" .filter(dc::removed.is_null())"},{"Add":" .filter(d::repository_id.eq(id))"},{"Add":" .select((d::number, d::title))"},{"Add":" .get_results::<(i32, String)>(&mut db)"},{"Add":" .await?"},{"Add":" .into_iter()"},{"Add":" .map(|(number, title)| DiscInfo { number, title })"},{"Add":" .collect();"},{"Add":""},{"Add":" Ok(("},{"Add":" csrf,"},{"Add":" Json(CommentsResponse {"},{"Add":" csrf: csrf_token,"},{"Add":" discussions,"},{"Add":" comments,"},{"Add":" }),"},{"Add":" ))"},{"Add":"}"},{"Add":""},{"Add":"/// Form-encoded (so a plain `

` posts it, no JS needed). Empty"},{"Add":"/// `position` = general patch comment; `edit` = a comment id to update."},{"Add":"#[derive(Debug, Deserialize)]"},{"Add":"pub struct NewComment {"},{"Add":" token: String,"},{"Add":" #[serde(default)]"},{"Add":" contents: String,"},{"Add":" #[serde(default)]"},{"Add":" position: String,"},{"Add":" /// Id of an existing comment to edit in place (author only); empty to"},{"Add":" /// post a new one."},{"Add":" #[serde(default)]"},{"Add":" edit: String,"},{"Add":" /// Id of a comment to delete (author only)."},{"Add":" #[serde(default)]"},{"Add":" delete: String,"},{"Add":"}"},{"Add":""},{"Add":"/// Post or edit a review comment on this patch."},{"Add":"#[debug_handler]"},{"Add":"pub async fn post_comment("},{"Add":" State(config): State,"},{"Add":" jar: SignedCookieJar,"},{"Add":" token: axum_csrf::CsrfToken,"},{"Add":" repo: crate::repository::RepoPath,"},{"Add":" Path(p): Path,"},{"Add":" ConnectInfo(addr): ConnectInfo,"},{"Add":" axum::Form(form): axum::Form,"},{"Add":") -> Result<(axum_csrf::CsrfToken, axum::http::StatusCode), crate::Error> {"},{"Add":" crate::csrf_verify(&token, &form.token)?;"},{"Add":" let (uid, _login, _email) = crate::get_user_login_email_strict(&jar, &config).await?;"},{"Add":""},{"Add":" let mut db = config.db.get().await?;"},{"Add":" let (id, _, _) = crate::repository::repository_id("},{"Add":" &mut db,"},{"Add":" &repo.owner,"},{"Add":" &repo.repo,"},{"Add":" Some(uid),"},{"Add":" Perm::CREATE_DISCUSSION,"},{"Add":" )"},{"Add":" .await?;"},{"Add":""},{"Add":" use crate::db::review_comments::dsl as rc;"},{"Add":""},{"Add":" // Deleting a comment (author only)."},{"Add":" let delete = form.delete.trim();"},{"Add":" if !delete.is_empty() {"},{"Add":" let cid: uuid::Uuid = delete.parse().map_err(|_| crate::Error::NotFound)?;"},{"Add":" diesel::delete(rc::review_comments.find(cid))"},{"Add":" .filter(rc::author.eq(uid))"},{"Add":" .execute(&mut db)"},{"Add":" .await?;"},{"Add":" return Ok((token, axum::http::StatusCode::OK));"},{"Add":" }"},{"Add":""},{"Add":" let contents = form.contents.trim().to_string();"},{"Add":" if contents.is_empty() {"},{"Add":" return Err(anyhow::anyhow!(\"empty comment\").into());"},{"Add":" }"},{"Add":" let html = crate::markdown::render_markdown(&repo.owner, &repo.repo, \"\", \"\", &contents).rendered;"},{"Add":""},{"Add":" // Editing an existing comment (author only): just refresh its text."},{"Add":" let edit = form.edit.trim();"},{"Add":" if !edit.is_empty() {"},{"Add":" let cid: uuid::Uuid = edit.parse().map_err(|_| crate::Error::NotFound)?;"},{"Add":" diesel::update(rc::review_comments.find(cid))"},{"Add":" .filter(rc::author.eq(uid))"},{"Add":" .set((rc::contents.eq(&contents), rc::cached_html.eq(&html)))"},{"Add":" .execute(&mut db)"},{"Add":" .await?;"},{"Add":" return Ok((token, axum::http::StatusCode::OK));"},{"Add":" }"},{"Add":""},{"Add":" if pijul_core::Hash::from_base32(p.hash.as_bytes()).is_none() {"},{"Add":" return Err(crate::Error::HashParse {"},{"Add":" hash: p.hash.clone(),"},{"Add":" });"},{"Add":" }"},{"Add":" let position: Option = {"},{"Add":" let s = form.position.trim();"},{"Add":" if s.is_empty() {"},{"Add":" None"},{"Add":" } else {"},{"Add":" Some(s.to_string())"},{"Add":" }"},{"Add":" };"},{"Add":" let ip_sql ="},{"Add":" ipnetwork::IpNetwork::new(addr.ip(), if addr.is_ipv4() { 32 } else { 128 }).unwrap();"},{"Add":""},{"Add":" diesel::insert_into(rc::review_comments)"},{"Add":" .values(("},{"Add":" rc::repository_id.eq(id),"},{"Add":" rc::change.eq(&p.hash),"},{"Add":" rc::position.eq(&position),"},{"Add":" rc::author.eq(uid),"},{"Add":" rc::contents.eq(&contents),"},{"Add":" rc::cached_html.eq(&html),"},{"Add":" rc::creation_ip.eq(&ip_sql),"},{"Add":" ))"},{"Add":" .execute(&mut db)"},{"Add":" .await?;"},{"Add":""},{"Add":" Ok((token, axum::http::StatusCode::OK))"},{"Add":"}"}]}}],"owner":"pijul","repo":"nest","token":"4M74XBmg6yCWgVbLfruH5YQ94CpabJca37a9iEMrTyA=","login":null}

…

Dependencies

Change contents