{"header":{"message":"Zulip mentions in notifications","description":null,"timestamp":"2026-07-29T16:29:02.786344419Z","authors":[{}]},"hash":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC","authors":[{"login":"pmeunier","key":"AAAAC3NzaC1lZDI1NTE5AAAAILagOJFgwaMNhBWQINinKOXmqS4Gh5NgxgriXwdOoINJ"}],"deps":{"hashes":[["KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC","Zulip mentions in notifications"],["AA",null],["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","Initial patch"],["AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","Redesign (fat change)"],["DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC","Handling --amend from the Nest (unrecord + apply)"],["XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC","Notifications"]],"deps":["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC","XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC"],"known":[]},"hunks":[{"Edit":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":122,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":12052}],"down_context":[{"change":5,"pos":12052}],"flag":"BLOCK","start":0,"end":152,"inode":{"change":5,"pos":7843}}},"contents":[{"Add":{"text":"}","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1"}},{"Add":{"text":"","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2"}},{"Add":{"text":"/// A Zulip account, as needed to @-mention it in a stream post.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:67"}},{"Add":{"text":"#[derive(Clone)]","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:84"}},{"Add":{"text":"pub struct ZulipUser {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:107"}},{"Add":{"text":" pub id: i64,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:124"}},{"Add":{"text":" pub full_name: String,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:151"}}]}},{"Edit":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":131,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":12055}],"down_context":[{"change":5,"pos":12055}],"flag":"BLOCK","start":153,"end":385,"inode":{"change":5,"pos":7843}}},"contents":[{"Add":{"text":"/// Email (lowercased) → Zulip account, so a Nest user can be matched to their","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:233"}},{"Add":{"text":"/// Zulip identity by shared email and @-mentioned.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:285"}},{"Add":{"text":"pub type ZulipDirectory = Arc>>;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:383"}},{"Add":{"text":"","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:384"}}]}},{"Edit":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":142,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":12420}],"down_context":[{"change":5,"pos":12420}],"flag":"BLOCK","start":386,"end":423,"inode":{"change":5,"pos":7843}}},"contents":[{"Add":{"text":" pub zulip_users: ZulipDirectory,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:422"}}]}},{"Edit":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":148,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":12633}],"down_context":[{"change":5,"pos":12633}],"flag":"BLOCK","start":424,"end":2510,"inode":{"change":5,"pos":7843}}},"contents":[{"Add":{"text":"}","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:425"}},{"Add":{"text":"","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:426"}},{"Add":{"text":"/// Fetch the Zulip org's member list and rebuild the email→account directory.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:507"}},{"Add":{"text":"/// Best-effort: on any error the existing directory is left untouched.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:579"}},{"Add":{"text":"pub async fn refresh_zulip_directory(zulip: &Option, dir: &ZulipDirectory) {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:689"}},{"Add":{"text":" let Some(z) = zulip else { return };","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:730"}},{"Add":{"text":" #[derive(Deserialize)]","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:757"}},{"Add":{"text":" struct Member {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:777"}},{"Add":{"text":" user_id: i64,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:799"}},{"Add":{"text":" full_name: String,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:826"}},{"Add":{"text":" #[serde(default)]","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:852"}},{"Add":{"text":" email: Option,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:883"}},{"Add":{"text":" #[serde(default)]","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:909"}},{"Add":{"text":" delivery_email: Option,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:949"}},{"Add":{"text":" #[serde(default)]","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:975"}},{"Add":{"text":" is_active: Option,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1008"}},{"Add":{"text":" #[serde(default)]","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1034"}},{"Add":{"text":" is_bot: Option,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1064"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1070"}},{"Add":{"text":" #[derive(Deserialize)]","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1097"}},{"Add":{"text":" struct Members {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1118"}},{"Add":{"text":" #[serde(default)]","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1144"}},{"Add":{"text":" members: Vec,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1174"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1180"}},{"Add":{"text":" let client = reqwest::Client::new();","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1221"}},{"Add":{"text":" let resp = client","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1243"}},{"Add":{"text":" .get(format!(\"{}/api/v1/users\", z.site))","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1292"}},{"Add":{"text":" .basic_auth(&z.bot_email, Some(&z.api_key))","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1344"}},{"Add":{"text":" .send()","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1360"}},{"Add":{"text":" .await;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1376"}},{"Add":{"text":" let Ok(resp) = resp else { return };","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1417"}},{"Add":{"text":" let Ok(body) = resp.json::().await else {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1472"}},{"Add":{"text":" return;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1488"}},{"Add":{"text":" };","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1495"}},{"Add":{"text":" let mut map = std::collections::HashMap::new();","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1547"}},{"Add":{"text":" for m in body.members {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1575"}},{"Add":{"text":" if m.is_bot == Some(true) || m.is_active == Some(false) {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1641"}},{"Add":{"text":" continue;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1663"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1673"}},{"Add":{"text":" let zu = ZulipUser {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1702"}},{"Add":{"text":" id: m.user_id,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1729"}},{"Add":{"text":" full_name: m.full_name,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1765"}},{"Add":{"text":" };","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1776"}},{"Add":{"text":" // Prefer the real delivery email, but also index the visible one — in","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1857"}},{"Add":{"text":" // email-hidden orgs the latter is a proxy address that won't match, and","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1938"}},{"Add":{"text":" // that's fine (it just won't resolve).","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:1986"}},{"Add":{"text":" for e in [m.delivery_email, m.email].into_iter().flatten() {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2055"}},{"Add":{"text":" map.insert(e.to_lowercase(), zu.clone());","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2109"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2119"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2125"}},{"Add":{"text":" *dir.write().await = map;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2155"}},{"Add":{"text":"}","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2157"}},{"Add":{"text":"","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2158"}},{"Add":{"text":"/// The Zulip @-mention for a Nest email, if that email belongs to a Zulip","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2233"}},{"Add":{"text":"/// account. Uses the `@**Full Name|id**` form, which is unambiguous.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2303"}},{"Add":{"text":"async fn zulip_mention(n: &Notifier, email: &str) -> Option {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2373"}},{"Add":{"text":" let dir = n.zulip_users.read().await;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2415"}},{"Add":{"text":" dir.get(&email.to_lowercase())","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2450"}},{"Add":{"text":" .map(|u| format!(\"@**{}|{}**\", u.full_name, u.id))","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2509"}}]}},{"Edit":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":274,"atom":{"EdgeMap":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":14931},"to":{"change":5,"start":14931,"end":15053},"introduced_by":5}],"inode":{"change":5,"pos":7843}}},"contents":[{"Del":{"text":" // 1. Zulip — always, regardless of any per-user preference.","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:14997"}},{"Del":{"text":" zulip(n, event.kind.topic(), &event.zulip).await;","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:15051"}},{"Del":{"text":"","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:15052"}}]}},{"Edit":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":278,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":15122}],"down_context":[{"change":5,"pos":15122}],"flag":"BLOCK","start":2511,"end":2890,"inode":{"change":5,"pos":7843}}},"contents":[{"Add":{"text":" // Resolve each distinct, non-actor target once: its Nest email (for the","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2587"}},{"Add":{"text":" // email fallback) and its Zulip @-mention (for the stream post).","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2657"}},{"Add":{"text":" struct Target {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2677"}},{"Add":{"text":" uid: uuid::Uuid,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2702"}},{"Add":{"text":" /// Email address if it's deliverable (active user, not marked invalid).","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2783"}},{"Add":{"text":" email: Option,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2814"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2820"}},{"Add":{"text":" let mut targets = Vec::new();","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2854"}},{"Add":{"text":" let mut mentions = Vec::new();","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2889"}}]}},{"Replacement":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":288,"ins":{"up_context":[{"change":5,"pos":15175}],"down_context":[{"change":5,"pos":15315}],"flag":"BLOCK","start":2891,"end":3028,"inode":{"change":5,"pos":7843}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":15175},"to":{"change":5,"start":15175,"end":15315},"introduced_by":5}],"inode":{"change":5,"pos":7843}},"ins_contents":[{"Add":{"text":" for uid in &event.targets {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2922"}},{"Add":{"text":" let uid = *uid;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:2946"}},{"Add":{"text":" if Some(uid) == event.actor || !seen.insert(uid) {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3005"}},{"Add":{"text":" continue;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3027"}}],"del_contents":[{"Del":{"text":" for uid in event.targets {","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:15205"}},{"Del":{"text":" if Some(uid) == event.actor {","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:15243"}},{"Del":{"text":" continue; // never notify the actor about their own action","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:15314"}}]}},{"Replacement":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":293,"ins":{"up_context":[{"change":5,"pos":15325}],"down_context":[{"change":5,"pos":15387}],"flag":"BLOCK","start":3029,"end":3854,"inode":{"change":5,"pos":7843}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":15325},"to":{"change":5,"start":15325,"end":15387},"introduced_by":5}],"inode":{"change":5,"pos":7843}},"ins_contents":[{"Add":{"text":" // (email, deliverable) — email is used for the Zulip match regardless of","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3112"}},{"Add":{"text":" // whether it's a deliverable Nest address.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3164"}},{"Add":{"text":" let row: Option<(String, bool)> = {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3208"}},{"Add":{"text":" use crate::db::users::dsl as u;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3252"}},{"Add":{"text":" u::users","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3273"}},{"Add":{"text":" .find(uid)","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3300"}},{"Add":{"text":" .filter(u::is_active)","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3338"}},{"Add":{"text":" .select((u::email, u::email_is_invalid.is_null()))","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3405"}},{"Add":{"text":" .get_result::<(String, bool)>(&mut db)","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3460"}},{"Add":{"text":" .await","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3483"}},{"Add":{"text":" .optional()","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3511"}},{"Add":{"text":" .ok()","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3533"}},{"Add":{"text":" .flatten()","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3560"}},{"Add":{"text":" };","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3571"}},{"Add":{"text":" let mut deliverable_email = None;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3613"}},{"Add":{"text":" if let Some((e, deliverable)) = row {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3659"}},{"Add":{"text":" if let Some(m) = zulip_mention(n, &e).await {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3717"}},{"Add":{"text":" mentions.push(m);","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3751"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3765"}},{"Add":{"text":" if deliverable {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3794"}},{"Add":{"text":" deliverable_email = Some(e);","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3839"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3853"}}],"del_contents":[{"Del":{"text":" if !seen.insert(uid) {","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:15355"}},{"Del":{"text":" continue; // dedup","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:15386"}}]}},{"Edit":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":316,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":15397}],"down_context":[{"change":5,"pos":15397}],"flag":"BLOCK","start":3855,"end":3958,"inode":{"change":5,"pos":7843}}},"contents":[{"Add":{"text":" targets.push(Target {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3884"}},{"Add":{"text":" uid,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3901"}},{"Add":{"text":" email: deliverable_email,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3939"}},{"Add":{"text":" });","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3951"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:3957"}}]}},{"Edit":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":322,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":15398}],"down_context":[{"change":5,"pos":15398}],"flag":"BLOCK","start":3959,"end":4425,"inode":{"change":5,"pos":7843}}},"contents":[{"Add":{"text":" // 1. Zulip stream post — always. @-mention any target matched to a Zulip","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4038"}},{"Add":{"text":" // account (by shared email) so it highlights for them there too.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4108"}},{"Add":{"text":" let content = if mentions.is_empty() {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4151"}},{"Add":{"text":" event.zulip.clone()","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4179"}},{"Add":{"text":" } else {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4192"}},{"Add":{"text":" format!(\"{} (cc {})\", event.zulip, mentions.join(\" \"))","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4255"}},{"Add":{"text":" };","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4262"}},{"Add":{"text":" zulip(n, event.kind.topic(), &content).await;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4312"}},{"Add":{"text":"","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4313"}},{"Add":{"text":" // 2. Personal delivery per target: SSE if present, else email.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4381"}},{"Add":{"text":" for Target { uid, email } in targets {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4424"}}]}},{"Replacement":{"inode":{"change":5,"pos":7843},"path":"api/src/notify.rs","line":352,"ins":{"up_context":[{"change":5,"pos":16030}],"down_context":[{"change":5,"pos":16564}],"flag":"BLOCK","start":4426,"end":4589,"inode":{"change":5,"pos":7843}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":5,"pos":16030},"to":{"change":5,"start":16030,"end":16564},"introduced_by":5}],"inode":{"change":5,"pos":7843}},"ins_contents":[{"Add":{"text":" // Deliverable email address, if we might need one (prefetched above).","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4504"}},{"Add":{"text":" let addr: Option = if !present && email_on { email } else { None };","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4588"}}],"del_contents":[{"Del":{"text":" // A deliverable email address, if we might need one.","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16091"}},{"Del":{"text":" let addr: Option = if !present && email_on {","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16152"}},{"Del":{"text":" use crate::db::users::dsl as u;","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16196"}},{"Del":{"text":" u::users","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16217"}},{"Del":{"text":" .find(uid)","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16244"}},{"Del":{"text":" .filter(u::email_is_invalid.is_null())","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16299"}},{"Del":{"text":" .filter(u::is_active)","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16337"}},{"Del":{"text":" .select(u::email)","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16371"}},{"Del":{"text":" .get_result::(&mut db)","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16418"}},{"Del":{"text":" .await","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16441"}},{"Del":{"text":" .optional()","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16469"}},{"Del":{"text":" .ok()","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16491"}},{"Del":{"text":" .flatten()","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16518"}},{"Del":{"text":" } else {","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16535"}},{"Del":{"text":" None","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16552"}},{"Del":{"text":" };","pos":"XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC:16563"}}]}},{"Edit":{"inode":{"change":2,"pos":452154},"path":"api/src/main.rs","line":260,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":19469}],"down_context":[{"change":4,"pos":19469}],"flag":"BLOCK","start":4590,"end":4751,"inode":{"change":2,"pos":452154}}},"contents":[{"Add":{"text":" // Keep the Zulip email→account directory fresh (for @-mentions). One eager","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4671"}},{"Add":{"text":" // refresh at startup, then periodically. No-op if Zulip isn't configured.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4750"}}]}},{"Edit":{"inode":{"change":2,"pos":452154},"path":"api/src/main.rs","line":263,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":19488}],"down_context":[{"change":3,"pos":4924800}],"flag":"BLOCK","start":4752,"end":5080,"inode":{"change":2,"pos":452154}}},"contents":[{"Add":{"text":" let zulip = config.zulip.clone();","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4793"}},{"Add":{"text":" let dir = config.zulip_users.clone();","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4839"}},{"Add":{"text":" async move {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4860"}},{"Add":{"text":" loop {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4879"}},{"Add":{"text":" notify::refresh_zulip_directory(&zulip, &dir).await;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4948"}},{"Add":{"text":" tokio::time::sleep(std::time::Duration::from_secs(900)).await;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5027"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5041"}},{"Add":{"text":" }","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5051"}},{"Add":{"text":" });","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5059"}},{"Add":{"text":"","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5060"}},{"Add":{"text":" tokio::spawn({","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5079"}}]}},{"Edit":{"inode":{"change":2,"pos":532759},"path":"api/src/config.rs","line":70,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":27724}],"down_context":[{"change":4,"pos":27724}],"flag":"BLOCK","start":5081,"end":5288,"inode":{"change":2,"pos":532759}}},"contents":[{"Add":{"text":" /// Email (lowercased) → Zulip account, refreshed periodically from the Zulip","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5164"}},{"Add":{"text":" /// member list, so Nest users can be @-mentioned in stream posts.","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5235"}},{"Add":{"text":" pub zulip_users: crate::notify::ZulipDirectory,","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5287"}}]}},{"Edit":{"inode":{"change":2,"pos":532759},"path":"api/src/config.rs","line":82,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":28058}],"down_context":[{"change":4,"pos":28058}],"flag":"BLOCK","start":5289,"end":5340,"inode":{"change":2,"pos":532759}}},"contents":[{"Add":{"text":" zulip_users: self.zulip_users.clone(),","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5339"}}]}},{"Edit":{"inode":{"change":2,"pos":532759},"path":"api/src/config.rs","line":214,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":28322}],"down_context":[{"change":2,"pos":542913}],"flag":"BLOCK","start":5341,"end":5432,"inode":{"change":2,"pos":532759}}},"contents":[{"Add":{"text":" zulip_users: Arc::new(tokio::sync::RwLock::new(std::collections::HashMap::new())),","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:5431"}}]}}],"owner":"pijul","repo":"nest","token":"MvOVokWQDZgEvIgUx1+6af46uCkk1ectLpb4jcrJucM=","login":null}

…

Dependencies

Change contents

Review