{"header":{"message":"Grandfathering: marking existing history as ok when switching to a strict review policy","description":null,"timestamp":"2026-07-29T10:39:15.199053293Z","authors":[{}]},"hash":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC","authors":[{"login":"pmeunier","key":"AAAAC3NzaC1lZDI1NTE5AAAAILagOJFgwaMNhBWQINinKOXmqS4Gh5NgxgriXwdOoINJ"}],"deps":{"hashes":[["OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC","Grandfathering: marking existing history as ok when switching to a strict review policy"],["AA",null],["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","Initial patch"],["AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","Redesign (fat change)"],["EG3MNPQXLNF62UQAP3342JC4OL47MAUCYJM6Q4G7BVVBM2VXMDCAC","Patch reviews"],["3UYOLOBPKKDEBN4VX4GZT2KXVH3WJF3SBTWZADD2SQW4463KDKBAC","Rollback failed CI/CD jobs, and allow CI-only channels"],["IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC","Replacing approvals with 'different pusher and author'"],["FU37JBX4JISRV26VYEMLU3LZ67CVTUO62JP6H6SO6P2RAIIHRUMAC","Audits CI-side"],["GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC","Don't show 'needs review' if no channel requires it"]],"deps":["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","EG3MNPQXLNF62UQAP3342JC4OL47MAUCYJM6Q4G7BVVBM2VXMDCAC","3UYOLOBPKKDEBN4VX4GZT2KXVH3WJF3SBTWZADD2SQW4463KDKBAC","IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC"],"known":["FU37JBX4JISRV26VYEMLU3LZ67CVTUO62JP6H6SO6P2RAIIHRUMAC","GJWCLCBJZ2CURI6MPEY4VZQB6GV5VWEQN63E75FS2K563FB7KWAQC"]},"hunks":[{"Replacement":{"inode":{"change":2,"pos":99993},"path":"ui/src/routes/[user]/[repo]/admin/Permission.svelte","line":37,"ins":{"up_context":[{"change":3,"pos":4791244}],"down_context":[{"change":3,"pos":4791323}],"flag":"BLOCK","start":0,"end":136,"inode":{"change":2,"pos":99993}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4791244},"to":{"change":3,"start":4791244,"end":4791323},"introduced_by":3}],"inode":{"change":2,"pos":99993}},"ins_contents":[{"Add":{"text":" ({ update }) => update({ reset: false })}>","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:135"}}],"del_contents":[{"Del":{"text":"

","pos":"AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC:4791322"}}]}},{"Replacement":{"inode":{"change":2,"pos":104971},"path":"ui/src/routes/[user]/[repo]/admin/+page.svelte","line":147,"ins":{"up_context":[{"change":3,"pos":4800969}],"down_context":[{"change":3,"pos":4801066}],"flag":"BLOCK","start":137,"end":323,"inode":{"change":2,"pos":104971}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":3,"pos":4800969},"to":{"change":3,"start":4800969,"end":4801066},"introduced_by":3}],"inode":{"change":2,"pos":104971}},"ins_contents":[{"Add":{"text":" ({ update }) => update({ reset: false })}>","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:322"}}],"del_contents":[{"Del":{"text":" ","pos":"AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC:4801065"}}]}},{"FileAdd":{"meta":{"basename":"2026-07-29-000002-0000_review_grandfathered","metadata":576},"context":[{"change":2,"pos":297727}],"contents":[]}},{"FileAdd":{"meta":{"basename":"up.sql","metadata":0},"context":[{"change":0,"pos":379}],"contents":[{"Add":{"text":"-- Grandfathering existing history when a channel switches to min_reviews > 0.","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:491"}},{"Add":{"text":"--","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:494"}},{"Add":{"text":"-- The admin's bulk \"review all\" (backfill_reviews) records an LGTM on every","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:571"}},{"Add":{"text":"-- patch currently on the channel. But the min_reviews policy only counts","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:645"}},{"Add":{"text":"-- reviews by NON-authors, so an admin who authored those patches could never","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:723"}},{"Add":{"text":"-- unblock their own history — the backfill appeared to do nothing.","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:793"}},{"Add":{"text":"--","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:796"}},{"Add":{"text":"-- grandfathered_at marks such vouching reviews: NON-NULL means \"grandfathered","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:875"}},{"Add":{"text":"-- at this instant\", and those reviews count regardless of authorship (both in","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:954"}},{"Add":{"text":"-- the change-list needs_review flag and in the push-time enforcement). NULL =","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1033"}},{"Add":{"text":"-- an ordinary review, still subject to the distinct-non-author rule.","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1103"}},{"Add":{"text":"--","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1106"}},{"Add":{"text":"-- Nullable, default NULL: existing rows and all normal reviews are unaffected.","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1186"}},{"Add":{"text":"ALTER TABLE review_comments ADD COLUMN grandfathered_at TIMESTAMPTZ;","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1255"}},{"Add":{"text":"","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1256"}},{"Add":{"text":"GRANT ALL PRIVILEGES ON review_comments TO pijul;","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1306"}}]}},{"FileAdd":{"meta":{"basename":"down.sql","metadata":0},"context":[{"change":0,"pos":379}],"contents":[{"Add":{"text":"ALTER TABLE review_comments DROP COLUMN grandfathered_at;","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1399"}}]}},{"Edit":{"inode":{"change":2,"pos":424301},"path":"api/src/repository/admin.rs","line":536,"atom":{"NewVertex":{"up_context":[{"change":6,"pos":21906}],"down_context":[{"change":6,"pos":21906}],"flag":"BLOCK","start":1401,"end":1464,"inode":{"change":2,"pos":424301}}},"contents":[{"Add":{"text":" rc::grandfathered_at.eq(diesel::dsl::now),","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1463"}}]}},{"Edit":{"inode":{"change":2,"pos":431834},"path":"api/src/replication.rs","line":803,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":16205}],"down_context":[{"change":5,"pos":16205}],"flag":"BLOCK","start":1465,"end":1782,"inode":{"change":2,"pos":431834}}},"contents":[{"Add":{"text":" // Retain a reviewed change even when it lands in no channel, so its","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1545"}},{"Add":{"text":" // review isn't left pointing at a deleted file.","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1606"}},{"Add":{"text":" if hash_has_review(db, repo, h).await {","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1658"}},{"Add":{"text":" debug!(\"keeping orphaned change {} (has reviews)\", h.to_base32());","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1741"}},{"Add":{"text":" continue;","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1767"}},{"Add":{"text":" }","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1781"}}]}},{"Edit":{"inode":{"change":2,"pos":521565},"path":"api/src/db.rs","line":346,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":55205}],"down_context":[{"change":2,"pos":526552}],"flag":"BLOCK","start":1783,"end":1834,"inode":{"change":2,"pos":521565}}},"contents":[{"Add":{"text":" grandfathered_at -> Nullable,","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1833"}}]}},{"Replacement":{"inode":{"change":2,"pos":554127},"path":"api/src/change/list.rs","line":244,"ins":{"up_context":[{"change":6,"pos":36906}],"down_context":[{"change":6,"pos":37309}],"flag":"BLOCK","start":1835,"end":2343,"inode":{"change":2,"pos":554127}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":36906},"to":{"change":6,"start":36906,"end":37309},"introduced_by":6}],"inode":{"change":2,"pos":554127}},"ins_contents":[{"Add":{"text":" let rows: Vec<(String, Option, Option>)> =","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1927"}},{"Add":{"text":" rc::review_comments","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:1963"}},{"Add":{"text":" .left_join(u::users.on(u::id.nullable().eq(rc::author)))","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2040"}},{"Add":{"text":" .filter(rc::repository_id.eq(id))","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2094"}},{"Add":{"text":" .filter(rc::change.eq_any(&hash_strs))","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2153"}},{"Add":{"text":" .select((rc::change, u::login.nullable(), rc::grandfathered_at))","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2238"}},{"Add":{"text":" .load(&mut db)","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2273"}},{"Add":{"text":" .await","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2300"}},{"Add":{"text":" .unwrap_or_default();","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2342"}}],"del_contents":[{"Del":{"text":" let rows: Vec<(String, Option)> = rc::review_comments","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:36979"}},{"Del":{"text":" .left_join(u::users.on(u::id.nullable().eq(rc::author)))","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:37052"}},{"Del":{"text":" .filter(rc::repository_id.eq(id))","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:37102"}},{"Del":{"text":" .filter(rc::change.eq_any(&hash_strs))","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:37157"}},{"Del":{"text":" .select((rc::change, u::login.nullable()))","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:37216"}},{"Del":{"text":" .load(&mut db)","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:37247"}},{"Del":{"text":" .await","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:37270"}},{"Del":{"text":" .unwrap_or_default();","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:37308"}}]}},{"Replacement":{"inode":{"change":2,"pos":554127},"path":"api/src/change/list.rs","line":255,"ins":{"up_context":[{"change":6,"pos":37443}],"down_context":[{"change":6,"pos":37485}],"flag":"BLOCK","start":2344,"end":2712,"inode":{"change":2,"pos":554127}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":37443},"to":{"change":6,"start":37443,"end":37485},"introduced_by":6}],"inode":{"change":2,"pos":554127}},"ins_contents":[{"Add":{"text":" // A grandfathered \"review all\" vouches for existing history and","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2420"}},{"Add":{"text":" // counts regardless of who authored the patch.","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2480"}},{"Add":{"text":" let mut grandfathered: HashSet = HashSet::new();","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2549"}},{"Add":{"text":" for (change, login, gf_at) in rows {","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2598"}},{"Add":{"text":" if gf_at.is_some() {","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2635"}},{"Add":{"text":" grandfathered.insert(change.clone());","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2693"}},{"Add":{"text":" }","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2711"}}],"del_contents":[{"Del":{"text":" for (change, login) in rows {","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:37484"}}]}},{"Replacement":{"inode":{"change":2,"pos":554127},"path":"api/src/change/list.rs","line":275,"ins":{"up_context":[{"change":6,"pos":37993}],"down_context":[{"change":6,"pos":38195}],"flag":"BLOCK","start":2713,"end":2978,"inode":{"change":2,"pos":554127}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":37993},"to":{"change":6,"start":37993,"end":38195},"introduced_by":6}],"inode":{"change":2,"pos":554127}},"ins_contents":[{"Add":{"text":" let has_review = grandfathered.contains(&hs)","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2773"}},{"Add":{"text":" || reviewers","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2806"}},{"Add":{"text":" .get(&hs)","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2840"}},{"Add":{"text":" .map(|revs| revs.iter().any(|r| !author_logins.contains(r.as_str())))","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2934"}},{"Add":{"text":" .unwrap_or(false);","pos":"OJUGWEVPQPIE2SH3ECNWC7XBW7E6GJ64YSPQAWXVAYN5IJTRTXHQC:2977"}}],"del_contents":[{"Del":{"text":" let has_review = reviewers","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:38035"}},{"Del":{"text":" .get(&hs)","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:38065"}},{"Del":{"text":" .map(|revs| revs.iter().any(|r| !author_logins.contains(r.as_str())))","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:38155"}},{"Del":{"text":" .unwrap_or(false);","pos":"IXMVMCZMQP2DJL3VILNPIJPOM6N7H2Z5DSFEIDCX7NE5CDTKDTTAC:38194"}}]}}],"owner":"pijul","repo":"nest","token":"/oHNsxmgilTVKFORX1vrAYQUfz53pkpSx+wL0gFWioU=","login":null}

…

Dependencies

Change contents

Review