{"header":{"message":"Review workflow: add author in discussion, not pusher","description":null,"timestamp":"2026-08-05T15:35:36.518553509Z","authors":[{}]},"hash":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC","authors":[{"login":"pmeunier","key":"AAAAC3NzaC1lZDI1NTE5AAAAILagOJFgwaMNhBWQINinKOXmqS4Gh5NgxgriXwdOoINJ"}],"deps":{"hashes":[["PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC","Review workflow: add author in discussion, not pusher"],["AA",null],["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","Initial patch"],["YYJ76Q7V6G7FHSNZ25MU3ZZY5KGXIODBHLWOZUGB4FIKL7PUCNAAC","Initial attempt at CI/CD"],["AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","Redesign (fat change)"],["HY6KW56TNL5TWFPDQLZBDURE2DZSHKSBDKW53VQOR55DSEU7I7QQC","Missing files"],["DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC","Handling --amend from the Nest (unrecord + apply)"],["XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC","Notifications"],["KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC","Zulip mentions in notifications"],["KUJXFMTMOVHBULDQ7O24QUKTAZAZJT7CNQFZPMHZQSJPE52A5HDQC","Improving the review process"],["KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC","Improving the review workflow"],["T67XALXLSMSQTWVDVRXL3J4T3BBUSUEBXBWU6ZZZTWXSPTUCT4OAC","Improve patch approvals in discussions"],["G73NDZAN4APVCNWV6BY6S3P7K3BXONXNZQH3RQEJLABHJNBQ2QZQC","review: todo list"]],"deps":["D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC","YYJ76Q7V6G7FHSNZ25MU3ZZY5KGXIODBHLWOZUGB4FIKL7PUCNAAC","AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC","HY6KW56TNL5TWFPDQLZBDURE2DZSHKSBDKW53VQOR55DSEU7I7QQC","DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC","XBFWSWLKEYA65GAGZFSJG34OXJWWXEHXZY7I66H2Z7BLRGEGQ43AC","KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC","KUJXFMTMOVHBULDQ7O24QUKTAZAZJT7CNQFZPMHZQSJPE52A5HDQC","KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC","T67XALXLSMSQTWVDVRXL3J4T3BBUSUEBXBWU6ZZZTWXSPTUCT4OAC"],"known":["G73NDZAN4APVCNWV6BY6S3P7K3BXONXNZQH3RQEJLABHJNBQ2QZQC"]},"hunks":[{"Replacement":{"inode":{"change":12,"pos":719},"path":"ui/src/routes/reviews/+page.svelte","line":58,"ins":{"up_context":[{"change":9,"pos":1276}],"down_context":[{"change":9,"pos":1401}],"flag":"BLOCK","start":0,"end":156,"inode":{"change":12,"pos":719}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":9,"pos":1276},"to":{"change":9,"start":1276,"end":1401},"introduced_by":9}],"inode":{"change":12,"pos":719}},"ins_contents":[{"Add":{"text":" // Command a reviewer copies to land an approved patch: pull the discussion's","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:79"}},{"Add":{"text":" // channel, then push exactly this change (never whatever else is local).","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:155"}}],"del_contents":[{"Del":{"text":" // Command a reviewer copies to land an approved patch (matches `pijul pull","pos":"KUJXFMTMOVHBULDQ7O24QUKTAZAZJT7CNQFZPMHZQSJPE52A5HDQC:1353"}},{"Del":{"text":" // :N && pijul push --to-channel `).","pos":"KUJXFMTMOVHBULDQ7O24QUKTAZAZJT7CNQFZPMHZQSJPE52A5HDQC:1400"}}]}},{"Replacement":{"inode":{"change":12,"pos":719},"path":"ui/src/routes/reviews/+page.svelte","line":61,"ins":{"up_context":[{"change":9,"pos":1443}],"down_context":[{"change":9,"pos":1511}],"flag":"BLOCK","start":157,"end":255,"inode":{"change":12,"pos":719}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":9,"pos":1443},"to":{"change":9,"start":1443,"end":1511},"introduced_by":9}],"inode":{"change":12,"pos":719}},"ins_contents":[{"Add":{"text":" `pijul pull --from-channel :${a.disc} && pijul push --to-channel ${a.target} -- ${a.change}`;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:254"}}],"del_contents":[{"Del":{"text":" `pijul pull :${a.disc} && pijul push --to-channel ${a.target}`;","pos":"KUJXFMTMOVHBULDQ7O24QUKTAZAZJT7CNQFZPMHZQSJPE52A5HDQC:1510"}}]}},{"Edit":{"inode":{"change":2,"pos":63218},"path":"ui/src/routes/[user]/[repo]/discussion/[disc]/+page.svelte","line":91,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":4759318}],"down_context":[{"change":10,"pos":0}],"flag":"BLOCK","start":256,"end":675,"inode":{"change":2,"pos":63218}}},"contents":[{"Add":{"text":" // The discussion's currently-attached (non-removed) patch hashes, deduplicated.","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:338"}},{"Add":{"text":" // Passing them explicitly to `pijul push` lands exactly this discussion's","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:415"}},{"Add":{"text":" // patches — never whatever else happens to be in the local channel.","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:488"}},{"Add":{"text":" let patchHashes = $derived([","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:519"}},{"Add":{"text":" ...new Set(","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:535"}},{"Add":{"text":" comments","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:550"}},{"Add":{"text":" .map((c) => c.patch)","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:579"}},{"Add":{"text":" .filter((p): p is Patch_ => !!p && !p.removed)","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:634"}},{"Add":{"text":" .map((p) => p.hash)","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:662"}},{"Add":{"text":" )","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:668"}},{"Add":{"text":" ]);","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:674"}}]}},{"Replacement":{"inode":{"change":2,"pos":63218},"path":"ui/src/routes/[user]/[repo]/discussion/[disc]/+page.svelte","line":103,"ins":{"up_context":[{"change":10,"pos":26}],"down_context":[{"change":10,"pos":108}],"flag":"BLOCK","start":676,"end":840,"inode":{"change":2,"pos":63218}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":10,"pos":26},"to":{"change":10,"start":26,"end":108},"introduced_by":10}],"inode":{"change":2,"pos":63218}},"ins_contents":[{"Add":{"text":" `pijul pull --from-channel :${data.d.n} && pijul push --to-channel ${data.d.pull_to_branch}` +","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:774"}},{"Add":{"text":" (patchHashes.length ? ` -- ${patchHashes.join(' ')}` : '')","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:839"}}],"del_contents":[{"Del":{"text":" `pijul pull :${data.d.n} && pijul push --to-channel ${data.d.pull_to_branch}`","pos":"KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC:107"}}]}},{"Edit":{"inode":{"change":2,"pos":68505},"path":"ui/src/routes/[user]/[repo]/discussion/Patch.svelte","line":47,"atom":{"NewVertex":{"up_context":[{"change":3,"pos":8844}],"down_context":[{"change":2,"pos":69171}],"flag":"BLOCK","start":841,"end":1883,"inode":{"change":2,"pos":68505}}},"contents":[{"Add":{"text":"","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:841"}},{"Add":{"text":" // The change's primary author drives the identity shown (avatar + name); the","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:921"}},{"Add":{"text":" // pusher is secondary (\"pushed by …\"). They differ when someone regroups","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:999"}},{"Add":{"text":" // another person's patches onto a discussion. Fall back to the pusher only","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1077"}},{"Add":{"text":" // when the change carries no author at all.","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1124"}},{"Add":{"text":" const author = $derived(authors[0]);","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1163"}},{"Add":{"text":" const authorName = $derived(author?.login ?? author?.name ?? author?.key ?? pushed_by);","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1253"}},{"Add":{"text":" const authorLogin = $derived(author?.login ?? null);","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1308"}},{"Add":{"text":" // Identicon seed: a stable string per author (login, else name, else key).","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1386"}},{"Add":{"text":" const authorSeed = $derived(author?.login ?? author?.name ?? author?.key ?? pushed_by);","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1476"}},{"Add":{"text":" const pusherIsAuthor = $derived(authorLogin !== null && authorLogin === pushed_by);","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1562"}},{"Add":{"text":" // Only the change's *author* is barred from approving their own patch (the","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1640"}},{"Add":{"text":" // server enforces this on authorship, not on who pushed). So a reviewer who","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1719"}},{"Add":{"text":" // merely pushed someone else's patch onto the discussion may still approve it.","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1801"}},{"Add":{"text":" const iAmAuthor = $derived(!!login && authors.some((a) => a.login === login));","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1882"}}]}},{"Replacement":{"inode":{"change":2,"pos":68505},"path":"ui/src/routes/[user]/[repo]/discussion/Patch.svelte","line":66,"ins":{"up_context":[{"change":4,"pos":4764053}],"down_context":[{"change":2,"pos":69423}],"flag":"BLOCK","start":1884,"end":2057,"inode":{"change":2,"pos":68505}},"del":{"edges":[{"previous":"","flag":"DELETED","from":{"change":4,"pos":4764053},"to":{"change":2,"start":69291,"end":69319},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":69291},"to":{"change":2,"start":69291,"end":69319},"introduced_by":2},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":69319},"to":{"change":4,"start":4764054,"end":4764095},"introduced_by":4},{"previous":"","flag":"DELETED","from":{"change":4,"pos":4764095},"to":{"change":2,"start":69414,"end":69423},"introduced_by":4},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":2,"pos":69414},"to":{"change":2,"start":69414,"end":69423},"introduced_by":2}],"inode":{"change":2,"pos":68505}},"ins_contents":[{"Add":{"text":" {#if authorLogin}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1905"}},{"Add":{"text":" ","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1937"}},{"Add":{"text":" ","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1981"}},{"Add":{"text":" ","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:1992"}},{"Add":{"text":" {:else}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2004"}},{"Add":{"text":" ","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2046"}},{"Add":{"text":" {/if}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2056"}}],"del_contents":[{"Del":{"text":" ","pos":"D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC:69318"}},{"Del":{"text":" ","pos":"AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC:4764094"}},{"Del":{"text":" ","pos":"D4SBRY6KHEAMGUEVWSUYHNCRYXCOC5JJ3N3DQ47ZXOXQGT73VERAC:69422"}}]}},{"Replacement":{"inode":{"change":2,"pos":68505},"path":"ui/src/routes/[user]/[repo]/discussion/Patch.svelte","line":77,"ins":{"up_context":[{"change":4,"pos":4764193}],"down_context":[{"change":4,"pos":4764300}],"flag":"BLOCK","start":2058,"end":2406,"inode":{"change":2,"pos":68505}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":4,"pos":4764193},"to":{"change":4,"start":4764193,"end":4764300},"introduced_by":4}],"inode":{"change":2,"pos":68505}},"ins_contents":[{"Add":{"text":" {#if authorLogin}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2081"}},{"Add":{"text":" {authorName}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2146"}},{"Add":{"text":" {:else}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2160"}},{"Add":{"text":" {authorName}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2209"}},{"Add":{"text":" {/if}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2221"}},{"Add":{"text":" authored a change","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2270"}},{"Add":{"text":" {#if !pusherIsAuthor}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2298"}},{"Add":{"text":" · pushed by {pushed_by}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2393"}},{"Add":{"text":" {/if}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2405"}}],"del_contents":[{"Del":{"text":" {pushed_by}","pos":"AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC:4764252"}},{"Del":{"text":" pushed a change","pos":"AX7NN2MQXFV32SW32M2NKYGSLA775AWFIWUWX3R5YAMPG32HMZMQC:4764299"}}]}},{"Replacement":{"inode":{"change":2,"pos":68505},"path":"ui/src/routes/[user]/[repo]/discussion/Patch.svelte","line":104,"ins":{"up_context":[{"change":11,"pos":488}],"down_context":[{"change":9,"pos":8305}],"flag":"BLOCK","start":2407,"end":2456,"inode":{"change":2,"pos":68505}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":11,"pos":488},"to":{"change":11,"start":488,"end":546},"introduced_by":11}],"inode":{"change":2,"pos":68505}},"ins_contents":[{"Add":{"text":" {:else if !removed && login && !iAmAuthor}","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2455"}}],"del_contents":[{"Del":{"text":" {:else if !removed && login && login !== pushed_by}","pos":"T67XALXLSMSQTWVDVRXL3J4T3BBUSUEBXBWU6ZZZTWXSPTUCT4OAC:545"}}]}},{"Edit":{"inode":{"change":2,"pos":68505},"path":"ui/src/routes/[user]/[repo]/discussion/Patch.svelte","line":186,"atom":{"NewVertex":{"up_context":[{"change":4,"pos":4765981}],"down_context":[{"change":4,"pos":4765981}],"flag":"BLOCK","start":2457,"end":2585,"inode":{"change":2,"pos":68505}}},"contents":[{"Add":{"text":" .pushed-by a {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2473"}},{"Add":{"text":" color: inherit;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2493"}},{"Add":{"text":" text-decoration: none;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2520"}},{"Add":{"text":" }","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2524"}},{"Add":{"text":" .pushed-by a:hover {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2547"}},{"Add":{"text":" color: var(--color-primary);","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2580"}},{"Add":{"text":" }","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2584"}}]}},{"Replacement":{"inode":{"change":7,"pos":7843},"path":"api/src/notify.rs","line":455,"ins":{"up_context":[{"change":7,"pos":15398}],"down_context":[{"change":8,"pos":4313}],"flag":"BLOCK","start":2586,"end":3274,"inode":{"change":7,"pos":7843}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":7,"pos":15398},"to":{"change":8,"start":3959,"end":4039},"introduced_by":8},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":8,"pos":4039},"to":{"change":10,"start":28687,"end":28871},"introduced_by":10},{"previous":"","flag":"DELETED","from":{"change":10,"pos":28871},"to":{"change":8,"start":4109,"end":4193},"introduced_by":10},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":8,"pos":4109},"to":{"change":8,"start":4109,"end":4193},"introduced_by":8},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":8,"pos":4193},"to":{"change":10,"start":28872,"end":28930},"introduced_by":10},{"previous":"","flag":"DELETED","from":{"change":10,"pos":28930},"to":{"change":8,"start":4256,"end":4313},"introduced_by":10},{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":8,"pos":4256},"to":{"change":8,"start":4256,"end":4313},"introduced_by":8}],"inode":{"change":7,"pos":7843}},"ins_contents":[{"Add":{"text":" // 1. Zulip stream post — always, unless the caller left `zulip` empty to","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2665"}},{"Add":{"text":" // suppress it (the event is mirrored into a discussion's own topic instead;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2746"}},{"Add":{"text":" // see `change/comments.rs`). @-mention any target matched to a Zulip account","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2828"}},{"Add":{"text":" // (by shared email) so it highlights for them there too. The mention leads","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2908"}},{"Add":{"text":" // the message so it reads as a real, inline ping rather than a trailing","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:2985"}},{"Add":{"text":" // \"(cc …)\".","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3004"}},{"Add":{"text":" if !event.zulip.trim().is_empty() {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3044"}},{"Add":{"text":" let content = if mentions.is_empty() {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3091"}},{"Add":{"text":" event.zulip.clone()","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3123"}},{"Add":{"text":" } else {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3140"}},{"Add":{"text":" format!(\"{} {}\", mentions.join(\" \"), event.zulip)","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3202"}},{"Add":{"text":" };","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3213"}},{"Add":{"text":" zulip(n, event.kind.topic(), &content).await;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3267"}},{"Add":{"text":" }","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3273"}}],"del_contents":[{"Del":{"text":" // 1. Zulip stream post — always. @-mention any target matched to a Zulip","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4038"}},{"Del":{"text":" // account (by shared email) so it highlights for them there too. The","pos":"KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC:28760"}},{"Del":{"text":" // mention leads the message so it reads as a real, inline ping rather than","pos":"KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC:28840"}},{"Del":{"text":" // a trailing \"(cc …)\".","pos":"KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC:28870"}},{"Del":{"text":" let content = if mentions.is_empty() {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4151"}},{"Del":{"text":" event.zulip.clone()","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4179"}},{"Del":{"text":" } else {","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4192"}},{"Del":{"text":" format!(\"{} {}\", mentions.join(\" \"), event.zulip)","pos":"KGDFZBKHKSAPAIW75LMTJ67PXP2KR7TLACFB7EIOQYHFQVQUJH3AC:28929"}},{"Del":{"text":" };","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4262"}},{"Del":{"text":" zulip(n, event.kind.topic(), &content).await;","pos":"KYWMDDGZTYQVRUO5QIXPLEPMW6JG5EDR2GO523XIPQZCB5B6577AC:4312"}}]}},{"Edit":{"inode":{"change":5,"pos":5383},"path":"api/src/change/comments.rs","line":290,"atom":{"NewVertex":{"up_context":[{"change":5,"pos":12709}],"down_context":[{"change":6,"pos":31817}],"flag":"BLOCK","start":3275,"end":4152,"inode":{"change":5,"pos":5383}}},"contents":[{"Add":{"text":"","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3275"}},{"Add":{"text":" // Discussions this patch is currently attached to. An approve / request-","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3353"}},{"Add":{"text":" // changes verdict on a patch that lives in a discussion is a *discussion*","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3432"}},{"Add":{"text":" // event (just like the patch's arrival), so it is mirrored into that","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3506"}},{"Add":{"text":" // discussion's own Zulip topic below rather than the generic \"Reviews\" topic.","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3589"}},{"Add":{"text":" let discs: Vec<(uuid::Uuid, i32, String)> = {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3639"}},{"Add":{"text":" use crate::db::discussion_changes::dsl as dc;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3693"}},{"Add":{"text":" use crate::db::discussions::dsl as d;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3739"}},{"Add":{"text":" dc::discussion_changes","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3770"}},{"Add":{"text":" .inner_join(d::discussions)","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3810"}},{"Add":{"text":" .filter(dc::change.eq(&p.hash))","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3854"}},{"Add":{"text":" .filter(dc::removed.is_null())","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3897"}},{"Add":{"text":" .filter(d::repository_id.eq(id))","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3942"}},{"Add":{"text":" .select((d::id, d::number, d::title))","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:3992"}},{"Add":{"text":" .get_results::<(uuid::Uuid, i32, String)>(&mut db)","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4055"}},{"Add":{"text":" .await","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4074"}},{"Add":{"text":" .unwrap_or_default()","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4107"}},{"Add":{"text":" };","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4114"}},{"Add":{"text":" let in_disc = !discs.is_empty();","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4151"}}]}},{"Edit":{"inode":{"change":5,"pos":5383},"path":"api/src/change/comments.rs","line":370,"atom":{"NewVertex":{"up_context":[{"change":10,"pos":35728}],"down_context":[{"change":6,"pos":32291}],"flag":"BLOCK","start":4153,"end":4572,"inode":{"change":5,"pos":5383}}},"contents":[{"Add":{"text":" // A verdict on a discussion-linked patch is announced in the discussion's","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4235"}},{"Add":{"text":" // Zulip topic (below), so keep the author's personal ping but drop the","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4315"}},{"Add":{"text":" // duplicate generic \"Reviews\" stream post here.","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4372"}},{"Add":{"text":" let is_verdict = matches!(","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4407"}},{"Add":{"text":" kind,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4425"}},{"Add":{"text":" crate::notify::Kind::PatchApproved | crate::notify::Kind::ChangesRequested","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4512"}},{"Add":{"text":" );","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4523"}},{"Add":{"text":" let skip_zulip = is_verdict && in_disc;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4571"}}]}},{"Edit":{"inode":{"change":5,"pos":5383},"path":"api/src/change/comments.rs","line":382,"atom":{"NewVertex":{"up_context":[{"change":6,"pos":32444}],"down_context":[{"change":6,"pos":32444}],"flag":"BLOCK","start":4573,"end":4609,"inode":{"change":5,"pos":5383}}},"contents":[{"Add":{"text":" let login2 = login.clone();","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4608"}}]}},{"Replacement":{"inode":{"change":5,"pos":5383},"path":"api/src/change/comments.rs","line":402,"ins":{"up_context":[{"change":6,"pos":33144}],"down_context":[{"change":6,"pos":33228}],"flag":"BLOCK","start":4610,"end":4695,"inode":{"change":5,"pos":5383}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":33144},"to":{"change":6,"start":33144,"end":33228},"introduced_by":6}],"inode":{"change":5,"pos":5383}},"ins_contents":[{"Add":{"text":" title: format!(\"{} {} your change {}\", login2, verb, short),","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4694"}}],"del_contents":[{"Del":{"text":" title: format!(\"{} {} your change {}\", login, verb, short),","pos":"DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC:33227"}}]}},{"Replacement":{"inode":{"change":5,"pos":5383},"path":"api/src/change/comments.rs","line":404,"ins":{"up_context":[{"change":6,"pos":33270}],"down_context":[{"change":6,"pos":33460}],"flag":"BLOCK","start":4696,"end":5044,"inode":{"change":5,"pos":5383}},"del":{"edges":[{"previous":"BLOCK","flag":"BLOCK | DELETED","from":{"change":6,"pos":33270},"to":{"change":6,"start":33270,"end":33460},"introduced_by":6}],"inode":{"change":5,"pos":5383}},"ins_contents":[{"Add":{"text":" zulip: if skip_zulip {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4742"}},{"Add":{"text":" String::new()","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4784"}},{"Add":{"text":" } else {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4817"}},{"Add":{"text":" format!(","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4854"}},{"Add":{"text":" \"**{}** {} change [{}]({}{})\",","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4917"}},{"Add":{"text":" login2, verb, short, n.hostname, url","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:4986"}},{"Add":{"text":" )","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5016"}},{"Add":{"text":" },","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5043"}}],"del_contents":[{"Del":{"text":" zulip: format!(","pos":"DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC:33309"}},{"Del":{"text":" \"**{}** {} change [{}]({}{})\",","pos":"DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC:33368"}},{"Del":{"text":" login, verb, short, n.hostname, url","pos":"DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC:33432"}},{"Del":{"text":" ),","pos":"DHKUBIY6MUOZ3R6LDZ236LVLGK4CT5X6VFGIPCXQ5W5S34ACZLFQC:33459"}}]}},{"Edit":{"inode":{"change":5,"pos":5383},"path":"api/src/change/comments.rs","line":413,"atom":{"NewVertex":{"up_context":[{"change":6,"pos":33483}],"down_context":[{"change":6,"pos":33483}],"flag":"BLOCK","start":5045,"end":6378,"inode":{"change":5,"pos":5383}}},"contents":[{"Add":{"text":" )","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5062"}},{"Add":{"text":" .await;","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5086"}},{"Add":{"text":" }","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5100"}},{"Add":{"text":" });","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5112"}},{"Add":{"text":" }","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5118"}},{"Add":{"text":"","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5119"}},{"Add":{"text":" // Mirror an approve / request-changes verdict into the Zulip topic of every","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5200"}},{"Add":{"text":" // discussion the patch belongs to — a review decision is a discussion event,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5284"}},{"Add":{"text":" // so it lands in the discussion thread alongside the patch's arrival and any","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5366"}},{"Add":{"text":" // comments. Metadata only, no comment body. No-op when the patch isn't in a","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5447"}},{"Add":{"text":" // discussion, or when this isn't a verdict.","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5496"}},{"Add":{"text":" if let Some(v) = verdict {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5527"}},{"Add":{"text":" let config2 = config.clone();","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5565"}},{"Add":{"text":" let owner = repo.owner.clone();","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5605"}},{"Add":{"text":" let repo_name = repo.repo.clone();","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5648"}},{"Add":{"text":" let hash = p.hash.clone();","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5683"}},{"Add":{"text":" let login2 = login.clone();","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5719"}},{"Add":{"text":" crate::tracked_spawn(async move {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5761"}},{"Add":{"text":" let short = hash.get(..10).unwrap_or(&hash);","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5818"}},{"Add":{"text":" let body = match v {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5851"}},{"Add":{"text":" \"approve\" => format!(\"_approved patch `{}`_\", short),","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5921"}},{"Add":{"text":" _ => format!(\"_requested changes on patch `{}`_\", short),","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:5995"}},{"Add":{"text":" };","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6010"}},{"Add":{"text":" for (disc_id, number, title) in discs {","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6062"}},{"Add":{"text":" crate::zulip_bridge::mirror_comment(","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6115"}},{"Add":{"text":" &config2,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6145"}},{"Add":{"text":" disc_id,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6174"}},{"Add":{"text":" &owner,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6202"}},{"Add":{"text":" &repo_name,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6234"}},{"Add":{"text":" number,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6262"}},{"Add":{"text":" &title,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6290"}},{"Add":{"text":" &login2,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6319"}},{"Add":{"text":" Some(uid),","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6350"}},{"Add":{"text":" &body,","pos":"PZOJXDJXK2T6DSQBV5IBSWT6TQH7XN4SODHBTKEZJ3DP5XL7C77AC:6377"}}]}}],"owner":"pijul","repo":"nest","token":"3/qRpahe8kQmh9jKpyiv21xJr1GB9u+GIqv3syAXOYI=","login":null}

…

Dependencies

Change contents

Review