pijul/pijul - Change AGIWDANQSFIBVXOLSFRUMR33NBAJATI2HRCSCHEU72OJAIFUQ7AAC

address less controversial clippy lints

Created by danieleades on November 30, 2020

AGIWDANQSFIBVXOLSFRUMR33NBAJATI2HRCSCHEU72OJAIFUQ7AAC

Dependencies

In discussions

#143 Clippy Lints

Change contents

Replacement in pijul-macros/src/lib.rs at line 17 [3.445]

B:BD[3.765] → [3.765:814]

                s.to_uppercase().nth(0).unwrap()

[3.765]

[3.814]

                s.to_uppercase().next().unwrap()

Replacement in libpijul/src/working_copy/memory.rs at line 135 [3.199222]
B:BD[3.203279] → [3.203279:203319]
```
        while let Some(c) = it.next() {
```
[3.203279]
[3.203319]
```
        for c in it {
```

Replacement in libpijul/src/pristine/hash.rs at line 73 [3.644439]

B:BD[3.646354] → [3.646354:646434]

        if s.len() >= 1 + BLAKE3_BYTES && s[0] == HashAlgorithm::Blake3 as u8 {

[3.646354]

[3.646434]

        if s.len() > BLAKE3_BYTES && s[0] == HashAlgorithm::Blake3 as u8 {

Replacement in libpijul/src/diff/mod.rs at line 197 [3.793247]
B:BD[3.800297] → [3.800297:800333]
```
                path: path.clone(),
```
[3.800297]
[3.800333]
```
                path,
```

Replacement in libpijul/src/change.rs at line 170 [3.831311]

B:BD[3.836629] → [3.836629:836683]

                            deps.insert(dep.clone());

[3.836629]

[3.836683]

                            deps.insert(dep);

Deletion in libpijul/src/change.rs at line 318 [3.831311]

B:BD[3.841207] → [3.841207:841331]

            }
        } else {
            if internal_deps_.remove(&id) {
                debug!("removing dep {:?}", id);

Insertion in libpijul/src/change.rs at line 319 [3.831311]

[3.841345]

        } else if internal_deps_.remove(&id) {
            debug!("removing dep {:?}", id);

Replacement in libpijul/src/change.rs at line 1649 [3.831311]
B:BD[3.887744] → [3.887744:887782]
```
                    write!(w, "\n")?;
```
[3.887744]
[3.887782]
```
                    writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1667 [3.831311]
B:BD[3.888474] → [3.888474:888512]
```
                    write!(w, "\n")?;
```
[3.888474]
[3.888512]
```
                    writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1679 [3.831311]
B:BD[3.888888] → [3.888888:888922]
```
                write!(w, "\n")?;
```
[3.888888]
[3.888922]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1683 [3.831311]
B:BD[3.889088] → [3.889088:889126]
```
                    write!(w, "\n")?;
```
[3.889088]
[3.889126]
```
                    writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1686 [3.831311]
B:BD[3.889239] → [3.889239:889277]
```
                    write!(w, "\n")?;
```
[3.889239]
[3.889277]
```
                    writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1696 [3.831311]
B:BD[3.889551] → [3.889551:889585]
```
                write!(w, "\n")?;
```
[3.889551]
[3.889585]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1702 [3.831311]
B:BD[3.889866] → [3.889866:889904]
```
                    write!(w, "\n")?;
```
[3.889866]
[3.889904]
```
                    writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1751 [3.831311]
B:BD[3.891869] → [3.891869:891903]
```
                writeln!(w, "")?;
```
[3.891869]
[3.891903]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1762 [3.831311]
B:BD[3.892327] → [3.892327:892361]
```
                writeln!(w, "")?;
```
[3.892327]
[3.892361]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1773 [3.831311]
B:BD[3.892938] → [3.892938:892972]
```
                write!(w, "\n")?;
```
[3.892938]
[3.892972]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1781 [3.831311]
B:BD[3.893324] → [3.893324:893358]
```
                write!(w, "\n")?;
```
[3.893324]
[3.893358]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1791 [3.831311]
B:BD[3.893723] → [3.893723:893757]
```
                writeln!(w, "")?;
```
[3.893723]
[3.893757]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1802 [3.831311]
B:BD[3.894129] → [3.894129:894163]
```
                writeln!(w, "")?;
```
[3.894129]
[3.894163]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 1813 [3.831311]
B:BD[3.894429] → [2.94:128]
```
                writeln!(w, "")?;
```
[3.894429]
[3.894486]
```
                writeln!(w)?;
```
Replacement in libpijul/src/change.rs at line 2667 [3.831311]
B:BD[3.927244] → [3.927244:927270]
```
        write!(w, "\n")?;
```
[3.927244]
[3.927270]
```
        writeln!(w)?;
```

Replacement in libpijul/src/alive/dfs.rs at line 294 [3.1000429]

B:BD[3.1010169] → [3.1010169:1010233]

        .flat_map(|side| side.sccs.iter())
        .map(|&x| x)

[3.1010169]

[3.1010233]

        .flat_map(|side| side.sccs.iter()).copied()

Replacement in libpijul/src/alive/dfs.rs at line 369 [3.1000429]
B:BD[3.1012785] → [3.1012785:1012842]
```
    main_side.sccs.extend(side.sccs.iter().map(|&x| x));
```
[3.1012785]
[3.1012842]
```
    main_side.sccs.extend(side.sccs.iter().copied());
```

address less controversial clippy lints

Dependencies

In discussions

Change contents

Replacement in pijul-macros/src/lib.rs at line 17 [3.445]

Replacement in libpijul/src/working_copy/memory.rs at line 135 [3.199222]

Replacement in libpijul/src/pristine/hash.rs at line 73 [3.644439]

Replacement in libpijul/src/diff/mod.rs at line 197 [3.793247]

Replacement in libpijul/src/change.rs at line 170 [3.831311]

Deletion in libpijul/src/change.rs at line 318 [3.831311]

Insertion in libpijul/src/change.rs at line 319 [3.831311]

Replacement in libpijul/src/change.rs at line 1649 [3.831311]

Replacement in libpijul/src/change.rs at line 1667 [3.831311]

Replacement in libpijul/src/change.rs at line 1679 [3.831311]

Replacement in libpijul/src/change.rs at line 1683 [3.831311]

Replacement in libpijul/src/change.rs at line 1686 [3.831311]

Replacement in libpijul/src/change.rs at line 1696 [3.831311]

Replacement in libpijul/src/change.rs at line 1702 [3.831311]

Replacement in libpijul/src/change.rs at line 1751 [3.831311]

Replacement in libpijul/src/change.rs at line 1762 [3.831311]

Replacement in libpijul/src/change.rs at line 1773 [3.831311]

Replacement in libpijul/src/change.rs at line 1781 [3.831311]

Replacement in libpijul/src/change.rs at line 1791 [3.831311]

Replacement in libpijul/src/change.rs at line 1802 [3.831311]

Replacement in libpijul/src/change.rs at line 1813 [3.831311]

Replacement in libpijul/src/change.rs at line 2667 [3.831311]

Replacement in libpijul/src/alive/dfs.rs at line 294 [3.1000429]

Replacement in libpijul/src/alive/dfs.rs at line 369 [3.1000429]