The sound distributed version control system

#222 Minor cleanup, the third

Closed on January 11, 2021
Ralith on December 11, 2020

Third time’s the charm!

Ralith added a change on December 11, 2020
Simplify Author serde attributes created on December 10, 2020
U5CWXSSVRSIA44LK67WJ2TGOR6MSRM7XE5H3JYIVVIBFTLLCJ67QC
Ralith added a change on December 11, 2020
JN34NIMJ6H5QCFANKBPXIO5XUHUCZUNU6EODA2UVW4L6UXROXFOQC
main
Ralith added a change on December 11, 2020
KQMYXYTSSEJBMNGBPNX2S2RG2NUPOJCLPBSI6UOLUI3E6I3C4MCAC
main
pmeunier on December 11, 2020

Nice! Finally!

The only tricky thing at the moment is that there have been debates about libpijul’s license (way too much for my taste, actually).

These patches of yours are among the first ones that touch it, all other contributions so far have been on Pijul (except one related to fixing clippy warnings). Since I want to avoid any legal issues later, I’m wondering what the current contributors would think of signing a contributor license agreement for libpijul (contributions to Pijul wouldn’t require it). The process would essentially be about PGP-signing a license written by the Harmony project (a project started by Canonical, and used in many open source projects), saying that you transfer copyright of your contributions to the project maintainer.

Would that be ok for you, for example?

Ralith on December 11, 2020

The process would essentially be about PGP-signing

This would be an offputting barrier for me as I don’t maintain a PGP identity.

a license saying that you transfer copyright of your contributions to the project maintainer.

Any form of CLA will require me to go through an approval process with my employer which can otherwise be avoided. I’m not sure my employer is willing to approve CLAs which transfer copyright, though I have blanket approval to contribute to public repositories under nearly any conventional open source license. AFAIK the only reason you’d want this is if you plan to change the license in the future; is that needed? Could you multi-license up front instead, as is common in Rust?

Ralith on December 11, 2020

(I don’t personally mind transferring copyright in principle, but I would like to be able to contribute to Pijul without entering muddy legal waters re: my employment contract, and I work for a major tech employer so I imagine many others will have a similar issue)

pmeunier on December 11, 2020

Thanks for your answer! When you say:

I have blanket approval to contribute to public repositories under nearly any conventional open source license

How does this work in practice? Do you retain copyright of your contributions, and license them to the projects?

pmeunier on December 11, 2020

Alright, I can see simpler ways to do this. I like the way Google does it for Go.

Ralith on December 11, 2020

How does this work in practice?

IANAL, but my understanding is that unless explicitly stated otherwise, contributions made to an open source project are copyrighted by the contributor, and licensed under the terms under which the project is distributed. That’s a matter of copyright law in general rather than employer policy.

the way Google does it for Go.

As in, a CLA that applies an unconditional copyright and broad patent license? That will still require human approval, but seems like better odds. If you like, I can run specifics by the company lawyers before you commit to an approach.

Ralith added a change on December 12, 2020
KFZ2O3FG262FKRRXKGKOFEUSH72AFUPVSBWZEDUJ55CKHNFMQCWAC
main
Ralith added a change on December 12, 2020
NSVBWDHAFFVS4C3IH4SCF7VRAEFSYKLFSMX3DJSPRTJIX5LKJEKQC
pmeunier on January 11, 2021

Alright, I finally found time to review your changes to Pijul. I’ve also rewritten your patches to libpijul. I’m working on a formal solution for the CLA, should be ready soon.

pmeunier closed this discussion on January 11, 2021
pmeunier on January 11, 2021

Thanks!