The sound distributed version control system

#422 crash in diff pager

Closed on April 29, 2021
tankf33der on April 29, 2021

If output from pijul diff --short is long then pressing q to exit from pager crashing it:

name = 'pijul'
operating_system = 'unix:Manjaro'
crate_version = '1.0.0-alpha.48'
explanation = '''
Panic occurred in file 'library/std/src/io/stdio.rs' at line 940
'''
cause = 'failed printing to stdout: Broken pipe (os error 32)'
method = 'Panic'
backtrace = '''

   0: 0x60eefda3b09d - std::io::stdio::print_to::h5d564fa086fa3bf9
                at /build/rust/src/rustc-1.51.0-src/library/std/src/io/stdio.rs:940
                 - std::io::stdio::_print::hf25692e5f3c841b8
                at /build/rust/src/rustc-1.51.0-src/library/std/src/io/stdio.rs:952
   1: 0x60eefd4dad8d - pijul::commands::diff::Diff::run::{{closure}}::hcdfec3e56a1b90f8
   2: 0x60eefd50590d - pijul::run::{{closure}}::h32939ccd524d6628
   3: 0x60eefd4b1090 - <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h59f5213a7b5e360d
   4: 0x60eefd32f1c4 - tokio::runtime::thread_pool::ThreadPool::block_on::h73ad5a92b15fad88
   5: 0x60eefd53b90e - tokio::runtime::Runtime::block_on::he54377b19942c55b
   6: 0x60eefd44f6b6 - pijul::main::h3ffde06d27fb055f
   7: 0x60eefd52a073 - std::sys_common::backtrace::__rust_begin_short_backtrace::h968b9fe3a746d9a9
   8: 0x60eefd417009 - std::rt::lang_start::{{closure}}::h81a35c57a2cb4d4c
   9: 0x60eefda481d7 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h6646ba386ff34dbe
                at /build/rust/src/rustc-1.51.0-src/library/core/src/ops/function.rs:259
                 - std::panicking::try::do_call::h47e376e14a330979
                at /build/rust/src/rustc-1.51.0-src/library/std/src/panicking.rs:379
                 - std::panicking::try::hb7ef6d6b3d4db346
                at /build/rust/src/rustc-1.51.0-src/library/std/src/panicking.rs:343
                 - std::panic::catch_unwind::h534d7ac891813066
                at /build/rust/src/rustc-1.51.0-src/library/std/src/panic.rs:431
                 - std::rt::lang_start_internal::h8191eeb0dbee8736
                at /build/rust/src/rustc-1.51.0-src/library/std/src/rt.rs:51
  10: 0x60eefd44f772 - main
  11: 0x8500e632b25 - __libc_start_main
  12: 0x60eefd2f527e - _start
  13:        0x0 - <unresolved>'''
$
pmeunier added a change on April 29, 2021
ZPGXYRIHQ54KGI7B25T4ASVHCDY7WYFGVJUTZRTQDW6TFIWOG6BAC
main
tankf33der on April 29, 2021

Cant compile, check zulip chat.

pmeunier on April 29, 2021

I’ve pushed a fix to main.

pmeunier closed this discussion on April 29, 2021